0043874: Sessions module could execute twice callbaxkExecutor of OBPOS_LoadPOSWindow hook

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0043874

Retail Modules

Web POS

public

2020-04-27 08:36

2020-08-04 14:31

Reporter

jorge-garcia

Assigned To

ranjith_qualiantech_com

Priority

urgent

Severity

major

Reproducibility

sometimes

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR20Q3

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0043874: Sessions module could execute twice callbaxkExecutor of OBPOS_LoadPOSWindow hook

Description

Sometimes, sessions module hook OBPOS_LoadPOSWindow could execute twice the callbackExcutor, allowing the execution of the callback of OBPOS_LoadPOSWindow before all register hooks has finished.

Steps To Reproduce

1) Login in WebPOS with sessions module, fill required steps
2) Put three breakpoints in the code:
    2.1) Before the execution of OBPOS_LoadPOSWindow hook:
      OB.UTIL.HookManager.executeHooks('OBPOS_LoadPOSWindow', {}, function(args) {
    2.2) In tillCallback function
      } else {
        OB.MobileApp.model.hookManager.callbackExecutor(args, callbacks);
      }
    2.3) At the end of session register hook for OBPOS_LoadPOSWindow:
        args.cancellation = true;
        OB.UTIL.HookManager.callbackExecutor(args, callbacks);
3) Copy this code in Developers Tools:
  OB.UTIL.HookManager.registerHook('OBPOS_LoadPOSWindow', function(args, callbacks) {
    OB.UTIL.showConfirmation.display('Hola', 'hola', [{
      label: OB.I18N.getLabel('OBMOBC_LblOk'),
      isConfirmButton: true,
      action: function () {
        debugger;
        OB.UTIL.HookManager.callbackExecutor(args, callbacks);
      }
    }]);
  });
4) If no business partner is required to set, no initial count cash is needed to be counted, and no cashup is required to be done, the logic of sessions hook calls twice to the callbackExecutor, making the logic of the executeHook to continue before the copied hook has finisehd (it ends once the ok button from popup is clicked).

Proposed Solution

Additional Information