0043839: Business Partner location masterdata load is failing in WebPOS with a large amount of records

Description

Currently the masterdata loading process is failing if the WebPOS has a large number of records in the business partner location table. The problem happens due to pagination, the same location is loaded twice, in different pages, and the insertion process fails because of the duplicated record.

The cause of the problem is that the query is using pagination by id, but in the following issue, the order criteria was changed to order by creation date.

https://issues.openbravo.com/view.php?id=43023 [^]

The change makes sense in the context of the remote mode, but it should not apply to the local model, there we need to enforce order by id.

Steps To Reproduce

- Having a large amount of business partner locations (by default, more than 10k, although this can be reduced by modifying the corresponding preference), try to log in the WebPOS.
- Notice that it fails because of a technical error, due to the fact that insertion of a location failed, because it was already inserted before.

Proposed Solution

We need to change the fix done in issue https://issues.openbravo.com/view.php?id=43023, [^] so that in local mode, we preserve and enforce the order by id regardless of any other consideration.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0043838

closed

ranjith_qualiantech_com

Business Partner location masterdata load is failing in WebPOS with a large amount of records

Notes
(0119483) hgbot (developer) 2020-04-29 06:56	Repository: retail/backports/3.0RR20Q2/org.openbravo.retail.posterminal Changeset: 215756f2b823d15c2654d418a2f603d75348916f Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Wed Apr 29 10:25:59 2020 +0530 URL: http://code.openbravo.com/retail/backports/3.0RR20Q2/org.openbravo.retail.posterminal/rev/215756f2b823d15c2654d418a2f603d75348916f [^] Fixed issue 43839 : Location query ordered by id to improve pagination performance * For Remote mode, location query should be ordered by last updated date or custom orderBy cluase * For nonremote mode, location query should be ordered by id to improve pagination performance --- M src/org/openbravo/retail/posterminal/POSUtils.java M src/org/openbravo/retail/posterminal/master/BPLocation.java ---

Issue History
Date Modified	Username	Field	Change
2020-04-23 12:34	ranjith_qualiantech_com	Type	defect => backport
2020-04-23 12:34	ranjith_qualiantech_com	Target Version	=> RR20Q2
2020-04-29 06:56	hgbot	Checkin
2020-04-29 06:56	hgbot	Note Added: 0119483
2020-04-29 06:56	hgbot	Status	scheduled => resolved
2020-04-29 06:56	hgbot	Resolution	open => fixed
2020-04-29 06:56	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/retail/backports/3.0RR20Q2/org.openbravo.retail.posterminal/rev/215756f2b823d15c2654d418a2f603d75348916f [^]
2020-05-07 09:22	marvintm	Review Assigned To	=> marvintm
2020-05-07 09:22	marvintm	Status	resolved => closed
2020-05-07 09:22	marvintm	Fixed in Version	=> RR20Q3