Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0043838

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

sometimes

2020-04-23 12:23

2020-04-28 16:31

Reporter

marvintm

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

urgent

Resolution

fixed

Fixed in Version

RR20Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

marvintm

Regression level

Packaging and release

Regression date

2020-01-30

Regression introduced in release

main

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c8581f1f793bc6812092f8d302693a332453a9db [^]

Triggers an Emergency Pack

No

Summary

0043838: Business Partner location masterdata load is failing in WebPOS with a large amount of records

Description

Currently the masterdata loading process is failing if the WebPOS has a large number of records in the business partner location table. The problem happens due to pagination, the same location is loaded twice, in different pages, and the insertion process fails because of the duplicated record.

The cause of the problem is that the query is using pagination by id, but in the following issue, the order criteria was changed to order by creation date.

https://issues.openbravo.com/view.php?id=43023 [^]

The change makes sense in the context of the remote mode, but it should not apply to the local model, there we need to enforce order by id.

Steps To Reproduce

- Having a large amount of business partner locations (by default, more than 10k, although this can be reduced by modifying the corresponding preference), try to log in the WebPOS.
- Notice that it fails because of a technical error, due to the fact that insertion of a location failed, because it was already inserted before.

Proposed Solution

We need to change the fix done in issue https://issues.openbravo.com/view.php?id=43023, [^] so that in local mode, we preserve and enforce the order by id regardless of any other consideration.

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on	backport	0043839	RR20Q2	closed	ranjith_qualiantech_com	Business Partner location masterdata load is failing in WebPOS with a large amount of records
caused by	defect	0043023		closed	ranjith_qualiantech_com	The loadBPLocations function of BusinessPartner model is not retrieving the last created/used BPLocation

Notes
(0119375) hgbot (developer) 2020-04-24 02:50	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 834dde2ae9cc34c00f96b167844d37c948867f61 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Fri Apr 24 06:20:12 2020 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/834dde2ae9cc34c00f96b167844d37c948867f61 [^] Fixed issue-43838 : Location query ordered by id to improve pagination performance * For Remote mode, location query should be ordered by last updated date or custom orderBy cluase * For nonremote mode, location query should be ordered by id to improve pagination performance --- M src/org/openbravo/retail/posterminal/POSUtils.java M src/org/openbravo/retail/posterminal/master/BPLocation.java ---

Issue History
Date Modified	Username	Field	Change
2020-04-23 12:23	marvintm	New Issue
2020-04-23 12:23	marvintm	Assigned To	=> Retail
2020-04-23 12:23	marvintm	Triggers an Emergency Pack	=> No
2020-04-23 12:23	marvintm	Regression level	=> Packaging and release
2020-04-23 12:23	marvintm	Regression date	=> 2020-01-30
2020-04-23 12:23	marvintm	Regression introduced in release	=> main
2020-04-23 12:23	marvintm	Regression introduced by commit	=> https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c8581f1f793bc6812092f8d302693a332453a9db [^]
2020-04-23 12:30	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2020-04-23 12:34	ranjith_qualiantech_com	Status	new => scheduled
2020-04-24 02:50	hgbot	Checkin
2020-04-24 02:50	hgbot	Note Added: 0119375
2020-04-24 02:50	hgbot	Status	scheduled => resolved
2020-04-24 02:50	hgbot	Resolution	open => fixed
2020-04-24 02:50	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/834dde2ae9cc34c00f96b167844d37c948867f61 [^]
2020-04-24 20:41	dmitry_mezentsev	Relationship added	caused by 0043023
2020-04-28 16:31	marvintm	Review Assigned To	=> marvintm
2020-04-28 16:31	marvintm	Status	resolved => closed
2020-04-28 16:31	marvintm	Fixed in Version	=> RR20Q3

Copyright © 2000 - 2009 MantisBT Group