Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043744
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2020-04-15 16:202020-04-22 08:15
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in VersionRR20Q3
StatusclosedFix in branchFixed in SCM revision19a7373870cc
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043744: When fixing HQLStyle issues in mobile.core 1 case was not fully fixed

DescriptionThis is follow up to issue 41890 which did not fully fix 1 case inside mobile.core

While it rewrote creation of HQL from StringBuilder to String it missed to remove the old .toString() call added when using the StringBuilder.

As calling toString() on a String is not useful that should be removed.
Also not having that fixed triggers still false positives with our automation.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0041890 closedalekosmp86 StringBuffer/Builder in Retail modules should be replaced by String 

-  Notes
(0119188)
hgbot (developer)
2020-04-15 16:23

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 19a7373870cce0922a202701fec5648c2503241f
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Apr 15 16:22:40 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/19a7373870cce0922a202701fec5648c2503241f [^]

Fixes ISSUE-43744: Remove useless <String>.toString() call

This is small follow up fix to 43572. That issue replaced StringBuilder
append chains with a simple String but missed to remove the final toString()
call.

---
M src/org/openbravo/mobile/core/login/ProfileUtils.java
---

- Issue History
Date Modified Username Field Change
2020-04-15 16:20 shuehner New Issue
2020-04-15 16:20 shuehner Assigned To => shuehner
2020-04-15 16:20 shuehner OBNetwork customer => No
2020-04-15 16:20 shuehner Triggers an Emergency Pack => No
2020-04-15 16:20 shuehner Relationship added related to 0041890
2020-04-15 16:23 hgbot Checkin
2020-04-15 16:23 hgbot Note Added: 0119188
2020-04-15 16:23 hgbot Status new => resolved
2020-04-15 16:23 hgbot Resolution open => fixed
2020-04-15 16:23 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/19a7373870cce0922a202701fec5648c2503241f [^]
2020-04-15 16:24 shuehner Review Assigned To => marvintm
2020-04-22 08:15 marvintm Status resolved => closed
2020-04-22 08:15 marvintm Fixed in Version => RR20Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker