Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043744Retail ModulesWeb POSpublic2020-04-15 16:202020-04-22 08:15
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043744: When fixing HQLStyle issues in mobile.core 1 case was not fully fixed
DescriptionThis is follow up to issue 41890 which did not fully fix 1 case inside mobile.core

While it rewrote creation of HQL from StringBuilder to String it missed to remove the old .toString() call added when using the StringBuilder.

As calling toString() on a String is not useful that should be removed.
Also not having that fixed triggers still false positives with our automation.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041890 closed alekosmp86 StringBuffer/Builder in Retail modules should be replaced by String 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-04-15 16:20shuehnerNew Issue
2020-04-15 16:20shuehnerAssigned To => shuehner
2020-04-15 16:20shuehnerOBNetwork customer => No
2020-04-15 16:20shuehnerTriggers an Emergency Pack => No
2020-04-15 16:20shuehnerRelationship addedrelated to 0041890
2020-04-15 16:23hgbotCheckin
2020-04-15 16:23hgbotNote Added: 0119188
2020-04-15 16:23hgbotStatusnew => resolved
2020-04-15 16:23hgbotResolutionopen => fixed
2020-04-15 16:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/19a7373870cce0922a202701fec5648c2503241f [^]
2020-04-15 16:24shuehnerReview Assigned To => marvintm
2020-04-22 08:15marvintmStatusresolved => closed
2020-04-22 08:15marvintmFixed in Version => RR20Q3

Notes
(0119188)
hgbot   
2020-04-15 16:23   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 19a7373870cce0922a202701fec5648c2503241f
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Apr 15 16:22:40 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/19a7373870cce0922a202701fec5648c2503241f [^]

Fixes ISSUE-43744: Remove useless <String>.toString() call

This is small follow up fix to 43572. That issue replaced StringBuilder
append chains with a simple String but missed to remove the final toString()
call.

---
M src/org/openbravo/mobile/core/login/ProfileUtils.java
---