Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0043733

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Scaled Price

major

always

2020-04-14 15:32

2020-04-24 03:44

Reporter

guillermogil

View Status

public

Assigned To

prakashmurugesan88

Priority

normal

Resolution

fixed

Fixed in Version

RR20Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Gold

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0043733: Scaled Price module has a non declared dependency to By Total Module

Description

Scaled Price module has a non declared dependency to By Total Module which I think it is not strictly needed:
     [echo] Compiling...
     [java] ----------
     [java] 1. ERROR in /srv/ci/workspace/mod-simple-ci40.18104/modules/org.openbravo.retail.discounts.scaledprice/src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceTest.java (at line 17)
     [java] import org.openbravo.discounts.bytotal.test.base.model.definition.ByTotalAmount;
     [java] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     [java] The import org.openbravo.discounts.bytotal cannot be resolved
     [java] ----------
     [java] 2. ERROR in /srv/ci/workspace/mod-simple-ci40.18104/modules/org.openbravo.retail.discounts.scaledprice/src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceTest.java (at line 203)
     [java] .withRule(ByTotalAmount.newInstance()
     [java] ^^^^^^^^^^^^^
     [java] ByTotalAmount cannot be resolved
     [java] ----------
     [java] ----------
     [java] 3. ERROR in /srv/ci/workspace/mod-simple-ci40.18104/modules/org.openbravo.retail.discounts.scaledprice/src-test/org/openbravo/discounts/scaledprice/test/unittests/I38736_VerifyScalePriceDiscountTest.java (at line 13)
     [java] import org.openbravo.discounts.bytotal.test.base.model.ByTotalDiscountsFromUser;
     [java] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     [java] The import org.openbravo.discounts.bytotal cannot be resolved
     [java] ----------
     [java] 4. ERROR in /srv/ci/workspace/mod-simple-ci40.18104/modules/org.openbravo.retail.discounts.scaledprice/src-test/org/openbravo/discounts/scaledprice/test/unittests/I38736_VerifyScalePriceDiscountTest.java (at line 51)
     [java] .withDiscountsFromUser(ByTotalDiscountsFromUser.newInstance()
     [java] ^^^^^^^^^^^^^^^^^^^^^^^^
     [java] ByTotalDiscountsFromUser cannot be resolved

Steps To Reproduce

Review the code without by total module installed.
Also if you try to execute the tests if will fail.

Proposed Solution

Remove the dependency in the code as it does not seems to be dependent modules.

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0119345) hgbot (developer) 2020-04-23 08:34	Repository: erp/pmods/org.openbravo.retail.discounts.scaledprice Changeset: 00838b1763a932837a5a5b9fd159ae7b25296d24 Author: Prakash M <prakash <at> qualiantech.com> Date: Thu Apr 23 12:03:38 2020 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.scaledprice/rev/00838b1763a932837a5a5b9fd159ae7b25296d24 [^] Fixed BUG-43733: Fixed ByTotal module dependent code in scaled price junit tests --- M src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceTest.java M src-test/org/openbravo/discounts/scaledprice/test/unittests/I38736_VerifyScalePriceDiscountTest.java ---

(0119377) hgbot (developer) 2020-04-24 03:44	Repository: erp/pmods/org.openbravo.retail.discounts.scaledprice Changeset: 0708fe45d1a66839b2461c1a82a063cace0b6dc1 Author: Prakash M <prakash <at> qualiantech.com> Date: Fri Apr 24 07:13:08 2020 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.scaledprice/rev/0708fe45d1a66839b2461c1a82a063cace0b6dc1 [^] Related to BUG-43733: Removed unused imports --- M src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceTest.java M src-test/org/openbravo/discounts/scaledprice/test/unittests/I38736_VerifyScalePriceDiscountTest.java ---

Issue History
Date Modified	Username	Field	Change
2020-04-14 15:32	guillermogil	New Issue
2020-04-14 15:32	guillermogil	Assigned To	=> Retail
2020-04-14 15:32	guillermogil	OBNetwork customer	=> Gold
2020-04-14 15:32	guillermogil	Resolution time	=> 1588197600
2020-04-14 15:32	guillermogil	Triggers an Emergency Pack	=> No
2020-04-21 09:13	prakashmurugesan88	Assigned To	Retail => prakashmurugesan88
2020-04-23 08:34	hgbot	Checkin
2020-04-23 08:34	hgbot	Note Added: 0119345
2020-04-23 08:34	hgbot	Status	new => resolved
2020-04-23 08:34	hgbot	Resolution	open => fixed
2020-04-23 08:34	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.scaledprice/rev/00838b1763a932837a5a5b9fd159ae7b25296d24 [^]
2020-04-23 10:30	marvintm	Review Assigned To	=> marvintm
2020-04-23 10:30	marvintm	Status	resolved => closed
2020-04-23 10:30	marvintm	Fixed in Version	=> RR20Q3
2020-04-24 03:44	hgbot	Checkin
2020-04-24 03:44	hgbot	Note Added: 0119377

Copyright © 2000 - 2009 MantisBT Group