Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043733Retail ModulesScaled Pricepublic2020-04-14 15:322020-04-24 03:44
Reporterguillermogil 
Assigned Toprakashmurugesan88 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043733: Scaled Price module has a non declared dependency to By Total Module
DescriptionScaled Price module has a non declared dependency to By Total Module which I think it is not strictly needed:
     [echo] Compiling...
     [java] ----------
     [java] 1. ERROR in /srv/ci/workspace/mod-simple-ci40.18104/modules/org.openbravo.retail.discounts.scaledprice/src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceTest.java (at line 17)
     [java] import org.openbravo.discounts.bytotal.test.base.model.definition.ByTotalAmount;
     [java] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     [java] The import org.openbravo.discounts.bytotal cannot be resolved
     [java] ----------
     [java] 2. ERROR in /srv/ci/workspace/mod-simple-ci40.18104/modules/org.openbravo.retail.discounts.scaledprice/src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceTest.java (at line 203)
     [java] .withRule(ByTotalAmount.newInstance()
     [java] ^^^^^^^^^^^^^
     [java] ByTotalAmount cannot be resolved
     [java] ----------
     [java] ----------
     [java] 3. ERROR in /srv/ci/workspace/mod-simple-ci40.18104/modules/org.openbravo.retail.discounts.scaledprice/src-test/org/openbravo/discounts/scaledprice/test/unittests/I38736_VerifyScalePriceDiscountTest.java (at line 13)
     [java] import org.openbravo.discounts.bytotal.test.base.model.ByTotalDiscountsFromUser;
     [java] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     [java] The import org.openbravo.discounts.bytotal cannot be resolved
     [java] ----------
     [java] 4. ERROR in /srv/ci/workspace/mod-simple-ci40.18104/modules/org.openbravo.retail.discounts.scaledprice/src-test/org/openbravo/discounts/scaledprice/test/unittests/I38736_VerifyScalePriceDiscountTest.java (at line 51)
     [java] .withDiscountsFromUser(ByTotalDiscountsFromUser.newInstance()
     [java] ^^^^^^^^^^^^^^^^^^^^^^^^
     [java] ByTotalDiscountsFromUser cannot be resolved
Steps To ReproduceReview the code without by total module installed.
Also if you try to execute the tests if will fail.
Proposed SolutionRemove the dependency in the code as it does not seems to be dependent modules.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-04-14 15:32guillermogilNew Issue
2020-04-14 15:32guillermogilAssigned To => Retail
2020-04-14 15:32guillermogilOBNetwork customer => Gold
2020-04-14 15:32guillermogilResolution time => 1588197600
2020-04-14 15:32guillermogilTriggers an Emergency Pack => No
2020-04-21 09:13prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-04-23 08:34hgbotCheckin
2020-04-23 08:34hgbotNote Added: 0119345
2020-04-23 08:34hgbotStatusnew => resolved
2020-04-23 08:34hgbotResolutionopen => fixed
2020-04-23 08:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.scaledprice/rev/00838b1763a932837a5a5b9fd159ae7b25296d24 [^]
2020-04-23 10:30marvintmReview Assigned To => marvintm
2020-04-23 10:30marvintmStatusresolved => closed
2020-04-23 10:30marvintmFixed in Version => RR20Q3
2020-04-24 03:44hgbotCheckin
2020-04-24 03:44hgbotNote Added: 0119377

Notes
(0119345)
hgbot   
2020-04-23 08:34   
Repository: erp/pmods/org.openbravo.retail.discounts.scaledprice
Changeset: 00838b1763a932837a5a5b9fd159ae7b25296d24
Author: Prakash M <prakash <at> qualiantech.com>
Date: Thu Apr 23 12:03:38 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.scaledprice/rev/00838b1763a932837a5a5b9fd159ae7b25296d24 [^]

Fixed BUG-43733: Fixed ByTotal module dependent code in scaled price junit tests

---
M src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceTest.java
M src-test/org/openbravo/discounts/scaledprice/test/unittests/I38736_VerifyScalePriceDiscountTest.java
---
(0119377)
hgbot   
2020-04-24 03:44   
Repository: erp/pmods/org.openbravo.retail.discounts.scaledprice
Changeset: 0708fe45d1a66839b2461c1a82a063cace0b6dc1
Author: Prakash M <prakash <at> qualiantech.com>
Date: Fri Apr 24 07:13:08 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.scaledprice/rev/0708fe45d1a66839b2461c1a82a063cace0b6dc1 [^]

Related to BUG-43733: Removed unused imports

---
M src-test/org/openbravo/discounts/scaledprice/test/unittests/DiscountScaledPriceTest.java
M src-test/org/openbravo/discounts/scaledprice/test/unittests/I38736_VerifyScalePriceDiscountTest.java
---