Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0043629
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Copy Retail Storemajoralways2020-04-01 11:352020-04-24 14:37
ReportermaiteView Statuspublic 
Assigned Toguilleaer 
PriorityurgentResolutionfixedFixed in VersionRR20Q3
StatusclosedFix in branchFixed in SCM revision1ccf6aa1ff89
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression levelProduction - Confirmed Stable
Regression date2019-09-19
Regression introduced in releaseRR19Q4
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/961b3a93eb69b9346ab196599e6d9ca746c5d498 [^]
Triggers an Emergency PackNo
Summary

0043629: Copy Store process is creating erroneous role's name

DescriptionRoles are created for * organization and the search key of that organization is 0. When creating the role the Copy Store process will substitute the organization's search key value of role's name by the new store's name. In that case, the process substitutes the 0's by organization's name
Steps To Reproduce0. Access to Copy Store Parametrization window and create new record filling all fields
1. Access to Role window and create new record for:
  organization= *
  name= test0805
  user level= Client+Organization
  manual= Y
  add a record in Org Access tab for Vall Blanca Store
2. Access to Copy Retail Store window and set the following values:
  Store to copy= Vall Blanca Store
  Parent org= White Valley Spain S.A
  Defaults= your previous parameterization record
  Search key= NewStore1
  Name= NewStore
  Country= Spain
  Business Partner Category= Customer
  Use file= N
  POS Terminal Search key = NS1
3. Run process and the new store will be created
4. Access to Role window and realize that role created has an incorrect name "testNewStore8NewStore5-NewStore"

NOTE: as you can see would be very easy to exceed the limit of 60 characters in role name length which will prevent the user to create the new store having a higher impact in the business
TagsNo tags attached.
Attached Filespatch file icon 43629.patch [^] (1,442 bytes) 2020-04-03 18:59 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
caused by defect 0041634 closedrqueralta Request to create a new centralized function to check if the new Object created contains the same name or search key 
related to defect 0043800 closedguilleaer Copy Retail Store process is creating erroneous Role name 

-  Notes
(0119097)
hgbot (developer)
2020-04-08 13:01

Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 99f7903b0d03a14656e9e7569c45dc7e410d934c
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Apr 08 13:01:44 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/99f7903b0d03a14656e9e7569c45dc7e410d934c [^]

fixed BUG 43629: don't replace org for roles

---
M src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
---
(0119147)
guilleaer (manager)
2020-04-14 10:35

Backed out previous commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/d343e965ee00 [^]
(0119164)
hgbot (developer)
2020-04-14 19:59

Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 52eec7851a73e4d37bff7a69c46de48a55b98e6c
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Apr 14 14:16:29 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/52eec7851a73e4d37bff7a69c46de48a55b98e6c [^]

Fixed BUG 43629: Use store org name to replace during copy-store process

---
M src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
---
(0119237)
guillermogil (manager)
2020-04-17 12:39

It fails while doing Copy Terminal:

2020-04-17 07:53:35,746 [http-3] ERROR org.openbravo.retail.copystore.process.CopyStoreProcess - Error in process
java.lang.NullPointerException: null
at org.openbravo.retail.copystore.process.CopyStoreProcess.cloneObject(CopyStoreProcess.java:492) ~[classes/:?]
at org.openbravo.retail.copystore.process.CopyStoreProcess.copySingleTerminal(CopyStoreProcess.java:733) [classes/:?]
at org.openbravo.retail.copystore.process.CopyStoreProcess.executeCopyTerminal(CopyStoreProcess.java:376) [classes/:?]
at org.openbravo.retail.copystore.process.CopyTerminalActionHandler.executeProcess(CopyTerminalActionHandler.java:29) [classes/:?]
at org.openbravo.retail.copystore.process.CopyBaseActionHandler.doExecute(CopyBaseActionHandler.java:125) [classes/:?]
at org.openbravo.client.application.process.BaseProcessActionHandler.execute(BaseProcessActionHandler.java:153) [classes/:?]
at org.openbravo.client.kernel.BaseActionHandler.execute(BaseActionHandler.java:74) [classes/:?]
at org.openbravo.retail.copystore.process.CopyBaseActionHandler.execute(CopyBaseActionHandler.java:68) [classes/:?]
at org.openbravo.client.kernel.KernelServlet.processActionRequest(KernelServlet.java:317) [classes/:?]
at org.openbravo.client.kernel.KernelServlet.doGet(KernelServlet.java:207) [classes/:?]
at org.openbravo.client.kernel.KernelServlet.doPost(KernelServlet.java:289) [classes/:?]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:661) [tomcat8-servlet-api-8.5.39.jar:?]
(0119247)
hgbot (developer)
2020-04-19 19:25

Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 52dd61e1e1ed3e3d6fcf95ffc0694eb7e1f421bd
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Sun Apr 19 19:25:26 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/52dd61e1e1ed3e3d6fcf95ffc0694eb7e1f421bd [^]

Related to BUG 43629: Backout previous changeset. Copy terminal is not working

---
M src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
---
(0119280)
hgbot (developer)
2020-04-21 09:26

Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 1ccf6aa1ff89141c6a264645bd424846da002bc6
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Apr 21 09:25:47 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/1ccf6aa1ff89141c6a264645bd424846da002bc6 [^]

Fixed BUG 43629 43800 replace old org name by newStore org name. Improve logic for roles

---
M src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---

- Issue History
Date Modified Username Field Change
2020-04-01 11:35 maite New Issue
2020-04-01 11:35 maite Assigned To => Retail
2020-04-01 11:35 maite Resolution time => 1587506400
2020-04-01 11:35 maite Triggers an Emergency Pack => No
2020-04-01 11:35 maite Issue Monitored: networkb
2020-04-02 22:04 alekosmp86 Assigned To Retail => alekosmp86
2020-04-02 22:04 alekosmp86 Status new => scheduled
2020-04-03 18:59 alekosmp86 File Added: 43629.patch
2020-04-08 12:56 guilleaer Regression level => Production - Confirmed Stable
2020-04-08 12:56 guilleaer Regression date => 2019-09-19
2020-04-08 12:56 guilleaer Regression introduced in release => RR19Q4
2020-04-08 12:56 guilleaer Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/961b3a93eb69b9346ab196599e6d9ca746c5d498 [^]
2020-04-08 13:01 hgbot Checkin
2020-04-08 13:01 hgbot Note Added: 0119097
2020-04-08 13:01 hgbot Status scheduled => resolved
2020-04-08 13:01 hgbot Resolution open => fixed
2020-04-08 13:01 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/99f7903b0d03a14656e9e7569c45dc7e410d934c [^]
2020-04-14 10:35 guilleaer Note Added: 0119147
2020-04-14 10:35 guilleaer Assigned To alekosmp86 => Retail
2020-04-14 10:35 guilleaer Status resolved => new
2020-04-14 10:35 guilleaer Resolution fixed => open
2020-04-14 19:59 hgbot Checkin
2020-04-14 19:59 hgbot Note Added: 0119164
2020-04-14 19:59 hgbot Status new => resolved
2020-04-14 19:59 hgbot Resolution open => fixed
2020-04-14 19:59 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/99f7903b0d03a14656e9e7569c45dc7e410d934c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/52eec7851a73e4d37bff7a69c46de48a55b98e6c [^]
2020-04-15 09:13 marvintm Assigned To Retail => guilleaer
2020-04-17 10:53 dmitry_mezentsev Relationship added caused by 0041634
2020-04-17 12:39 guillermogil Note Added: 0119237
2020-04-17 12:39 guillermogil Status resolved => new
2020-04-17 12:39 guillermogil Resolution fixed => open
2020-04-19 19:25 hgbot Checkin
2020-04-19 19:25 hgbot Note Added: 0119247
2020-04-20 16:23 Leyre Relationship added related to 0043800
2020-04-21 09:26 hgbot Checkin
2020-04-21 09:26 hgbot Note Added: 0119280
2020-04-21 09:26 hgbot Status new => resolved
2020-04-21 09:26 hgbot Resolution open => fixed
2020-04-21 09:26 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/52eec7851a73e4d37bff7a69c46de48a55b98e6c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/1ccf6aa1ff89141c6a264645bd424846da002bc6 [^]
2020-04-24 14:37 marvintm Review Assigned To => marvintm
2020-04-24 14:37 marvintm Status resolved => closed
2020-04-24 14:37 marvintm Fixed in Version => RR20Q3


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker