Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043629Retail ModulesCopy Retail Storepublic2020-04-01 11:352020-04-24 14:37
Reportermaite 
Assigned Toguilleaer 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2019-09-19
Regression introduced in releaseRR19Q4
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/961b3a93eb69b9346ab196599e6d9ca746c5d498 [^]
Triggers an Emergency PackNo
Summary0043629: Copy Store process is creating erroneous role's name
DescriptionRoles are created for * organization and the search key of that organization is 0. When creating the role the Copy Store process will substitute the organization's search key value of role's name by the new store's name. In that case, the process substitutes the 0's by organization's name
Steps To Reproduce0. Access to Copy Store Parametrization window and create new record filling all fields
1. Access to Role window and create new record for:
  organization= *
  name= test0805
  user level= Client+Organization
  manual= Y
  add a record in Org Access tab for Vall Blanca Store
2. Access to Copy Retail Store window and set the following values:
  Store to copy= Vall Blanca Store
  Parent org= White Valley Spain S.A
  Defaults= your previous parameterization record
  Search key= NewStore1
  Name= NewStore
  Country= Spain
  Business Partner Category= Customer
  Use file= N
  POS Terminal Search key = NS1
3. Run process and the new store will be created
4. Access to Role window and realize that role created has an incorrect name "testNewStore8NewStore5-NewStore"

NOTE: as you can see would be very easy to exceed the limit of 60 characters in role name length which will prevent the user to create the new store having a higher impact in the business
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0041634 closed rqueralta Request to create a new centralized function to check if the new Object created contains the same name or search key 
related to defect 0043800 closed guilleaer Copy Retail Store process is creating erroneous Role name 
Attached Filespatch 43629.patch (1,442) 2020-04-03 18:59
https://issues.openbravo.com/file_download.php?file_id=14268&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-04-01 11:35maiteNew Issue
2020-04-01 11:35maiteAssigned To => Retail
2020-04-01 11:35maiteResolution time => 1587506400
2020-04-01 11:35maiteTriggers an Emergency Pack => No
2020-04-01 11:35maiteIssue Monitored: networkb
2020-04-02 22:04alekosmp86Assigned ToRetail => alekosmp86
2020-04-02 22:04alekosmp86Statusnew => scheduled
2020-04-03 18:59alekosmp86File Added: 43629.patch
2020-04-08 12:56guilleaerRegression level => Production - Confirmed Stable
2020-04-08 12:56guilleaerRegression date => 2019-09-19
2020-04-08 12:56guilleaerRegression introduced in release => RR19Q4
2020-04-08 12:56guilleaerRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/961b3a93eb69b9346ab196599e6d9ca746c5d498 [^]
2020-04-08 13:01hgbotCheckin
2020-04-08 13:01hgbotNote Added: 0119097
2020-04-08 13:01hgbotStatusscheduled => resolved
2020-04-08 13:01hgbotResolutionopen => fixed
2020-04-08 13:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/99f7903b0d03a14656e9e7569c45dc7e410d934c [^]
2020-04-14 10:35guilleaerNote Added: 0119147
2020-04-14 10:35guilleaerAssigned Toalekosmp86 => Retail
2020-04-14 10:35guilleaerStatusresolved => new
2020-04-14 10:35guilleaerResolutionfixed => open
2020-04-14 19:59hgbotCheckin
2020-04-14 19:59hgbotNote Added: 0119164
2020-04-14 19:59hgbotStatusnew => resolved
2020-04-14 19:59hgbotResolutionopen => fixed
2020-04-14 19:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/99f7903b0d03a14656e9e7569c45dc7e410d934c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/52eec7851a73e4d37bff7a69c46de48a55b98e6c [^]
2020-04-15 09:13marvintmAssigned ToRetail => guilleaer
2020-04-17 10:53dmitry_mezentsevRelationship addedcaused by 0041634
2020-04-17 12:39guillermogilNote Added: 0119237
2020-04-17 12:39guillermogilStatusresolved => new
2020-04-17 12:39guillermogilResolutionfixed => open
2020-04-19 19:25hgbotCheckin
2020-04-19 19:25hgbotNote Added: 0119247
2020-04-20 16:23LeyreRelationship addedrelated to 0043800
2020-04-21 09:26hgbotCheckin
2020-04-21 09:26hgbotNote Added: 0119280
2020-04-21 09:26hgbotStatusnew => resolved
2020-04-21 09:26hgbotResolutionopen => fixed
2020-04-21 09:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/52eec7851a73e4d37bff7a69c46de48a55b98e6c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/1ccf6aa1ff89141c6a264645bd424846da002bc6 [^]
2020-04-24 14:37marvintmReview Assigned To => marvintm
2020-04-24 14:37marvintmStatusresolved => closed
2020-04-24 14:37marvintmFixed in Version => RR20Q3

Notes
(0119097)
hgbot   
2020-04-08 13:01   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 99f7903b0d03a14656e9e7569c45dc7e410d934c
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Apr 08 13:01:44 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/99f7903b0d03a14656e9e7569c45dc7e410d934c [^]

fixed BUG 43629: don't replace org for roles

---
M src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
---
(0119147)
guilleaer   
2020-04-14 10:35   
Backed out previous commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/d343e965ee00 [^]
(0119164)
hgbot   
2020-04-14 19:59   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 52eec7851a73e4d37bff7a69c46de48a55b98e6c
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Apr 14 14:16:29 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/52eec7851a73e4d37bff7a69c46de48a55b98e6c [^]

Fixed BUG 43629: Use store org name to replace during copy-store process

---
M src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
---
(0119237)
guillermogil   
2020-04-17 12:39   
It fails while doing Copy Terminal:

2020-04-17 07:53:35,746 [http-3] ERROR org.openbravo.retail.copystore.process.CopyStoreProcess - Error in process
java.lang.NullPointerException: null
at org.openbravo.retail.copystore.process.CopyStoreProcess.cloneObject(CopyStoreProcess.java:492) ~[classes/:?]
at org.openbravo.retail.copystore.process.CopyStoreProcess.copySingleTerminal(CopyStoreProcess.java:733) [classes/:?]
at org.openbravo.retail.copystore.process.CopyStoreProcess.executeCopyTerminal(CopyStoreProcess.java:376) [classes/:?]
at org.openbravo.retail.copystore.process.CopyTerminalActionHandler.executeProcess(CopyTerminalActionHandler.java:29) [classes/:?]
at org.openbravo.retail.copystore.process.CopyBaseActionHandler.doExecute(CopyBaseActionHandler.java:125) [classes/:?]
at org.openbravo.client.application.process.BaseProcessActionHandler.execute(BaseProcessActionHandler.java:153) [classes/:?]
at org.openbravo.client.kernel.BaseActionHandler.execute(BaseActionHandler.java:74) [classes/:?]
at org.openbravo.retail.copystore.process.CopyBaseActionHandler.execute(CopyBaseActionHandler.java:68) [classes/:?]
at org.openbravo.client.kernel.KernelServlet.processActionRequest(KernelServlet.java:317) [classes/:?]
at org.openbravo.client.kernel.KernelServlet.doGet(KernelServlet.java:207) [classes/:?]
at org.openbravo.client.kernel.KernelServlet.doPost(KernelServlet.java:289) [classes/:?]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:661) [tomcat8-servlet-api-8.5.39.jar:?]
(0119247)
hgbot   
2020-04-19 19:25   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 52dd61e1e1ed3e3d6fcf95ffc0694eb7e1f421bd
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Sun Apr 19 19:25:26 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/52dd61e1e1ed3e3d6fcf95ffc0694eb7e1f421bd [^]

Related to BUG 43629: Backout previous changeset. Copy terminal is not working

---
M src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
---
(0119280)
hgbot   
2020-04-21 09:26   
Repository: erp/pmods/org.openbravo.retail.copystore
Changeset: 1ccf6aa1ff89141c6a264645bd424846da002bc6
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Apr 21 09:25:47 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.copystore/rev/1ccf6aa1ff89141c6a264645bd424846da002bc6 [^]

Fixed BUG 43629 43800 replace old org name by newStore org name. Improve logic for roles

---
M src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---