0043543: ProductCharacteristicValue does not finish on incremental

# HG changeset patch # User Prakash M <prakash@qualiantech.com> # Date 1585979808 -19800 # Sat Apr 04 11:26:48 2020 +0530 # Node ID 1e76636d47ca8d4b81319511abdbd01fbd14bc62 # Parent c10b4e25abb77408cd3fedd3bebcf35e250aab5b Fixed BUG-43543: Fixes ProductCharacteristicValue does not finish on incremental diff -r c10b4e25abb7 -r 1e76636d47ca src-db/database/model/triggers/OBPOS_PRODUCT_CH_VALUE_TRG.xml --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/src-db/database/model/triggers/OBPOS_PRODUCT_CH_VALUE_TRG.xml Sat Apr 04 11:26:48 2020 +0530 @@ -0,0 +1,35 @@ +<?xml version="1.0"?> + <database name="TRIGGER OBPOS_PRODUCT_CH_VALUE_TRG"> + <trigger name="OBPOS_PRODUCT_CH_VALUE_TRG" table="M_PRODUCT_CH_VALUE" fires="after" insert="true" update="true" delete="false" foreach="row"> + <body><![CDATA[ + /************************************************************************* + * The contents of this file are subject to the Compiere Public + * License 1.1 ("License"); You may not use this file except in + * compliance with the License. You may obtain a copy of the License in + * the legal folder of your Openbravo installation. + * Software distributed under the License is distributed on an + * "AS IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or + * implied. See the License for the specific language governing rights + * and limitations under the License. + * The Original Code is Compiere ERP & Business Solution + * The Initial Developer of the Original Code is Jorg Janke and ComPiere, Inc. + * Portions created by Jorg Janke are Copyright (C) 1999-2001 Jorg Janke, + * parts created by ComPiere are Copyright (C) ComPiere, Inc.; + * All Rights Reserved. + * Contributor(s): Openbravo SLU + * Contributions are Copyright (C) 2020 Openbravo, S.L.U. + ************************************************************************/ + +BEGIN + IF AD_isTriggerEnabled()='N' THEN RETURN; + END IF; + + IF (INSERTING OR UPDATING) THEN + UPDATE M_PRODUCT SET Updated=:new.Updated, UpdatedBy=:new.UpdatedBy + WHERE M_PRODUCT_ID = :new.M_PRODUCT_ID; + END IF; + +END OBPOS_PRODUCT_CH_VALUE_TRG +]]></body> + </trigger> + </database> diff -r c10b4e25abb7 -r 1e76636d47ca src/org/openbravo/retail/posterminal/master/ProductCharacteristicValue.java --- a/src/org/openbravo/retail/posterminal/master/ProductCharacteristicValue.java Sat Apr 04 11:09:05 2020 +0530 +++ b/src/org/openbravo/retail/posterminal/master/ProductCharacteristicValue.java Sat Apr 04 11:26:48 2020 +0530 @@ -1,6 +1,6 @@ /* ************************************************************************************ - * Copyright (C) 2015-2019 Openbravo S.L.U. + * Copyright (C) 2015-2020 Openbravo S.L.U. * Licensed under the Openbravo Commercial License version 1.0 * You may obtain a copy of the License at http://www.openbravo.com/legal/obcl.html * or in the legal folder of this module distribution. @@ -151,10 +151,7 @@ query.append(" and characteristicValue.$incrementalUpdateCriteria)"); } else { query.append(" and (opp.$incrementalUpdateCriteria"); - query.append(" or ppp.$incrementalUpdateCriteria"); - query.append(" or pcv.$incrementalUpdateCriteria"); - query.append(" or characteristic.$incrementalUpdateCriteria"); - query.append(" or characteristicValue.$incrementalUpdateCriteria)"); + query.append(" or product.$incrementalUpdateCriteria)"); } } query.append(" order by pcv.id");

Notes
(0119079) hgbot (developer) 2020-04-08 07:34	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 9ba9e518f396c10e4cde20d5a093600da14c88b5 Author: Prakash M <prakash <at> qualiantech.com> Date: Wed Apr 08 10:51:56 2020 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9ba9e518f396c10e4cde20d5a093600da14c88b5 [^] Fixed BUG-43543: Fixes ProductCharacteristicValue does not finish on incremental --- M src/org/openbravo/retail/posterminal/master/ProductCharacteristicValue.java A src-db/database/model/triggers/OBPOS_PRODUCT_CH_VALUE_TRG.xml ---

(0119107) hgbot (developer) 2020-04-08 18:10	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: f10f950495c8cf79c2a0b8b593d594b3518ccaa9 Author: Prakash M <prakash <at> qualiantech.com> Date: Wed Apr 08 21:39:12 2020 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f10f950495c8cf79c2a0b8b593d594b3518ccaa9 [^] Related BUG-43543: Updated license of trigger OBPOS_PRODUCT_CH_VALUE_TRG --- M src-db/database/model/triggers/OBPOS_PRODUCT_CH_VALUE_TRG.xml ---

(0119167) prakashmurugesan88 (developer) 2020-04-15 07:46	Following criteria are removed, [Price List] - Price List will not affect Product Characteristics Value data. [Product Characteristics Value] - Handled in product criteria using trigger(updates product updated date when Product Characteristics Value is changed) . So it is ok to remove this criteria. [Characteristics, Characteristics Value] - It is ok remove these criteria. As per discussion with Antonio, if we disable characteristics or characteristic values, they won't be immediately reflected in the WebPOS products. However, I don't think this is a big concern, because anyway the user will no longer see those filters as the characteristics and characteristic values models will be updated. And when they are enabled, the user will anyway need to specify values first for those characteristics before they do anything, and update the main filter column, so I don't think it would be a problem either.

Issue History
Date Modified	Username	Field	Change
2020-03-23 12:24	guillermogil	New Issue
2020-03-23 12:24	guillermogil	Assigned To	=> Retail
2020-03-23 12:24	guillermogil	Resolution time	=> 1586728800
2020-03-23 12:24	guillermogil	Triggers an Emergency Pack	=> No
2020-03-23 12:27	guillermogil	File Added: 43543.diff
2020-03-23 12:27	guillermogil	Tag Attached: Performance
2020-03-23 12:28	guillermogil	Description Updated	View Revisions
2020-03-23 14:05	rqueralta	Assigned To	Retail => rqueralta
2020-03-23 14:05	rqueralta	Status	new => scheduled
2020-04-02 10:10	guilleaer	Assigned To	rqueralta => Retail
2020-04-02 10:44	guilleaer	Assigned To	Retail => guilleaer
2020-04-02 10:45	guilleaer	Assigned To	guilleaer => prakashmurugesan88
2020-04-04 07:59	prakashmurugesan88	File Added: 43543_Complete.patch
2020-04-06 08:59	guilleaer	File Deleted: 43543.diff
2020-04-08 07:34	hgbot	Checkin
2020-04-08 07:34	hgbot	Note Added: 0119079
2020-04-08 07:34	hgbot	Status	scheduled => resolved
2020-04-08 07:34	hgbot	Resolution	open => fixed
2020-04-08 07:34	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9ba9e518f396c10e4cde20d5a093600da14c88b5 [^]
2020-04-08 08:35	guillermogil	Relationship added	related to 0043587
2020-04-08 18:10	hgbot	Checkin
2020-04-08 18:10	hgbot	Note Added: 0119107
2020-04-09 13:29	prakashmurugesan88	Status	resolved => new
2020-04-09 13:29	prakashmurugesan88	Resolution	fixed => open
2020-04-09 13:29	prakashmurugesan88	Status	new => scheduled
2020-04-15 07:46	prakashmurugesan88	Note Added: 0119167
2020-04-15 07:51	prakashmurugesan88	Status	scheduled => resolved
2020-04-15 07:51	prakashmurugesan88	Resolution	open => fixed
2020-04-16 19:00	marvintm	Review Assigned To	=> marvintm
2020-04-16 19:00	marvintm	Status	resolved => closed
2020-04-16 19:00	marvintm	Fixed in Version	=> RR20Q3