Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043543Retail ModulesWeb POSpublic2020-03-23 12:242020-04-16 19:00
Reporterguillermogil 
Assigned Toprakashmurugesan88 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043543: ProductCharacteristicValue does not finish on incremental
DescriptionProductCharacteristicValue does not finish on incremental with a big database.
The incremental filter of the query takes ages to finish as it is looking for 5 tables so WebPOS receives a timeout even if it is increased in Mobile Services window.
Steps To ReproduceTo reproduce it:
Assortment: 300k records
Characteristics: 6 records
Product Characteristics Value: 3M Records
Proposed SolutionSee diff attached
It will be needed to add a trigger to update "Updated" column from m_product once a Product Characteristic Value changed
Additional Information
TagsPerformance
Relationships
related to defect 0043587 closed ranjith_qualiantech_com Master data load pagination with offset needs too much memory 
Attached Filespatch 43543_Complete.patch (3,548) 2020-04-04 07:59
https://issues.openbravo.com/file_download.php?file_id=14269&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-03-23 12:24guillermogilNew Issue
2020-03-23 12:24guillermogilAssigned To => Retail
2020-03-23 12:24guillermogilOBNetwork customer => Gold
2020-03-23 12:24guillermogilResolution time => 1586728800
2020-03-23 12:24guillermogilTriggers an Emergency Pack => No
2020-03-23 12:27guillermogilFile Added: 43543.diff
2020-03-23 12:27guillermogilTag Attached: Performance
2020-03-23 12:28guillermogilDescription Updatedbug_revision_view_page.php?rev_id=20583#r20583
2020-03-23 14:05rqueraltaAssigned ToRetail => rqueralta
2020-03-23 14:05rqueraltaStatusnew => scheduled
2020-04-02 10:10guilleaerAssigned Torqueralta => Retail
2020-04-02 10:44guilleaerAssigned ToRetail => guilleaer
2020-04-02 10:45guilleaerAssigned Toguilleaer => prakashmurugesan88
2020-04-04 07:59prakashmurugesan88File Added: 43543_Complete.patch
2020-04-06 08:59guilleaerFile Deleted: 43543.diff
2020-04-08 07:34hgbotCheckin
2020-04-08 07:34hgbotNote Added: 0119079
2020-04-08 07:34hgbotStatusscheduled => resolved
2020-04-08 07:34hgbotResolutionopen => fixed
2020-04-08 07:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9ba9e518f396c10e4cde20d5a093600da14c88b5 [^]
2020-04-08 08:35guillermogilRelationship addedrelated to 0043587
2020-04-08 18:10hgbotCheckin
2020-04-08 18:10hgbotNote Added: 0119107
2020-04-09 13:29prakashmurugesan88Statusresolved => new
2020-04-09 13:29prakashmurugesan88Resolutionfixed => open
2020-04-09 13:29prakashmurugesan88Statusnew => scheduled
2020-04-15 07:46prakashmurugesan88Note Added: 0119167
2020-04-15 07:51prakashmurugesan88Statusscheduled => resolved
2020-04-15 07:51prakashmurugesan88Resolutionopen => fixed
2020-04-16 19:00marvintmReview Assigned To => marvintm
2020-04-16 19:00marvintmStatusresolved => closed
2020-04-16 19:00marvintmFixed in Version => RR20Q3

Notes
(0119079)
hgbot   
2020-04-08 07:34   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9ba9e518f396c10e4cde20d5a093600da14c88b5
Author: Prakash M <prakash <at> qualiantech.com>
Date: Wed Apr 08 10:51:56 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9ba9e518f396c10e4cde20d5a093600da14c88b5 [^]

Fixed BUG-43543: Fixes ProductCharacteristicValue does not finish on incremental

---
M src/org/openbravo/retail/posterminal/master/ProductCharacteristicValue.java
A src-db/database/model/triggers/OBPOS_PRODUCT_CH_VALUE_TRG.xml
---
(0119107)
hgbot   
2020-04-08 18:10   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f10f950495c8cf79c2a0b8b593d594b3518ccaa9
Author: Prakash M <prakash <at> qualiantech.com>
Date: Wed Apr 08 21:39:12 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f10f950495c8cf79c2a0b8b593d594b3518ccaa9 [^]

Related BUG-43543: Updated license of trigger OBPOS_PRODUCT_CH_VALUE_TRG

---
M src-db/database/model/triggers/OBPOS_PRODUCT_CH_VALUE_TRG.xml
---
(0119167)
prakashmurugesan88   
2020-04-15 07:46   
Following criteria are removed,

[Price List] - Price List will not affect Product Characteristics Value data.

[Product Characteristics Value] - Handled in product criteria using trigger(updates product updated date when Product Characteristics Value is changed) . So it is ok to remove this criteria.

[Characteristics, Characteristics Value] - It is ok remove these criteria. As per discussion with Antonio, if we disable characteristics or characteristic values, they won't be immediately reflected in the WebPOS products. However, I don't think this is a big concern, because anyway the user will no longer see those filters as the characteristics and characteristic values models will be updated. And when they are enabled, the user will anyway need to specify values first for those characteristics before they do anything, and update the main filter column, so I don't think it would be a problem either.