Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0043353
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2020-02-26 22:122020-03-16 09:19
ReporterAugustoMauchView Statuspublic 
Assigned Torqueralta 
PrioritynormalResolutionfixedFixed in VersionRR20Q2
StatusclosedFix in branchFixed in SCM revisiona8a57d36921a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tojorge-garcia
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043353: Promotion name is being shown in the webpos instead of the printed name

DescriptionDiscounts and promotions have both names and printed names. According to the Printed Name help:

"Name that will be shown to final user in UI and reports to identify current promotion. In case it is empty, name will be used instead. In general, name should be used internally, whereas printed name is intended to be read by user."

But now, if there is both a name and a printed name defined for a discount, the name is printed instead of the printed name.
Steps To ReproduceIn the backend:
- Login
- Open the Discounts and Promotions Window
- Select the discount named GPS_10_per
- Add a printed name: GPS promotion

In the webpos:
- Login
- Add the GPS handheld product to the ticket.
- Check that the name shown is GPS_10_per, and not GPS promotion
TagsNOR
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0043667 closedranjith_qualiantech_com Receipt Discounts popup should also use the Printed Name if any 

-  Notes
(0118309)
hgbot (developer)
2020-03-04 01:17

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3b8c53ff1c57b5aa692d5828fbe6ec633a4dff5c
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Mar 03 08:43:36 2020 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3b8c53ff1c57b5aa692d5828fbe6ec633a4dff5c [^]

Fixed BUG-43353: Promotion name is being shown in the webpos instead of the
printed name

- Giving priority to the discount print name

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0118554)
jorge-garcia (reporter)
2020-03-12 16:56

The solution is working for the old discount engine, but not for the new discount engine
(0118594)
hgbot (developer)
2020-03-13 14:15

Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: a8a57d36921a0ce4a28f7c56c3898f544b3e6aed
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Thu Mar 12 17:45:31 2020 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/a8a57d36921a0ce4a28f7c56c3898f544b3e6aed [^]

Fixed BUG-43353: Promotion name is being shown in the webpos instead of the
printed name

- Giving priority to the discount print name in new discount engine

---
M web/org.openbravo.retail.discounts/js/discountsengine/common/discount-rules.js
---
(0118613)
jorge-garcia (reporter)
2020-03-16 09:19

Code reviewed and tested

- Issue History
Date Modified Username Field Change
2020-02-26 22:12 AugustoMauch New Issue
2020-02-26 22:12 AugustoMauch Assigned To => Retail
2020-02-26 22:12 AugustoMauch Triggers an Emergency Pack => No
2020-02-27 23:24 rafaroda Tag Attached: NOR
2020-02-27 23:25 rafaroda Issue Monitored: rafaroda
2020-02-28 10:44 AugustoMauch Resolution time => 1584054000
2020-03-02 19:50 rqueralta Assigned To Retail => rqueralta
2020-03-02 19:50 rqueralta Status new => scheduled
2020-03-04 01:17 hgbot Checkin
2020-03-04 01:17 hgbot Note Added: 0118309
2020-03-04 01:17 hgbot Status scheduled => resolved
2020-03-04 01:17 hgbot Resolution open => fixed
2020-03-04 01:17 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3b8c53ff1c57b5aa692d5828fbe6ec633a4dff5c [^]
2020-03-12 16:28 jorge-garcia Review Assigned To => jorge-garcia
2020-03-12 16:56 jorge-garcia Note Added: 0118554
2020-03-12 16:56 jorge-garcia Status resolved => new
2020-03-12 16:56 jorge-garcia Resolution fixed => open
2020-03-13 14:15 hgbot Checkin
2020-03-13 14:15 hgbot Note Added: 0118594
2020-03-13 14:15 hgbot Status new => resolved
2020-03-13 14:15 hgbot Resolution open => fixed
2020-03-13 14:15 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3b8c53ff1c57b5aa692d5828fbe6ec633a4dff5c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/a8a57d36921a0ce4a28f7c56c3898f544b3e6aed [^]
2020-03-16 09:19 jorge-garcia Note Added: 0118613
2020-03-16 09:19 jorge-garcia Status resolved => closed
2020-03-16 09:19 jorge-garcia Fixed in Version => RR20Q2
2020-04-06 07:24 rafaroda Relationship added related to 0043667


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker