Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043353Retail ModulesWeb POSpublic2020-02-26 22:122020-03-16 09:19
ReporterAugustoMauch 
Assigned Torqueralta 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q2 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043353: Promotion name is being shown in the webpos instead of the printed name
DescriptionDiscounts and promotions have both names and printed names. According to the Printed Name help:

"Name that will be shown to final user in UI and reports to identify current promotion. In case it is empty, name will be used instead. In general, name should be used internally, whereas printed name is intended to be read by user."

But now, if there is both a name and a printed name defined for a discount, the name is printed instead of the printed name.
Steps To ReproduceIn the backend:
- Login
- Open the Discounts and Promotions Window
- Select the discount named GPS_10_per
- Add a printed name: GPS promotion

In the webpos:
- Login
- Add the GPS handheld product to the ticket.
- Check that the name shown is GPS_10_per, and not GPS promotion
Proposed Solution
Additional Information
TagsNOR
Relationships
related to defect 0043667 closed ranjith_qualiantech_com Receipt Discounts popup should also use the Printed Name if any 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-02-26 22:12AugustoMauchNew Issue
2020-02-26 22:12AugustoMauchAssigned To => Retail
2020-02-26 22:12AugustoMauchTriggers an Emergency Pack => No
2020-02-27 23:24rafarodaTag Attached: NOR
2020-02-27 23:25rafarodaIssue Monitored: rafaroda
2020-02-28 10:44AugustoMauchResolution time => 1584054000
2020-03-02 19:50rqueraltaAssigned ToRetail => rqueralta
2020-03-02 19:50rqueraltaStatusnew => scheduled
2020-03-04 01:17hgbotCheckin
2020-03-04 01:17hgbotNote Added: 0118309
2020-03-04 01:17hgbotStatusscheduled => resolved
2020-03-04 01:17hgbotResolutionopen => fixed
2020-03-04 01:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3b8c53ff1c57b5aa692d5828fbe6ec633a4dff5c [^]
2020-03-12 16:28jorge-garciaReview Assigned To => jorge-garcia
2020-03-12 16:56jorge-garciaNote Added: 0118554
2020-03-12 16:56jorge-garciaStatusresolved => new
2020-03-12 16:56jorge-garciaResolutionfixed => open
2020-03-13 14:15hgbotCheckin
2020-03-13 14:15hgbotNote Added: 0118594
2020-03-13 14:15hgbotStatusnew => resolved
2020-03-13 14:15hgbotResolutionopen => fixed
2020-03-13 14:15hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3b8c53ff1c57b5aa692d5828fbe6ec633a4dff5c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/a8a57d36921a0ce4a28f7c56c3898f544b3e6aed [^]
2020-03-16 09:19jorge-garciaNote Added: 0118613
2020-03-16 09:19jorge-garciaStatusresolved => closed
2020-03-16 09:19jorge-garciaFixed in Version => RR20Q2
2020-04-06 07:24rafarodaRelationship addedrelated to 0043667

Notes
(0118309)
hgbot   
2020-03-04 01:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3b8c53ff1c57b5aa692d5828fbe6ec633a4dff5c
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Mar 03 08:43:36 2020 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3b8c53ff1c57b5aa692d5828fbe6ec633a4dff5c [^]

Fixed BUG-43353: Promotion name is being shown in the webpos instead of the
printed name

- Giving priority to the discount print name

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0118554)
jorge-garcia   
2020-03-12 16:56   
The solution is working for the old discount engine, but not for the new discount engine
(0118594)
hgbot   
2020-03-13 14:15   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: a8a57d36921a0ce4a28f7c56c3898f544b3e6aed
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Thu Mar 12 17:45:31 2020 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/a8a57d36921a0ce4a28f7c56c3898f544b3e6aed [^]

Fixed BUG-43353: Promotion name is being shown in the webpos instead of the
printed name

- Giving priority to the discount print name in new discount engine

---
M web/org.openbravo.retail.discounts/js/discountsengine/common/discount-rules.js
---
(0118613)
jorge-garcia   
2020-03-16 09:19   
Code reviewed and tested