Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0043121
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-02-05 13:572020-02-10 18:11
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision7b81f1be38f5
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocberner
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043121: junit test RuntimeModelTest.testIdentifiers is not given useful output (hiding details)

DescriptionThat test checking that all tables have some columns set as column identifier and fails if any tables are missing those.

However the list of specific tables is only shown as log.debug instead of the test output making it impossible to act on easily when seeing the test-failure.

Steps To ReproduceRun that test is an environment where any table does not have any column identifer set
Proposed SolutionChange test to report the non-compliant tables in junit error output instead of log.debug.

IndexedTest.testSubTabs can be used as example.
TagsNo tags attached.
Attached Filesdiff file icon 43121.diff [^] (1,563 bytes) 2020-02-05 14:55 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 00431703.0PR20Q1 closedshuehner junit test RuntimeModelTest.testIdentifiers is not given useful output (hiding details) 
depends on backport 00431713.0PR19Q4.2 closedshuehner junit test RuntimeModelTest.testIdentifiers is not given useful output (hiding details) 
depends on backport 00431723.0PR19Q3.4 closedshuehner junit test RuntimeModelTest.testIdentifiers is not given useful output (hiding details) 

-  Notes
(0117544)
hgbot (developer)
2020-02-07 10:00

Repository: erp/devel/pi
Changeset: 7b81f1be38f5985b040a4e9ef3b7058a62366763
Author: Stefan Huehner <stefan.huehner <at> openbravo.com>
Date: Fri Feb 07 09:36:04 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7b81f1be38f5985b040a4e9ef3b7058a62366763 [^]

Fixes ISSUE-43121: Add useful information to RuntimeModelTest.testIdentifiers

---
M src-test/src/org/openbravo/test/model/RuntimeModelTest.java
---
(0117545)
hgbot (developer)
2020-02-07 10:00

Repository: erp/devel/pi
Changeset: 91e9deedb476c74aedb4303a1a3866b98421b0e7
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Fri Feb 07 09:47:25 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/91e9deedb476c74aedb4303a1a3866b98421b0e7 [^]

Related to ISSUE-43121: Apply code review recommendations

---
M src-test/src/org/openbravo/test/model/RuntimeModelTest.java
---
(0117547)
cberner (developer)
2020-02-07 10:21
edited on: 2020-02-07 13:00

A merge request has also been created to track this issue: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/41 [^]

(0117612)
caristu (developer)
2020-02-10 18:09

Reopened for creating backports

- Issue History
Date Modified Username Field Change
2020-02-05 13:57 shuehner New Issue
2020-02-05 13:57 shuehner Assigned To => shuehner
2020-02-05 13:57 shuehner Modules => Core
2020-02-05 13:57 shuehner Triggers an Emergency Pack => No
2020-02-05 14:55 shuehner File Added: 43121.diff
2020-02-07 10:00 hgbot Checkin
2020-02-07 10:00 hgbot Note Added: 0117544
2020-02-07 10:00 hgbot Status new => resolved
2020-02-07 10:00 hgbot Resolution open => fixed
2020-02-07 10:00 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7b81f1be38f5985b040a4e9ef3b7058a62366763 [^]
2020-02-07 10:00 hgbot Checkin
2020-02-07 10:00 hgbot Note Added: 0117545
2020-02-07 10:21 cberner Review Assigned To => caristu
2020-02-07 10:21 cberner Note Added: 0117547
2020-02-07 10:21 cberner Status resolved => closed
2020-02-07 12:43 cberner Review Assigned To caristu => cberner
2020-02-07 13:00 cberner Note Edited: 0117547 View Revisions
2020-02-10 18:09 caristu Note Added: 0117612
2020-02-10 18:09 caristu Status closed => new
2020-02-10 18:09 caristu Resolution fixed => open
2020-02-10 18:09 caristu Status new => scheduled
2020-02-10 18:11 caristu Status scheduled => resolved
2020-02-10 18:11 caristu Resolution open => fixed
2020-02-10 18:11 caristu Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker