Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043121Openbravo ERPA. Platformpublic2020-02-05 13:572020-02-10 18:11
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tocberner
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0043121: junit test RuntimeModelTest.testIdentifiers is not given useful output (hiding details)
DescriptionThat test checking that all tables have some columns set as column identifier and fails if any tables are missing those.

However the list of specific tables is only shown as log.debug instead of the test output making it impossible to act on easily when seeing the test-failure.

Steps To ReproduceRun that test is an environment where any table does not have any column identifer set
Proposed SolutionChange test to report the non-compliant tables in junit error output instead of log.debug.

IndexedTest.testSubTabs can be used as example.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00431703.0PR20Q1 closed shuehner junit test RuntimeModelTest.testIdentifiers is not given useful output (hiding details) 
depends on backport 00431713.0PR19Q4.2 closed shuehner junit test RuntimeModelTest.testIdentifiers is not given useful output (hiding details) 
depends on backport 00431723.0PR19Q3.4 closed shuehner junit test RuntimeModelTest.testIdentifiers is not given useful output (hiding details) 
Attached Filesdiff 43121.diff (1,563) 2020-02-05 14:55
https://issues.openbravo.com/file_download.php?file_id=13972&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-02-05 13:57shuehnerNew Issue
2020-02-05 13:57shuehnerAssigned To => shuehner
2020-02-05 13:57shuehnerOBNetwork customer => No
2020-02-05 13:57shuehnerModules => Core
2020-02-05 13:57shuehnerTriggers an Emergency Pack => No
2020-02-05 14:55shuehnerFile Added: 43121.diff
2020-02-07 10:00hgbotCheckin
2020-02-07 10:00hgbotNote Added: 0117544
2020-02-07 10:00hgbotStatusnew => resolved
2020-02-07 10:00hgbotResolutionopen => fixed
2020-02-07 10:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7b81f1be38f5985b040a4e9ef3b7058a62366763 [^]
2020-02-07 10:00hgbotCheckin
2020-02-07 10:00hgbotNote Added: 0117545
2020-02-07 10:21cbernerReview Assigned To => caristu
2020-02-07 10:21cbernerNote Added: 0117547
2020-02-07 10:21cbernerStatusresolved => closed
2020-02-07 12:43cbernerReview Assigned Tocaristu => cberner
2020-02-07 13:00cbernerNote Edited: 0117547bug_revision_view_page.php?bugnote_id=0117547#r20313
2020-02-10 18:09caristuNote Added: 0117612
2020-02-10 18:09caristuStatusclosed => new
2020-02-10 18:09caristuResolutionfixed => open
2020-02-10 18:09caristuStatusnew => scheduled
2020-02-10 18:11caristuStatusscheduled => resolved
2020-02-10 18:11caristuResolutionopen => fixed
2020-02-10 18:11caristuStatusresolved => closed

Notes
(0117544)
hgbot   
2020-02-07 10:00   
Repository: erp/devel/pi
Changeset: 7b81f1be38f5985b040a4e9ef3b7058a62366763
Author: Stefan Huehner <stefan.huehner <at> openbravo.com>
Date: Fri Feb 07 09:36:04 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7b81f1be38f5985b040a4e9ef3b7058a62366763 [^]

Fixes ISSUE-43121: Add useful information to RuntimeModelTest.testIdentifiers

---
M src-test/src/org/openbravo/test/model/RuntimeModelTest.java
---
(0117545)
hgbot   
2020-02-07 10:00   
Repository: erp/devel/pi
Changeset: 91e9deedb476c74aedb4303a1a3866b98421b0e7
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Fri Feb 07 09:47:25 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/91e9deedb476c74aedb4303a1a3866b98421b0e7 [^]

Related to ISSUE-43121: Apply code review recommendations

---
M src-test/src/org/openbravo/test/model/RuntimeModelTest.java
---
(0117547)
cberner   
2020-02-07 10:21   
(edited on: 2020-02-07 13:00)
A merge request has also been created to track this issue: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/41 [^]
(0117612)
caristu   
2020-02-10 18:09   
Reopened for creating backports