Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0042978
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2020-01-23 14:012020-04-26 16:56
ReporterkchoperenaView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision762e97a2568a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042978: If a customer has more than 2 addresses both for invoicing and shipping, in the receipt header the address is showed splited

DescriptionIf we have a customer with more than one direction, all directions for shipping and invoicing and we assign it to the ticket, the receipt header is showing the address splitted.
Steps To Reproduce1.- Log into the WebPOS
2.- Create a customer
3.- Create two addresses for this customer with the invoicing and shipping flags checked
4.- Assign an address to the receipt

EXPECTED RESULT:
The address is shown as if there are two different. See attached screenshot
TagsNo tags attached.
Attached Filespng file icon addressSplitted.png [^] (65,842 bytes) 2020-01-23 14:01

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0043384 closedranjith_qualiantech_com Invoice and Shipping Icon is not displayed in Manage Address Selector 

-  Notes
(0117312)
hgbot (developer)
2020-01-29 07:03

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b22ebbbfed204e998bbadba17bd0218ec748cf7d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jan 29 11:33:10 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b22ebbbfed204e998bbadba17bd0218ec748cf7d [^]

Fixed issue 42978 : Invoice/Shipping address should not be displayed if both are same in Order Header

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
---
(0118148)
kchoperena (viewer)
2020-02-27 11:00

 With the last change is impossible to search an address if it is only shipping address. Example:
In the receipt header only we have an address for both directions. The customer has the next directions :
1.- Address 1 for ship & inv
2.- Address 2 for ship
3.- Address 3 for inv
Search of the addresses only returns two results. It is impossible find the address 2 for ship.
Also, in the search popup is impossible to know which addresses are for ship or for inv, because the icons are not present.
(0118202)
guilleaer (viewer)
2020-02-28 12:26
edited on: 2020-02-28 12:27

 After discuss
Current fix is correct, but creates a new problem raised above by Kepa
To fix raised problem.
When invoice address button is working as a group (it is joining ship and invoice address in just one button) the selector opened when button is pressed should allow to select Invoice Address, Shiping Address and "Mix address".
An icon should be added to the results to help user to decide what is selecting.
The title of this selector should be adapted.

Related to the selector for shipping address, it also should allow to select "Mix address". If one "mix" is selected, then UI will remove shipping address button and will group in just one button (thanks to the fix already done)
(0118217)
hgbot (developer)
2020-03-02 03:53

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1522ce6d5314732338ab31e342c597e421439df0
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Mar 02 08:23:38 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1522ce6d5314732338ab31e342c597e421439df0 [^]

Fixed ISSUE-42978 : Show All address in Selector if Invoice and Shipping address are same

* If Customer Invoice and Shipping address are same, Only one button will be shown
  In this case, in address Selector, all address should be displayed with
  respective icons

---
M web/org.openbravo.retail.posterminal/css/obpos-main.css
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
---
(0118218)
hgbot (developer)
2020-03-02 03:54

 Repository: tools/automation/pi-mobile
Changeset: 6605e849cf48d94dbb06b58e48fc0b5a688fbe67
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Mar 02 08:23:50 2020 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6605e849cf48d94dbb06b58e48fc0b5a688fbe67 [^]

Verifies ISSUE-42978 : Added Test 'I42978_VerifyCustomerAddress'

---
M src-test/org/openbravo/test/mobile/core/utils/AllowedErrorsHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/customercreation/I42978_VerifyCustomerAddress.java
---
(0119157)
kchoperena (viewer)
2020-04-14 15:20

 When the customer has more than one address, the first time the address selector is not showing all the addresses that the customer contains.

Video: https://drive.google.com/file/d/1Gt4Zb_iVCOLCfqAC-eeNVNwqCK_O_7d7/view [^]
(0119200)
hgbot (developer)
2020-04-16 06:57

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 65b6dca500d47db7b70a8bc679411d3d9a50e78c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Apr 16 10:26:43 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/65b6dca500d47db7b70a8bc679411d3d9a50e78c [^]

Fixed issue 42978 : All address should be displayed when opening the Invoice/Shipping Address Popup

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
---
(0119219)
migueldejuana (viewer)
2020-04-16 16:15

 Replace:

 if (bp.get(me.locId) === bp.get(OB.UI.BPLocation.prototype.locId)) {

with:

if (bp.get("shipLocId") === bp.get("locId")) {
(0119222)
hgbot (developer)
2020-04-16 16:41

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 762e97a2568afb3d7e916d6aabb555f30544efe3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Apr 16 20:11:25 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/762e97a2568afb3d7e916d6aabb555f30544efe3 [^]

Fixed issue-42978 : Refactored Location attributes with Id

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
---
(0119225)
migueldejuana (viewer)
2020-04-17 07:53

 Tested and reviewed
(0119405)
hgbot (developer)
2020-04-26 16:56

 Repository: tools/automation/pi-mobile
Changeset: b5c99949fe873b250b6678e6ec44e4a57cf37c19
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sun Apr 26 20:25:56 2020 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b5c99949fe873b250b6678e6ec44e4a57cf37c19 [^]

Verifies issue-42978 : Modified Automated Test I42978_VerifyCustomerAddress

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/customercreation/I42978_VerifyCustomerAddress.java
---

- Issue History
Date Modified Username Field Change
2020-01-23 14:01 kchoperena New Issue
2020-01-23 14:01 kchoperena Assigned To => Retail
2020-01-23 14:01 kchoperena File Added: addressSplitted.png
2020-01-23 14:01 kchoperena OBNetwork customer => Gold
2020-01-23 14:01 kchoperena Resolution time => 1580943600
2020-01-23 14:01 kchoperena Triggers an Emergency Pack => No
2020-01-23 15:14 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2020-01-27 15:17 ranjith_qualiantech_com Status new => scheduled
2020-01-29 07:03 hgbot Checkin
2020-01-29 07:03 hgbot Note Added: 0117312
2020-01-29 07:03 hgbot Status scheduled => resolved
2020-01-29 07:03 hgbot Resolution open => fixed
2020-01-29 07:03 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b22ebbbfed204e998bbadba17bd0218ec748cf7d [^]
2020-01-31 11:58 guilleaer Review Assigned To => guilleaer
2020-01-31 11:58 guilleaer Status resolved => closed
2020-01-31 11:58 guilleaer Fixed in Version => RR20Q2
2020-02-27 11:00 kchoperena Note Added: 0118148
2020-02-27 11:00 kchoperena Status closed => new
2020-02-27 11:00 kchoperena Resolution fixed => open
2020-02-27 11:00 kchoperena Fixed in Version RR20Q2 =>
2020-02-27 11:41 guilleaer Status new => scheduled
2020-02-28 12:26 guilleaer Note Added: 0118202
2020-02-28 12:27 guilleaer Note Edited: 0118202 View Revisions
2020-03-02 03:53 hgbot Checkin
2020-03-02 03:53 hgbot Note Added: 0118217
2020-03-02 03:53 hgbot Status scheduled => resolved
2020-03-02 03:53 hgbot Resolution open => fixed
2020-03-02 03:53 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b22ebbbfed204e998bbadba17bd0218ec748cf7d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1522ce6d5314732338ab31e342c597e421439df0 [^]
2020-03-02 03:54 hgbot Checkin
2020-03-02 03:54 hgbot Note Added: 0118218
2020-03-02 11:08 guilleaer Status resolved => closed
2020-03-02 11:08 guilleaer Fixed in Version => RR20Q2
2020-03-02 14:24 guilleaer Relationship added related to 0043384
2020-04-14 15:20 kchoperena Note Added: 0119157
2020-04-14 15:20 kchoperena Status closed => new
2020-04-14 15:20 kchoperena Resolution fixed => open
2020-04-14 15:20 kchoperena Fixed in Version RR20Q2 =>
2020-04-15 18:26 ranjith_qualiantech_com Status new => scheduled
2020-04-16 06:57 hgbot Checkin
2020-04-16 06:57 hgbot Note Added: 0119200
2020-04-16 06:57 hgbot Status scheduled => resolved
2020-04-16 06:57 hgbot Resolution open => fixed
2020-04-16 06:57 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1522ce6d5314732338ab31e342c597e421439df0 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/65b6dca500d47db7b70a8bc679411d3d9a50e78c [^]
2020-04-16 16:15 migueldejuana Note Added: 0119219
2020-04-16 16:15 migueldejuana Status resolved => new
2020-04-16 16:15 migueldejuana Resolution fixed => open
2020-04-16 16:38 ranjith_qualiantech_com Status new => scheduled
2020-04-16 16:41 hgbot Checkin
2020-04-16 16:41 hgbot Note Added: 0119222
2020-04-16 16:41 hgbot Status scheduled => resolved
2020-04-16 16:41 hgbot Resolution open => fixed
2020-04-16 16:41 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/65b6dca500d47db7b70a8bc679411d3d9a50e78c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/762e97a2568afb3d7e916d6aabb555f30544efe3 [^]
2020-04-17 07:53 migueldejuana Review Assigned To guilleaer => migueldejuana
2020-04-17 07:53 migueldejuana Note Added: 0119225
2020-04-17 07:53 migueldejuana Status resolved => closed
2020-04-26 16:56 hgbot Checkin
2020-04-26 16:56 hgbot Note Added: 0119405

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker