Openbravo Issue Tracking System - Retail Modules
View Issue Details
0042978Retail ModulesWeb POSpublic2020-01-23 14:012020-04-26 16:56
kchoperena 
ranjith_qualiantech_com 
normalmajoralways
closedfixed 
5
 
 
migueldejuana
No
0042978: If a customer has more than 2 addresses both for invoicing and shipping, in the receipt header the address is showed splited
If we have a customer with more than one direction, all directions for shipping and invoicing and we assign it to the ticket, the receipt header is showing the address splitted.
1.- Log into the WebPOS
2.- Create a customer
3.- Create two addresses for this customer with the invoicing and shipping flags checked
4.- Assign an address to the receipt

EXPECTED RESULT:
The address is shown as if there are two different. See attached screenshot
No tags attached.
related to defect 0043384 closed ranjith_qualiantech_com Invoice and Shipping Icon is not displayed in Manage Address Selector 
png addressSplitted.png (65,842) 2020-01-23 14:01
https://issues.openbravo.com/file_download.php?file_id=13899&type=bug
png
Issue History
2020-01-23 14:01kchoperenaNew Issue
2020-01-23 14:01kchoperenaAssigned To => Retail
2020-01-23 14:01kchoperenaFile Added: addressSplitted.png
2020-01-23 14:01kchoperenaResolution time => 1580943600
2020-01-23 14:01kchoperenaTriggers an Emergency Pack => No
2020-01-23 15:14ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-01-27 15:17ranjith_qualiantech_comStatusnew => scheduled
2020-01-29 07:03hgbotCheckin
2020-01-29 07:03hgbotNote Added: 0117312
2020-01-29 07:03hgbotStatusscheduled => resolved
2020-01-29 07:03hgbotResolutionopen => fixed
2020-01-29 07:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b22ebbbfed204e998bbadba17bd0218ec748cf7d [^]
2020-01-31 11:58guilleaerReview Assigned To => guilleaer
2020-01-31 11:58guilleaerStatusresolved => closed
2020-01-31 11:58guilleaerFixed in Version => RR20Q2
2020-02-27 11:00kchoperenaNote Added: 0118148
2020-02-27 11:00kchoperenaStatusclosed => new
2020-02-27 11:00kchoperenaResolutionfixed => open
2020-02-27 11:00kchoperenaFixed in VersionRR20Q2 =>
2020-02-27 11:41guilleaerStatusnew => scheduled
2020-02-28 12:26guilleaerNote Added: 0118202
2020-02-28 12:27guilleaerNote Edited: 0118202bug_revision_view_page.php?bugnote_id=0118202#r20474
2020-03-02 03:53hgbotCheckin
2020-03-02 03:53hgbotNote Added: 0118217
2020-03-02 03:53hgbotStatusscheduled => resolved
2020-03-02 03:53hgbotResolutionopen => fixed
2020-03-02 03:53hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b22ebbbfed204e998bbadba17bd0218ec748cf7d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1522ce6d5314732338ab31e342c597e421439df0 [^]
2020-03-02 03:54hgbotCheckin
2020-03-02 03:54hgbotNote Added: 0118218
2020-03-02 11:08guilleaerStatusresolved => closed
2020-03-02 11:08guilleaerFixed in Version => RR20Q2
2020-03-02 14:24guilleaerRelationship addedrelated to 0043384
2020-04-14 15:20kchoperenaNote Added: 0119157
2020-04-14 15:20kchoperenaStatusclosed => new
2020-04-14 15:20kchoperenaResolutionfixed => open
2020-04-14 15:20kchoperenaFixed in VersionRR20Q2 =>
2020-04-15 18:26ranjith_qualiantech_comStatusnew => scheduled
2020-04-16 06:57hgbotCheckin
2020-04-16 06:57hgbotNote Added: 0119200
2020-04-16 06:57hgbotStatusscheduled => resolved
2020-04-16 06:57hgbotResolutionopen => fixed
2020-04-16 06:57hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1522ce6d5314732338ab31e342c597e421439df0 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/65b6dca500d47db7b70a8bc679411d3d9a50e78c [^]
2020-04-16 16:15migueldejuanaNote Added: 0119219
2020-04-16 16:15migueldejuanaStatusresolved => new
2020-04-16 16:15migueldejuanaResolutionfixed => open
2020-04-16 16:38ranjith_qualiantech_comStatusnew => scheduled
2020-04-16 16:41hgbotCheckin
2020-04-16 16:41hgbotNote Added: 0119222
2020-04-16 16:41hgbotStatusscheduled => resolved
2020-04-16 16:41hgbotResolutionopen => fixed
2020-04-16 16:41hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/65b6dca500d47db7b70a8bc679411d3d9a50e78c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/762e97a2568afb3d7e916d6aabb555f30544efe3 [^]
2020-04-17 07:53migueldejuanaReview Assigned Toguilleaer => migueldejuana
2020-04-17 07:53migueldejuanaNote Added: 0119225
2020-04-17 07:53migueldejuanaStatusresolved => closed
2020-04-26 16:56hgbotCheckin
2020-04-26 16:56hgbotNote Added: 0119405

Notes
(0117312)
hgbot   
2020-01-29 07:03   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b22ebbbfed204e998bbadba17bd0218ec748cf7d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jan 29 11:33:10 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b22ebbbfed204e998bbadba17bd0218ec748cf7d [^]

Fixed issue 42978 : Invoice/Shipping address should not be displayed if both are same in Order Header

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
---
(0118148)
kchoperena   
2020-02-27 11:00   
With the last change is impossible to search an address if it is only shipping address. Example:
In the receipt header only we have an address for both directions. The customer has the next directions :
1.- Address 1 for ship & inv
2.- Address 2 for ship
3.- Address 3 for inv
Search of the addresses only returns two results. It is impossible find the address 2 for ship.
Also, in the search popup is impossible to know which addresses are for ship or for inv, because the icons are not present.
(0118202)
guilleaer   
2020-02-28 12:26   
(edited on: 2020-02-28 12:27)
After discuss
Current fix is correct, but creates a new problem raised above by Kepa
To fix raised problem.
When invoice address button is working as a group (it is joining ship and invoice address in just one button) the selector opened when button is pressed should allow to select Invoice Address, Shiping Address and "Mix address".
An icon should be added to the results to help user to decide what is selecting.
The title of this selector should be adapted.

Related to the selector for shipping address, it also should allow to select "Mix address". If one "mix" is selected, then UI will remove shipping address button and will group in just one button (thanks to the fix already done)

(0118217)
hgbot   
2020-03-02 03:53   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1522ce6d5314732338ab31e342c597e421439df0
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Mar 02 08:23:38 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1522ce6d5314732338ab31e342c597e421439df0 [^]

Fixed ISSUE-42978 : Show All address in Selector if Invoice and Shipping address are same

* If Customer Invoice and Shipping address are same, Only one button will be shown
  In this case, in address Selector, all address should be displayed with
  respective icons

---
M web/org.openbravo.retail.posterminal/css/obpos-main.css
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
---
(0118218)
hgbot   
2020-03-02 03:54   
Repository: tools/automation/pi-mobile
Changeset: 6605e849cf48d94dbb06b58e48fc0b5a688fbe67
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Mar 02 08:23:50 2020 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6605e849cf48d94dbb06b58e48fc0b5a688fbe67 [^]

Verifies ISSUE-42978 : Added Test 'I42978_VerifyCustomerAddress'

---
M src-test/org/openbravo/test/mobile/core/utils/AllowedErrorsHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/customercreation/I42978_VerifyCustomerAddress.java
---
(0119157)
kchoperena   
2020-04-14 15:20   
When the customer has more than one address, the first time the address selector is not showing all the addresses that the customer contains.

Video: https://drive.google.com/file/d/1Gt4Zb_iVCOLCfqAC-eeNVNwqCK_O_7d7/view [^]
(0119200)
hgbot   
2020-04-16 06:57   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 65b6dca500d47db7b70a8bc679411d3d9a50e78c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Apr 16 10:26:43 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/65b6dca500d47db7b70a8bc679411d3d9a50e78c [^]

Fixed issue 42978 : All address should be displayed when opening the Invoice/Shipping Address Popup

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
---
(0119219)
migueldejuana   
2020-04-16 16:15   
Replace:

 if (bp.get(me.locId) === bp.get(OB.UI.BPLocation.prototype.locId)) {

with:

if (bp.get("shipLocId") === bp.get("locId")) {
(0119222)
hgbot   
2020-04-16 16:41   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 762e97a2568afb3d7e916d6aabb555f30544efe3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Apr 16 20:11:25 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/762e97a2568afb3d7e916d6aabb555f30544efe3 [^]

Fixed issue-42978 : Refactored Location attributes with Id

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
---
(0119225)
migueldejuana   
2020-04-17 07:53   
Tested and reviewed
(0119405)
hgbot   
2020-04-26 16:56   
Repository: tools/automation/pi-mobile
Changeset: b5c99949fe873b250b6678e6ec44e4a57cf37c19
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sun Apr 26 20:25:56 2020 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b5c99949fe873b250b6678e6ec44e4a57cf37c19 [^]

Verifies issue-42978 : Modified Automated Test I42978_VerifyCustomerAddress

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/customercreation/I42978_VerifyCustomerAddress.java
---