Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0042960 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2020-01-22 10:26 | 2020-02-14 13:11 | |||
| Reporter | joniturralde93 | View Status | public | |||||
| Assigned To | joniturralde93 | |||||||
| Priority | urgent | Resolution | open | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 054af401974c | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | Gold | |||||||
| Support ticket | 13655 | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0042960: Doing a lawayay from a receipt with a manually modified price | |||||||
| Description | When you layaway a receipt with a line whose price you have manually modified, if you open it in order to complete it, list price will be the modified price instead of the original product list price (happens to all the rest of the prices such as gross, net etc) | |||||||
| Steps To Reproduce | - Go to web POS and add Adhesive body warmers - Open chrome console and type: OB.MobileApp.model.receipt.attributes.lines.at(0).attributes.priceList - Price is 3.60 - Manually modify that line price (click price and enter 50) - Type the same in the console: OB.MobileApp.model.receipt.attributes.lines.at(0).attributes.priceList - Price is still 3.60 since list price should not change - Menu -> Layaway this receipt - Click total and layaway - Menu -> Open receipt -> Open our lawayay - Type the same in the console: OB.MobileApp.model.receipt.attributes.lines.at(0).attributes.priceList - WRONG-> Price is 50 | |||||||
| Proposed Solution | Original price should prevail | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0117267) hgbot (developer) 2020-01-27 14:45 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 42bcb78821b909c90aeb19a7cfa4568efc156f29 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Sun Jan 26 10:18:21 2020 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/42bcb78821b909c90aeb19a7cfa4568efc156f29 [^] Fixed issue 42960: Doing a lawayay from a receipt with a manually modified price - In layaway orders set the price list as the original price. --- M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
(0117379) guilleaer (viewer) 2020-01-30 19:11 |
Current changes should be backouted A deep analysis about fields grossListPrice and proceList should be done to fix this issue. Theoretically the field grossListPrice which is stored in the backend (orderline) when order/layaway is created should never change in subsequents reloads/updates since this data reflect the listPrice of this item when the orderline was created. |
|
(0117384) hgbot (developer) 2020-01-30 20:33 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 054af401974c3a03cb582a3c5492dde649c3a4a9 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Thu Jan 30 14:31:32 2020 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/054af401974c3a03cb582a3c5492dde649c3a4a9 [^] Fixed issue 42960: Doing a lawayay from a receipt with a manually modified price - Backed out changeset: 42bcb78821b9 because the funtional solution need to be clarified --- M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
(0117484) joniturralde93 (viewer) 2020-02-05 18:11 |
Notes about related issue listPrice loading for returns instead of layaways: - This issue is also related with another problem (return of unknown items custom product). Since unknown items have price 0 in the backend's price list, the listPrice when loading the order for verify return is 0 (instead of the original listPrice stored in the orderline in the database). This leads to POSLog miscalculations. - It's possible that the fix we are thinking for this issue will also fix the unknown item's verify return issue, since the new property (i.e. officialListPrice) will store the original listPrice, which we have checked is correct for the original order. Summary: - The solution of creating a new property to store the original listPrice is ok for us if that value is finally stored in the database as the List Price. - We need to double check that the change fixes both problems (layaways with modified price and return for unknown item) |
|
(0117803) joniturralde93 (viewer) 2020-02-14 13:11 |
Rejected issue. New correct issues related: 43202 and 43226 |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-01-22 10:26 | joniturralde93 | New Issue | |
| 2020-01-22 10:26 | joniturralde93 | Assigned To | => Retail |
| 2020-01-22 10:26 | joniturralde93 | OBNetwork customer | => Gold |
| 2020-01-22 10:26 | joniturralde93 | Support ticket | => 13655 |
| 2020-01-22 10:26 | joniturralde93 | Resolution time | => 1581375600 |
| 2020-01-22 10:26 | joniturralde93 | Triggers an Emergency Pack | => No |
| 2020-01-22 10:31 | joniturralde93 | Steps to Reproduce Updated | View Revisions |
| 2020-01-22 12:58 | rqueralta | Assigned To | Retail => rqueralta |
| 2020-01-22 12:58 | rqueralta | Status | new => scheduled |
| 2020-01-24 11:11 | maite | Issue Monitored: networkb | |
| 2020-01-27 14:45 | hgbot | Checkin | |
| 2020-01-27 14:45 | hgbot | Note Added: 0117267 | |
| 2020-01-27 14:46 | hgbot | Status | scheduled => resolved |
| 2020-01-27 14:46 | hgbot | Resolution | open => fixed |
| 2020-01-27 14:46 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/42bcb78821b909c90aeb19a7cfa4568efc156f29 [^] |
| 2020-01-30 19:11 | guilleaer | Note Added: 0117379 | |
| 2020-01-30 19:11 | guilleaer | Status | resolved => new |
| 2020-01-30 19:11 | guilleaer | Resolution | fixed => open |
| 2020-01-30 20:33 | hgbot | Checkin | |
| 2020-01-30 20:33 | hgbot | Note Added: 0117384 | |
| 2020-01-30 20:33 | hgbot | Status | new => resolved |
| 2020-01-30 20:33 | hgbot | Resolution | open => fixed |
| 2020-01-30 20:33 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/42bcb78821b909c90aeb19a7cfa4568efc156f29 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/054af401974c3a03cb582a3c5492dde649c3a4a9 [^] |
| 2020-01-30 21:04 | guilleaer | Status | resolved => new |
| 2020-01-30 21:04 | guilleaer | Resolution | fixed => open |
| 2020-01-30 21:04 | guilleaer | Status | new => scheduled |
| 2020-02-05 18:11 | joniturralde93 | Note Added: 0117484 | |
| 2020-02-12 14:14 | guilleaer | Assigned To | rqueralta => Retail |
| 2020-02-12 14:14 | guilleaer | Status | scheduled => feedback |
| 2020-02-12 15:45 | guilleaer | Assigned To | Retail => joniturralde93 |
| 2020-02-14 13:11 | joniturralde93 | Status | feedback => scheduled |
| 2020-02-14 13:11 | joniturralde93 | Note Added: 0117803 | |
| 2020-02-14 13:11 | joniturralde93 | Status | scheduled => resolved |
| 2020-02-14 13:11 | joniturralde93 | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |