Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042960Retail ModulesWeb POSpublic2020-01-22 10:262020-02-14 13:11
Reporterjoniturralde93 
Assigned Tojoniturralde93 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerGold
Support ticket13655
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042960: Doing a lawayay from a receipt with a manually modified price
DescriptionWhen you layaway a receipt with a line whose price you have manually modified, if you open it in order to complete it, list price will be the modified price instead of the original product list price (happens to all the rest of the prices such as gross, net etc)
Steps To Reproduce- Go to web POS and add Adhesive body warmers
- Open chrome console and type:
OB.MobileApp.model.receipt.attributes.lines.at(0).attributes.priceList
- Price is 3.60
- Manually modify that line price (click price and enter 50)
- Type the same in the console:
OB.MobileApp.model.receipt.attributes.lines.at(0).attributes.priceList
- Price is still 3.60 since list price should not change
- Menu -> Layaway this receipt
- Click total and layaway
- Menu -> Open receipt -> Open our lawayay
- Type the same in the console:
OB.MobileApp.model.receipt.attributes.lines.at(0).attributes.priceList
- WRONG-> Price is 50
Proposed SolutionOriginal price should prevail
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-22 10:26joniturralde93New Issue
2020-01-22 10:26joniturralde93Assigned To => Retail
2020-01-22 10:26joniturralde93OBNetwork customer => Gold
2020-01-22 10:26joniturralde93Support ticket => 13655
2020-01-22 10:26joniturralde93Resolution time => 1581375600
2020-01-22 10:26joniturralde93Triggers an Emergency Pack => No
2020-01-22 10:31joniturralde93Steps to Reproduce Updatedbug_revision_view_page.php?rev_id=20190#r20190
2020-01-22 12:58rqueraltaAssigned ToRetail => rqueralta
2020-01-22 12:58rqueraltaStatusnew => scheduled
2020-01-24 11:11maiteIssue Monitored: networkb
2020-01-27 14:45hgbotCheckin
2020-01-27 14:45hgbotNote Added: 0117267
2020-01-27 14:46hgbotStatusscheduled => resolved
2020-01-27 14:46hgbotResolutionopen => fixed
2020-01-27 14:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/42bcb78821b909c90aeb19a7cfa4568efc156f29 [^]
2020-01-30 19:11guilleaerNote Added: 0117379
2020-01-30 19:11guilleaerStatusresolved => new
2020-01-30 19:11guilleaerResolutionfixed => open
2020-01-30 20:33hgbotCheckin
2020-01-30 20:33hgbotNote Added: 0117384
2020-01-30 20:33hgbotStatusnew => resolved
2020-01-30 20:33hgbotResolutionopen => fixed
2020-01-30 20:33hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/42bcb78821b909c90aeb19a7cfa4568efc156f29 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/054af401974c3a03cb582a3c5492dde649c3a4a9 [^]
2020-01-30 21:04guilleaerStatusresolved => new
2020-01-30 21:04guilleaerResolutionfixed => open
2020-01-30 21:04guilleaerStatusnew => scheduled
2020-02-05 18:11joniturralde93Note Added: 0117484
2020-02-12 14:14guilleaerAssigned Torqueralta => Retail
2020-02-12 14:14guilleaerStatusscheduled => feedback
2020-02-12 15:45guilleaerAssigned ToRetail => joniturralde93
2020-02-14 13:11joniturralde93Statusfeedback => scheduled
2020-02-14 13:11joniturralde93Note Added: 0117803
2020-02-14 13:11joniturralde93Statusscheduled => resolved
2020-02-14 13:11joniturralde93Statusresolved => closed

Notes
(0117267)
hgbot   
2020-01-27 14:45   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 42bcb78821b909c90aeb19a7cfa4568efc156f29
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Sun Jan 26 10:18:21 2020 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/42bcb78821b909c90aeb19a7cfa4568efc156f29 [^]

Fixed issue 42960: Doing a lawayay from a receipt with a manually modified price

- In layaway orders set the price list as the original price.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0117379)
guilleaer   
2020-01-30 19:11   
Current changes should be backouted

A deep analysis about fields
grossListPrice and proceList
should be done to fix this issue.

Theoretically the field grossListPrice which is stored in the backend (orderline) when order/layaway is created should never change in subsequents reloads/updates since this data reflect the listPrice of this item when the orderline was created.
(0117384)
hgbot   
2020-01-30 20:33   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 054af401974c3a03cb582a3c5492dde649c3a4a9
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Thu Jan 30 14:31:32 2020 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/054af401974c3a03cb582a3c5492dde649c3a4a9 [^]

Fixed issue 42960: Doing a lawayay from a receipt with a manually modified price

- Backed out changeset: 42bcb78821b9 because the funtional solution need to be
clarified

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0117484)
joniturralde93   
2020-02-05 18:11   
Notes about related issue listPrice loading for returns instead of layaways:

- This issue is also related with another problem (return of unknown items custom product). Since unknown items have price 0 in the backend's price list, the listPrice when loading the order for verify return is 0 (instead of the original listPrice stored in the orderline in the database). This leads to POSLog miscalculations.

- It's possible that the fix we are thinking for this issue will also fix the unknown item's verify return issue, since the new property (i.e. officialListPrice) will store the original listPrice, which we have checked is correct for the original order.


Summary:


- The solution of creating a new property to store the original listPrice is ok for us if that value is finally stored in the database as the List Price.

- We need to double check that the change fixes both problems (layaways with modified price and return for unknown item)
(0117803)
joniturralde93   
2020-02-14 13:11   
Rejected issue. New correct issues related:
43202 and 43226