Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0042840
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-01-14 10:512020-01-17 15:03
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision969f04ef4a91
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0042840: Apply new HQL Style in FIN_PaymentMonitorProcess.java

DescriptionFIN_PaymentMonitorProcess.java has one HQL query with:
- the HQL is hard to read because of formatting
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0116845)
inigo_lerga (reporter)
2020-01-14 11:58

 Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Process Request window Admin
      create a new record. Leave every field
      as default except the Process field.
      Select the "Payment Monitor" process in
      that field. Save the new Process Request
      and press the Schedule Process.
      
#In this moment the modified HQL is executed#
(0117035)
hgbot (developer)
2020-01-17 15:02

 Repository: erp/devel/pi
Changeset: 969f04ef4a91434fea5714d7d3d6425c8476993a
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Jan 14 12:01:08 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/969f04ef4a91434fea5714d7d3d6425c8476993a [^]

fixes BUG-42840:Applied new HQL Style

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentMonitorProcess.java
---
(0117036)
hgbot (developer)
2020-01-17 15:02

 Repository: erp/devel/pi
Changeset: 51f18171d730b26cf5df1001fdc3222e9b3c6c96
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Jan 14 12:34:43 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/51f18171d730b26cf5df1001fdc3222e9b3c6c96 [^]

related to ISSUE-42840: Applied Sonarlint suggestions

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentMonitorProcess.java
---
(0117037)
hgbot (developer)
2020-01-17 15:02

 Repository: erp/devel/pi
Changeset: 16059e5842d127a83277d2072c617ca58a7bd4af
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jan 17 15:02:42 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/16059e5842d127a83277d2072c617ca58a7bd4af [^]

Related to ISSUE-42840: Code Review Changes:
* Do not use Boolean.TRUE, keep old comparison as the code
  is more redable

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentMonitorProcess.java
---
(0117038)
dmiguelez (developer)
2020-01-17 15:03

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-01-14 10:51 inigo_lerga New Issue
2020-01-14 10:51 inigo_lerga Assigned To => inigo_lerga
2020-01-14 10:51 inigo_lerga Modules => Core
2020-01-14 10:51 inigo_lerga Triggers an Emergency Pack => No
2020-01-14 10:51 inigo_lerga Status new => scheduled
2020-01-14 10:52 inigo_lerga Relationship added related to 0041287
2020-01-14 11:58 inigo_lerga Note Added: 0116845
2020-01-14 12:38 inigo_lerga Description Updated View Revisions
2020-01-17 15:02 hgbot Checkin
2020-01-17 15:02 hgbot Note Added: 0117035
2020-01-17 15:02 hgbot Status scheduled => resolved
2020-01-17 15:02 hgbot Resolution open => fixed
2020-01-17 15:02 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/969f04ef4a91434fea5714d7d3d6425c8476993a [^]
2020-01-17 15:02 hgbot Checkin
2020-01-17 15:02 hgbot Note Added: 0117036
2020-01-17 15:02 hgbot Checkin
2020-01-17 15:02 hgbot Note Added: 0117037
2020-01-17 15:03 dmiguelez Review Assigned To => dmiguelez
2020-01-17 15:03 dmiguelez Note Added: 0117038
2020-01-17 15:03 dmiguelez Status resolved => closed
2020-01-17 15:03 dmiguelez Fixed in Version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker