Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042840Openbravo ERPA. Platformpublic2020-01-14 10:512020-01-17 15:03
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042840: Apply new HQL Style in FIN_PaymentMonitorProcess.java
DescriptionFIN_PaymentMonitorProcess.java has one HQL query with:
- the HQL is hard to read because of formatting
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-01-14 10:51inigo_lergaNew Issue
2020-01-14 10:51inigo_lergaAssigned To => inigo_lerga
2020-01-14 10:51inigo_lergaModules => Core
2020-01-14 10:51inigo_lergaTriggers an Emergency Pack => No
2020-01-14 10:51inigo_lergaStatusnew => scheduled
2020-01-14 10:52inigo_lergaRelationship addedrelated to 0041287
2020-01-14 11:58inigo_lergaNote Added: 0116845
2020-01-14 12:38inigo_lergaDescription Updatedbug_revision_view_page.php?rev_id=20094#r20094
2020-01-17 15:02hgbotCheckin
2020-01-17 15:02hgbotNote Added: 0117035
2020-01-17 15:02hgbotStatusscheduled => resolved
2020-01-17 15:02hgbotResolutionopen => fixed
2020-01-17 15:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/969f04ef4a91434fea5714d7d3d6425c8476993a [^]
2020-01-17 15:02hgbotCheckin
2020-01-17 15:02hgbotNote Added: 0117036
2020-01-17 15:02hgbotCheckin
2020-01-17 15:02hgbotNote Added: 0117037
2020-01-17 15:03dmiguelezReview Assigned To => dmiguelez
2020-01-17 15:03dmiguelezNote Added: 0117038
2020-01-17 15:03dmiguelezStatusresolved => closed
2020-01-17 15:03dmiguelezFixed in Version => 3.0PR20Q2

Notes
(0116845)
inigo_lerga   
2020-01-14 11:58   
Test Plan Mantis:
As the F&B International Group Admin role:
    - Go to the Process Request window Admin
      create a new record. Leave every field
      as default except the Process field.
      Select the "Payment Monitor" process in
      that field. Save the new Process Request
      and press the Schedule Process.
      
#In this moment the modified HQL is executed#
(0117035)
hgbot   
2020-01-17 15:02   
Repository: erp/devel/pi
Changeset: 969f04ef4a91434fea5714d7d3d6425c8476993a
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Jan 14 12:01:08 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/969f04ef4a91434fea5714d7d3d6425c8476993a [^]

fixes BUG-42840:Applied new HQL Style

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentMonitorProcess.java
---
(0117036)
hgbot   
2020-01-17 15:02   
Repository: erp/devel/pi
Changeset: 51f18171d730b26cf5df1001fdc3222e9b3c6c96
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue Jan 14 12:34:43 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/51f18171d730b26cf5df1001fdc3222e9b3c6c96 [^]

related to ISSUE-42840: Applied Sonarlint suggestions

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentMonitorProcess.java
---
(0117037)
hgbot   
2020-01-17 15:02   
Repository: erp/devel/pi
Changeset: 16059e5842d127a83277d2072c617ca58a7bd4af
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jan 17 15:02:42 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/16059e5842d127a83277d2072c617ca58a7bd4af [^]

Related to ISSUE-42840: Code Review Changes:
* Do not use Boolean.TRUE, keep old comparison as the code
  is more redable

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentMonitorProcess.java
---
(0117038)
dmiguelez   
2020-01-17 15:03   
Code Review + Testing Ok