Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0042116 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | always | 2019-10-24 18:06 | 2019-12-18 14:10 | |||
| Reporter | joniturralde93 | View Status | public | |||||
| Assigned To | alekosmp86 | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | RR20Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 68823754f3ca | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | OBPS | |||||||
| Support ticket | 12422 | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0042116: Validate prepayment percentage limit and pick & carry lines at the same time | |||||||
| Description | There two validations are done separately, making the cashier to correct the first one only to get the second validation error message. | |||||||
| Steps To Reproduce | https://livebuilds.openbravo.com/retail_modules_pgsql_pi/ [^] Organization Vall Boi Store: - Prepayment percentage: 100 - Prepayment percentage limit: 10 Preference: - Web POS Allow prepayments lower than the limit: N Channel - Touchpoint Type VB POS Terminal Type: - Allow prepayments and partial payments: Checked 1. Log into POS (VB-1) with user Vallboi 2. Change customer to Arturo Montoro 3. Add Headlamp ultralight (18.90) 4. Add a cash payment amount 1 5. Click on Done -> Web POS Prepayments lower than the limit (1.89) not allowed 6. Remove payment and add another one for amount 5 7. Done -> The amount paid is lower than the amount of Pick & Carry lines (18.90€). It is not possible to continue. | |||||||
| Proposed Solution | The customer requires both of these validations ('prepayment percentage limit' and Pick & Carry lines amount) to be checked at the same time, showing only the higher amount you must pay in order to complete the ticket (in this case, in point 5, it should show the message from point 7 directly. This way, the cashier saves time and corrects the amount from the beginning Both validations are done in payment.js (POS Terminal), lines 2478 and 2485 | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0116114) hgbot (developer) 2019-12-05 15:38 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 68823754f3cad33dd9154f7afd8e1decfebb1849 Author: Alejandro <alekosmp86 <at> gmail.com> Date: Wed Dec 04 11:43:35 2019 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/68823754f3cad33dd9154f7afd8e1decfebb1849 [^] Fixed issue 42116: Verify prepayment limit and pick&carry lines at the same time When partially paying a ticket, the validations for the prepayment percentage limit and delivery modes should be done simultaneously showing always the lowest amount needed for a successful payment. So when the check for the partial payments' preference fails, we need to still check for the Delivery Modes preference and inform the user whether the payment can be accepted or not, and the lowest allowed quantity. --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
(0116310) marvintm (viewer) 2019-12-13 13:19 |
Fix is not correct. Instead of the current fix, we need to improve the algorithm to take into account pick and carry lines as 100% always, regardless of the prepayment limit defined. |
|
(0116320) hgbot (developer) 2019-12-13 18:55 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 608a510383d8519fea7b4f63548ae047a8eec87d Author: Alejandro <alekosmp86 <at> gmail.com> Date: Fri Dec 13 12:54:57 2019 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/608a510383d8519fea7b4f63548ae047a8eec87d [^] Related to issue 42116: Reverted fix due to the percentage limit calculation must be updated to take into account the Delivery Modes Backed out changeset: 68823754f3ca --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
(0116386) hgbot (developer) 2019-12-17 20:28 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 9589cf41909300f2e822e3c597d7f472816f733f Author: Alejandro <alekosmp86 <at> gmail.com> Date: Tue Dec 17 11:14:08 2019 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9589cf41909300f2e822e3c597d7f472816f733f [^] Related to issue 42116: Take into account the Delivery mode when calculating the prepayment percentage limit. If Delivery Mode is Pick and Carry then the percentage limit is always 100 --- M web/org.openbravo.retail.posterminal/js/model/prepaymentrules.js --- |
|
(0116411) marvintm (viewer) 2019-12-18 14:10 |
The prepayment is now calculated taking into account that Pick and Carry lines need to be paid in full. This means that as long as you are paying the proposed prepayment amount, you will never encounter the Pick and Carry warning again. If the standard algorithm is used, this warning will now only appear if you are trying to do a prepayment which is under the limit that is configured in the system. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-10-24 18:06 | joniturralde93 | New Issue | |
| 2019-10-24 18:06 | joniturralde93 | Assigned To | => Retail |
| 2019-10-24 18:06 | joniturralde93 | OBNetwork customer | => OBPS |
| 2019-10-24 18:06 | joniturralde93 | Support ticket | => 12422 |
| 2019-10-24 18:06 | joniturralde93 | Triggers an Emergency Pack | => No |
| 2019-11-15 13:34 | marvintm | Resolution time | => 1576364400 |
| 2019-11-28 18:46 | marvintm | Assigned To | Retail => alekosmp86 |
| 2019-11-28 18:46 | marvintm | Status | new => scheduled |
| 2019-12-05 15:38 | hgbot | Checkin | |
| 2019-12-05 15:38 | hgbot | Note Added: 0116114 | |
| 2019-12-05 15:38 | hgbot | Status | scheduled => resolved |
| 2019-12-05 15:38 | hgbot | Resolution | open => fixed |
| 2019-12-05 15:38 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/68823754f3cad33dd9154f7afd8e1decfebb1849 [^] |
| 2019-12-13 13:19 | marvintm | Note Added: 0116310 | |
| 2019-12-13 13:19 | marvintm | Status | resolved => new |
| 2019-12-13 13:19 | marvintm | Resolution | fixed => open |
| 2019-12-13 18:55 | hgbot | Checkin | |
| 2019-12-13 18:55 | hgbot | Note Added: 0116320 | |
| 2019-12-17 20:28 | hgbot | Checkin | |
| 2019-12-17 20:28 | hgbot | Note Added: 0116386 | |
| 2019-12-17 20:29 | alekosmp86 | Status | new => scheduled |
| 2019-12-17 20:29 | alekosmp86 | Status | scheduled => resolved |
| 2019-12-17 20:29 | alekosmp86 | Resolution | open => fixed |
| 2019-12-18 14:10 | marvintm | Review Assigned To | => marvintm |
| 2019-12-18 14:10 | marvintm | Note Added: 0116411 | |
| 2019-12-18 14:10 | marvintm | Status | resolved => closed |
| 2019-12-18 14:10 | marvintm | Fixed in Version | => RR20Q1 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |