Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042116Retail ModulesWeb POSpublic2019-10-24 18:062019-12-18 14:10
Reporterjoniturralde93 
Assigned Toalekosmp86 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket12422
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042116: Validate prepayment percentage limit and pick & carry lines at the same time
DescriptionThere two validations are done separately, making the cashier to correct the first one only to get the second validation error message.
Steps To Reproducehttps://livebuilds.openbravo.com/retail_modules_pgsql_pi/ [^]

Organization Vall Boi Store:
- Prepayment percentage: 100
- Prepayment percentage limit: 10

Preference:
- Web POS Allow prepayments lower than the limit: N

Channel - Touchpoint Type VB POS Terminal Type:
- Allow prepayments and partial payments: Checked

1. Log into POS (VB-1) with user Vallboi
2. Change customer to Arturo Montoro
3. Add Headlamp ultralight (18.90)
4. Add a cash payment amount 1
5. Click on Done -> Web POS Prepayments lower than the limit (1.89) not allowed
6. Remove payment and add another one for amount 5
7. Done -> The amount paid is lower than the amount of Pick & Carry lines (18.90€). It is not possible to continue.
Proposed SolutionThe customer requires both of these validations ('prepayment percentage limit' and Pick & Carry lines amount) to be checked at the same time, showing only the higher amount you must pay in order to complete the ticket (in this case, in point 5, it should show the message from point 7 directly.

This way, the cashier saves time and corrects the amount from the beginning

Both validations are done in payment.js (POS Terminal), lines 2478 and 2485
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-10-24 18:06joniturralde93New Issue
2019-10-24 18:06joniturralde93Assigned To => Retail
2019-10-24 18:06joniturralde93OBNetwork customer => OBPS
2019-10-24 18:06joniturralde93Support ticket => 12422
2019-10-24 18:06joniturralde93Triggers an Emergency Pack => No
2019-11-15 13:34marvintmResolution time => 1576364400
2019-11-28 18:46marvintmAssigned ToRetail => alekosmp86
2019-11-28 18:46marvintmStatusnew => scheduled
2019-12-05 15:38hgbotCheckin
2019-12-05 15:38hgbotNote Added: 0116114
2019-12-05 15:38hgbotStatusscheduled => resolved
2019-12-05 15:38hgbotResolutionopen => fixed
2019-12-05 15:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/68823754f3cad33dd9154f7afd8e1decfebb1849 [^]
2019-12-13 13:19marvintmNote Added: 0116310
2019-12-13 13:19marvintmStatusresolved => new
2019-12-13 13:19marvintmResolutionfixed => open
2019-12-13 18:55hgbotCheckin
2019-12-13 18:55hgbotNote Added: 0116320
2019-12-17 20:28hgbotCheckin
2019-12-17 20:28hgbotNote Added: 0116386
2019-12-17 20:29alekosmp86Statusnew => scheduled
2019-12-17 20:29alekosmp86Statusscheduled => resolved
2019-12-17 20:29alekosmp86Resolutionopen => fixed
2019-12-18 14:10marvintmReview Assigned To => marvintm
2019-12-18 14:10marvintmNote Added: 0116411
2019-12-18 14:10marvintmStatusresolved => closed
2019-12-18 14:10marvintmFixed in Version => RR20Q1

Notes
(0116114)
hgbot   
2019-12-05 15:38   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 68823754f3cad33dd9154f7afd8e1decfebb1849
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Wed Dec 04 11:43:35 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/68823754f3cad33dd9154f7afd8e1decfebb1849 [^]

Fixed issue 42116: Verify prepayment limit and pick&carry lines at the same time

When partially paying a ticket, the validations for the prepayment percentage limit
and delivery modes should be done simultaneously showing always the lowest amount
needed for a successful payment. So when the check for the partial payments' preference
fails, we need to still check for the Delivery Modes preference and inform the user
whether the payment can be accepted or not, and the lowest allowed quantity.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0116310)
marvintm   
2019-12-13 13:19   
Fix is not correct. Instead of the current fix, we need to improve the algorithm to take into account pick and carry lines as 100% always, regardless of the prepayment limit defined.
(0116320)
hgbot   
2019-12-13 18:55   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 608a510383d8519fea7b4f63548ae047a8eec87d
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Fri Dec 13 12:54:57 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/608a510383d8519fea7b4f63548ae047a8eec87d [^]

Related to issue 42116: Reverted fix due to the percentage limit calculation
must be updated to take into account the Delivery Modes

Backed out changeset: 68823754f3ca

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0116386)
hgbot   
2019-12-17 20:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9589cf41909300f2e822e3c597d7f472816f733f
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Tue Dec 17 11:14:08 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9589cf41909300f2e822e3c597d7f472816f733f [^]

Related to issue 42116: Take into account the Delivery mode when calculating the
prepayment percentage limit. If Delivery Mode is Pick and Carry then the percentage
limit is always 100

---
M web/org.openbravo.retail.posterminal/js/model/prepaymentrules.js
---
(0116411)
marvintm   
2019-12-18 14:10   
The prepayment is now calculated taking into account that Pick and Carry lines need to be paid in full. This means that as long as you are paying the proposed prepayment amount, you will never encounter the Pick and Carry warning again.

If the standard algorithm is used, this warning will now only appear if you are trying to do a prepayment which is under the limit that is configured in the system.