Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041742
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2019-09-03 12:382019-09-25 08:33
ReportermarvintmView Statuspublic 
Assigned Tomarvintm 
PrioritynormalResolutionfixedFixed in VersionRR19Q4
StatusclosedFix in branchFixed in SCM revisiona5cbd1f7cbac
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041742: There are problems when using OTF coupons

DescriptionCoupons are not applied after they are generated and used in a ticket.
Steps To Reproduce- Define an OTF coupon rule
- Create a ticket and generate a coupon.
- Create another ticket and attempt to use the coupon. Verify that the associated discount is not applied
Proposed Solution.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0114413)
hgbot (developer)
2019-09-05 11:47

 Repository: tools/automation/pi-mobile
Changeset: 216e55610fc3bc8f89600f86aac9380cb7a82e8e
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Sep 03 12:56:04 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/216e55610fc3bc8f89600f86aac9380cb7a82e8e [^]

[NewDiscountEngine] Related to issue 41742. Problems with OTF coupons

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_coupons_otf/CheckOTFCouponsVariable.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/productonfly/CreateOTFWithDiscounts.java
---
(0114546)
hgbot (developer)
2019-09-12 19:25

 Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: eeb7ed9364383ae13d92f9d119d1072245489ccc
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Thu Sep 12 19:16:45 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/eeb7ed9364383ae13d92f9d119d1072245489ccc [^]

Fixed issue 41742. Now coupon object contains all information about the coupon, not just the offerid

---
M web/org.openbravo.retail.discounts/js/discountsengine/common/discount-rules.js
---
(0114547)
hgbot (developer)
2019-09-12 19:25

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a26170110c37b25652739f1cf1d169e26c05d089
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Thu Sep 12 19:17:13 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a26170110c37b25652739f1cf1d169e26c05d089 [^]

Fixed issue 41742. Now coupon object contains all information about the coupon, not just the offerid

---
M web/org.openbravo.retail.posterminal/js/discountsengine/pos/pos-discounts.js
---
(0114548)
hgbot (developer)
2019-09-12 19:26

 Repository: erp/pmods/org.openbravo.retail.discounts.coupons
Changeset: 890d1b1b066995ec05c12e36f804173d5f338f9a
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Thu Sep 12 19:18:55 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/890d1b1b066995ec05c12e36f804173d5f338f9a [^]

Fixed issue 41742. CouponAvailability will return the coupon amount if it exists

---
M src/org/openbravo/retail/discounts/coupons/CouponAvailability.java
M web/org.openbravo.retail.discounts.coupons/js/utils/utils.js
---
(0114549)
hgbot (developer)
2019-09-12 19:26

 Repository: erp/pmods/org.openbravo.retail.discounts.coupons.otf
Changeset: bb2dc28cac673d20e629de12f7e2f37427f1aed1
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Thu Sep 12 19:19:47 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons.otf/rev/bb2dc28cac673d20e629de12f7e2f37427f1aed1 [^]

Fixed issue 41742. Variable amount coupon rule now works correctly with the new discounts engine

---
A src/org/openbravo/retail/discounts/coupons/otf/VariableAmountCouponDiscountEngineAppComponentProvider.java
A web/org.openbravo.retail.discounts.coupons.otf/js/discountsengine/common/rules/variable-amount-coupons-discount.js
---
(0114550)
hgbot (developer)
2019-09-12 19:31

 Repository: tools/automation/pi-mobile
Changeset: 69609bcd46d02a75d496da7d253cb4ddf054d22a
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Thu Sep 12 19:31:30 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/69609bcd46d02a75d496da7d253cb4ddf054d22a [^]

Related to issue 41742. Removed annotations no longer needed, to ensure tests are always executed regardless of issue

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_coupons_otf/CheckOTFCouponsVariable.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/productonfly/CreateOTFWithDiscounts.java
---
(0114751)
jorge-garcia (viewer)
2019-09-24 10:09

 QUALIFIER in VariableAmountCouponDiscountEngineAppComponentProvider.java file should use module prefix instead of org.openbravo.retaildiscount prefix.
(0114765)
hgbot (developer)
2019-09-24 17:21

 Repository: erp/pmods/org.openbravo.retail.discounts.coupons.otf
Changeset: a5cbd1f7cbacbd7146b3df3305cb2b443242444a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Sep 24 17:21:27 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons.otf/rev/a5cbd1f7cbacbd7146b3df3305cb2b443242444a [^]

Fixed issue 41742. Changed qualifier to comply with naming convention

---
M src/org/openbravo/retail/discounts/coupons/otf/VariableAmountCouponDiscountEngineAppComponentProvider.java
---
(0114772)
jorge-garcia (viewer)
2019-09-25 08:33

 Code reviewed and tested

- Issue History
Date Modified Username Field Change
2019-09-03 12:38 marvintm New Issue
2019-09-03 12:38 marvintm Assigned To => Retail
2019-09-03 12:38 marvintm OBNetwork customer => No
2019-09-03 12:38 marvintm Triggers an Emergency Pack => No
2019-09-03 12:39 marvintm Assigned To Retail => marvintm
2019-09-05 11:47 hgbot Checkin
2019-09-05 11:47 hgbot Note Added: 0114413
2019-09-12 19:25 hgbot Checkin
2019-09-12 19:25 hgbot Note Added: 0114546
2019-09-12 19:25 hgbot Status new => resolved
2019-09-12 19:25 hgbot Resolution open => fixed
2019-09-12 19:25 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/eeb7ed9364383ae13d92f9d119d1072245489ccc [^]
2019-09-12 19:25 hgbot Checkin
2019-09-12 19:25 hgbot Note Added: 0114547
2019-09-12 19:25 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/eeb7ed9364383ae13d92f9d119d1072245489ccc [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a26170110c37b25652739f1cf1d169e26c05d089 [^]
2019-09-12 19:26 hgbot Checkin
2019-09-12 19:26 hgbot Note Added: 0114548
2019-09-12 19:26 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a26170110c37b25652739f1cf1d169e26c05d089 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/890d1b1b066995ec05c12e36f804173d5f338f9a [^]
2019-09-12 19:26 hgbot Checkin
2019-09-12 19:26 hgbot Note Added: 0114549
2019-09-12 19:26 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/890d1b1b066995ec05c12e36f804173d5f338f9a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons.otf/rev/bb2dc28cac673d20e629de12f7e2f37427f1aed1 [^]
2019-09-12 19:31 hgbot Checkin
2019-09-12 19:31 hgbot Note Added: 0114550
2019-09-12 19:32 marvintm Review Assigned To => jorge-garcia
2019-09-24 10:09 jorge-garcia Note Added: 0114751
2019-09-24 10:09 jorge-garcia Status resolved => new
2019-09-24 10:09 jorge-garcia Resolution fixed => open
2019-09-24 17:21 hgbot Checkin
2019-09-24 17:21 hgbot Note Added: 0114765
2019-09-24 17:21 hgbot Status new => resolved
2019-09-24 17:21 hgbot Resolution open => fixed
2019-09-24 17:21 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons.otf/rev/bb2dc28cac673d20e629de12f7e2f37427f1aed1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons.otf/rev/a5cbd1f7cbacbd7146b3df3305cb2b443242444a [^]
2019-09-25 08:33 jorge-garcia Note Added: 0114772
2019-09-25 08:33 jorge-garcia Status resolved => closed
2019-09-25 08:33 jorge-garcia Fixed in Version => RR19Q4

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker