Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041742Retail ModulesWeb POSpublic2019-09-03 12:382019-09-25 08:33
Reportermarvintm 
Assigned Tomarvintm 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q4 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041742: There are problems when using OTF coupons
DescriptionCoupons are not applied after they are generated and used in a ticket.
Steps To Reproduce- Define an OTF coupon rule
- Create a ticket and generate a coupon.
- Create another ticket and attempt to use the coupon. Verify that the associated discount is not applied
Proposed Solution.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-09-03 12:38marvintmNew Issue
2019-09-03 12:38marvintmAssigned To => Retail
2019-09-03 12:38marvintmTriggers an Emergency Pack => No
2019-09-03 12:39marvintmAssigned ToRetail => marvintm
2019-09-05 11:47hgbotCheckin
2019-09-05 11:47hgbotNote Added: 0114413
2019-09-12 19:25hgbotCheckin
2019-09-12 19:25hgbotNote Added: 0114546
2019-09-12 19:25hgbotStatusnew => resolved
2019-09-12 19:25hgbotResolutionopen => fixed
2019-09-12 19:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/eeb7ed9364383ae13d92f9d119d1072245489ccc [^]
2019-09-12 19:25hgbotCheckin
2019-09-12 19:25hgbotNote Added: 0114547
2019-09-12 19:25hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/eeb7ed9364383ae13d92f9d119d1072245489ccc [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a26170110c37b25652739f1cf1d169e26c05d089 [^]
2019-09-12 19:26hgbotCheckin
2019-09-12 19:26hgbotNote Added: 0114548
2019-09-12 19:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a26170110c37b25652739f1cf1d169e26c05d089 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/890d1b1b066995ec05c12e36f804173d5f338f9a [^]
2019-09-12 19:26hgbotCheckin
2019-09-12 19:26hgbotNote Added: 0114549
2019-09-12 19:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/890d1b1b066995ec05c12e36f804173d5f338f9a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons.otf/rev/bb2dc28cac673d20e629de12f7e2f37427f1aed1 [^]
2019-09-12 19:31hgbotCheckin
2019-09-12 19:31hgbotNote Added: 0114550
2019-09-12 19:32marvintmReview Assigned To => jorge-garcia
2019-09-24 10:09jorge-garciaNote Added: 0114751
2019-09-24 10:09jorge-garciaStatusresolved => new
2019-09-24 10:09jorge-garciaResolutionfixed => open
2019-09-24 17:21hgbotCheckin
2019-09-24 17:21hgbotNote Added: 0114765
2019-09-24 17:21hgbotStatusnew => resolved
2019-09-24 17:21hgbotResolutionopen => fixed
2019-09-24 17:21hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons.otf/rev/bb2dc28cac673d20e629de12f7e2f37427f1aed1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons.otf/rev/a5cbd1f7cbacbd7146b3df3305cb2b443242444a [^]
2019-09-25 08:33jorge-garciaNote Added: 0114772
2019-09-25 08:33jorge-garciaStatusresolved => closed
2019-09-25 08:33jorge-garciaFixed in Version => RR19Q4

Notes
(0114413)
hgbot   
2019-09-05 11:47   
Repository: tools/automation/pi-mobile
Changeset: 216e55610fc3bc8f89600f86aac9380cb7a82e8e
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Sep 03 12:56:04 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/216e55610fc3bc8f89600f86aac9380cb7a82e8e [^]

[NewDiscountEngine] Related to issue 41742. Problems with OTF coupons

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_coupons_otf/CheckOTFCouponsVariable.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/productonfly/CreateOTFWithDiscounts.java
---
(0114546)
hgbot   
2019-09-12 19:25   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: eeb7ed9364383ae13d92f9d119d1072245489ccc
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Thu Sep 12 19:16:45 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/eeb7ed9364383ae13d92f9d119d1072245489ccc [^]

Fixed issue 41742. Now coupon object contains all information about the coupon, not just the offerid

---
M web/org.openbravo.retail.discounts/js/discountsengine/common/discount-rules.js
---
(0114547)
hgbot   
2019-09-12 19:25   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a26170110c37b25652739f1cf1d169e26c05d089
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Thu Sep 12 19:17:13 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a26170110c37b25652739f1cf1d169e26c05d089 [^]

Fixed issue 41742. Now coupon object contains all information about the coupon, not just the offerid

---
M web/org.openbravo.retail.posterminal/js/discountsengine/pos/pos-discounts.js
---
(0114548)
hgbot   
2019-09-12 19:26   
Repository: erp/pmods/org.openbravo.retail.discounts.coupons
Changeset: 890d1b1b066995ec05c12e36f804173d5f338f9a
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Thu Sep 12 19:18:55 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/890d1b1b066995ec05c12e36f804173d5f338f9a [^]

Fixed issue 41742. CouponAvailability will return the coupon amount if it exists

---
M src/org/openbravo/retail/discounts/coupons/CouponAvailability.java
M web/org.openbravo.retail.discounts.coupons/js/utils/utils.js
---
(0114549)
hgbot   
2019-09-12 19:26   
Repository: erp/pmods/org.openbravo.retail.discounts.coupons.otf
Changeset: bb2dc28cac673d20e629de12f7e2f37427f1aed1
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Thu Sep 12 19:19:47 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons.otf/rev/bb2dc28cac673d20e629de12f7e2f37427f1aed1 [^]

Fixed issue 41742. Variable amount coupon rule now works correctly with the new discounts engine

---
A src/org/openbravo/retail/discounts/coupons/otf/VariableAmountCouponDiscountEngineAppComponentProvider.java
A web/org.openbravo.retail.discounts.coupons.otf/js/discountsengine/common/rules/variable-amount-coupons-discount.js
---
(0114550)
hgbot   
2019-09-12 19:31   
Repository: tools/automation/pi-mobile
Changeset: 69609bcd46d02a75d496da7d253cb4ddf054d22a
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Thu Sep 12 19:31:30 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/69609bcd46d02a75d496da7d253cb4ddf054d22a [^]

Related to issue 41742. Removed annotations no longer needed, to ensure tests are always executed regardless of issue

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_coupons_otf/CheckOTFCouponsVariable.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/productonfly/CreateOTFWithDiscounts.java
---
(0114751)
jorge-garcia   
2019-09-24 10:09   
QUALIFIER in VariableAmountCouponDiscountEngineAppComponentProvider.java file should use module prefix instead of org.openbravo.retaildiscount prefix.
(0114765)
hgbot   
2019-09-24 17:21   
Repository: erp/pmods/org.openbravo.retail.discounts.coupons.otf
Changeset: a5cbd1f7cbacbd7146b3df3305cb2b443242444a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Sep 24 17:21:27 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons.otf/rev/a5cbd1f7cbacbd7146b3df3305cb2b443242444a [^]

Fixed issue 41742. Changed qualifier to comply with naming convention

---
M src/org/openbravo/retail/discounts/coupons/otf/VariableAmountCouponDiscountEngineAppComponentProvider.java
---
(0114772)
jorge-garcia   
2019-09-25 08:33   
Code reviewed and tested