0041622: Invoices paid with inactive payment methods cannot be printed from WebPOS

Description

Invoices paid with inactive payment methods (deactivated in Touchpoint/touchpoint type) cannot be printed from WebPOS.

When trying to print these invoices, the following error appears:
2019-08-03 10:46:16,112 [ajp-nio-127.0.0.1-8009-exec-29] ERROR org.openbravo.mobile.core.process.JSONRowConverter - Error in JSON process: org.hibernate.hql.internal.ast.QuerySyntaxException: expecting EOF, found ')' near line 1, column 376 [select p.paymentMethod.name as name, p.account.id as account, c_currency_rate(p.account.currency, p.organization.currency, null, null, p.client.id, p.organization.id) as rate, c_currency_rate(p.organization.currency, p.account.currency, null, null, p.client.id, p.organization.id) as mulrate, p.account.currency.iSOCode as isocode from FIN_Payment as p where p.id=:paymentId)]
java.lang.IllegalArgumentException: org.hibernate.hql.internal.ast.QuerySyntaxException: expecting EOF, found ')' near line 1, column 376 [select p.paymentMethod.name as name, p.account.id as account, c_currency_rate(p.account.currency, p.organization.currency, null, null, p.client.id, p.organization.id) as rate, c_currency_rate(p.organization.currency, p.account.currency, null, null, p.client.id, p.organization.id) as mulrate, p.account.currency.iSOCode as isocode from FIN_Payment as p where p.id=:paymentId)]
at org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:133) ~[hibernate-core-5.3.2.Final.jar:5.3.2.Final]
at org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:157) ~[hibernate-core-5.3.2.Final.jar:5.3.2.Final]
at org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:164) ~[hibernate-core-5.3.2.Final.jar:5.3.2.Final]
at org.hibernate.internal.AbstractSharedSessionContract.createQuery(AbstractSharedSessionContract.java:715) ~[hibernate-core-5.3.2.Final.jar:5.3.2.Final]
at org.hibernate.internal.AbstractSessionImpl.createQuery(AbstractSessionImpl.java:23) ~[hibernate-core-5.3.2.Final.jar:5.3.2.Final]
at org.openbravo.retail.posterminal.Invoices.exec(Invoices.java:255) ~[classes/:?]

Steps To Reproduce

There is an extra closing parentheses in Invoices.java:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/Invoices.java#l253 [^]

Tags

No tags attached.

Attached Files

Issue41622.diff [^] (955 bytes) 2019-08-09 11:03 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/posterminal/Invoices.java b/src/org/openbravo/retail/posterminal/Invoices.java
--- a/src/org/openbravo/retail/posterminal/Invoices.java
+++ b/src/org/openbravo/retail/posterminal/Invoices.java
@@ -250,7 +250,7 @@
                 + "c_currency_rate(p.account.currency, p.organization.currency, null, null, p.client.id, p.organization.id) as rate, "
                 + "c_currency_rate(p.organization.currency, p.account.currency, null, null, p.client.id, p.organization.id) as mulrate, "
                 + "p.account.currency.iSOCode as isocode "
-                + " from FIN_Payment as p where p.id=:paymentId)";
+                + " from FIN_Payment as p where p.id=:paymentId";
             @SuppressWarnings("rawtypes")
             Query paymentTypeQuery = OBDal.getInstance().getSession().createQuery(hqlPaymentType);
             paymentTypeQuery.setParameter("paymentId", objectIn.getString("paymentId"));

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

0041420

closed

alekosmp86

Loading a ticket with a payment that is not configured fails

Notes
(0113950) hgbot (developer) 2019-08-12 14:53	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 33764fe32281b88d95fec2a74b4e6caf5e1e6355 Author: Rafael Queralta <rafaelcuba81 <at> gmail.com> Date: Sun Aug 11 23:33:03 2019 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/33764fe32281b88d95fec2a74b4e6caf5e1e6355 [^] Fixed issue 41622: Invoices paid with inactive payment methods cannot be printed from WebPOS - Removed extra closing parentheses in Invoices.java --- M src/org/openbravo/retail/posterminal/Invoices.java ---

Issue History
Date Modified	Username	Field	Change
2019-08-09 11:02	aaroncalero	New Issue
2019-08-09 11:02	aaroncalero	Assigned To	=> Retail
2019-08-09 11:02	aaroncalero	OBNetwork customer	=> Gold
2019-08-09 11:02	aaroncalero	Resolution time	=> 1566511200
2019-08-09 11:02	aaroncalero	Triggers an Emergency Pack	=> No
2019-08-09 11:03	aaroncalero	Relationship added	related to 0041420
2019-08-09 11:03	aaroncalero	File Added: Issue41622.diff
2019-08-09 15:35	rqueralta	Assigned To	Retail => rqueralta
2019-08-12 14:53	hgbot	Checkin
2019-08-12 14:53	hgbot	Note Added: 0113950
2019-08-12 14:53	hgbot	Status	new => resolved
2019-08-12 14:53	hgbot	Resolution	open => fixed
2019-08-12 14:53	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/33764fe32281b88d95fec2a74b4e6caf5e1e6355 [^]
2019-08-13 14:20	marvintm	Review Assigned To	=> marvintm
2019-08-13 14:20	marvintm	Status	resolved => closed
2019-08-13 14:20	marvintm	Fixed in Version	=> RR19Q4