Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041622Retail ModulesWeb POSpublic2019-08-09 11:022019-08-13 14:20
Reporteraaroncalero 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041622: Invoices paid with inactive payment methods cannot be printed from WebPOS
DescriptionInvoices paid with inactive payment methods (deactivated in Touchpoint/touchpoint type) cannot be printed from WebPOS.

When trying to print these invoices, the following error appears:
2019-08-03 10:46:16,112 [ajp-nio-127.0.0.1-8009-exec-29] ERROR org.openbravo.mobile.core.process.JSONRowConverter - Error in JSON process: org.hibernate.hql.internal.ast.QuerySyntaxException: expecting EOF, found ')' near line 1, column 376 [select p.paymentMethod.name as name, p.account.id as account, c_currency_rate(p.account.currency, p.organization.currency, null, null, p.client.id, p.organization.id) as rate, c_currency_rate(p.organization.currency, p.account.currency, null, null, p.client.id, p.organization.id) as mulrate, p.account.currency.iSOCode as isocode from FIN_Payment as p where p.id=:paymentId)]
java.lang.IllegalArgumentException: org.hibernate.hql.internal.ast.QuerySyntaxException: expecting EOF, found ')' near line 1, column 376 [select p.paymentMethod.name as name, p.account.id as account, c_currency_rate(p.account.currency, p.organization.currency, null, null, p.client.id, p.organization.id) as rate, c_currency_rate(p.organization.currency, p.account.currency, null, null, p.client.id, p.organization.id) as mulrate, p.account.currency.iSOCode as isocode from FIN_Payment as p where p.id=:paymentId)]
at org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:133) ~[hibernate-core-5.3.2.Final.jar:5.3.2.Final]
at org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:157) ~[hibernate-core-5.3.2.Final.jar:5.3.2.Final]
at org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:164) ~[hibernate-core-5.3.2.Final.jar:5.3.2.Final]
at org.hibernate.internal.AbstractSharedSessionContract.createQuery(AbstractSharedSessionContract.java:715) ~[hibernate-core-5.3.2.Final.jar:5.3.2.Final]
at org.hibernate.internal.AbstractSessionImpl.createQuery(AbstractSessionImpl.java:23) ~[hibernate-core-5.3.2.Final.jar:5.3.2.Final]
at org.openbravo.retail.posterminal.Invoices.exec(Invoices.java:255) ~[classes/:?]
Steps To ReproduceThere is an extra closing parentheses in Invoices.java:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/Invoices.java#l253 [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041420 closed alekosmp86 Loading a ticket with a payment that is not configured fails 
Attached Filesdiff Issue41622.diff (955) 2019-08-09 11:03
https://issues.openbravo.com/file_download.php?file_id=13219&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-08-09 11:02aaroncaleroNew Issue
2019-08-09 11:02aaroncaleroAssigned To => Retail
2019-08-09 11:02aaroncaleroResolution time => 1566511200
2019-08-09 11:02aaroncaleroTriggers an Emergency Pack => No
2019-08-09 11:03aaroncaleroRelationship addedrelated to 0041420
2019-08-09 11:03aaroncaleroFile Added: Issue41622.diff
2019-08-09 15:35rqueraltaAssigned ToRetail => rqueralta
2019-08-12 14:53hgbotCheckin
2019-08-12 14:53hgbotNote Added: 0113950
2019-08-12 14:53hgbotStatusnew => resolved
2019-08-12 14:53hgbotResolutionopen => fixed
2019-08-12 14:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/33764fe32281b88d95fec2a74b4e6caf5e1e6355 [^]
2019-08-13 14:20marvintmReview Assigned To => marvintm
2019-08-13 14:20marvintmStatusresolved => closed
2019-08-13 14:20marvintmFixed in Version => RR19Q4

Notes
(0113950)
hgbot   
2019-08-12 14:53   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 33764fe32281b88d95fec2a74b4e6caf5e1e6355
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Sun Aug 11 23:33:03 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/33764fe32281b88d95fec2a74b4e6caf5e1e6355 [^]

Fixed issue 41622: Invoices paid with inactive payment methods cannot be printed
from WebPOS

- Removed extra closing parentheses in Invoices.java

---
M src/org/openbravo/retail/posterminal/Invoices.java
---