0041402: Services ignore the Grouped Product configuration after a Cancel and Replace

Description

Services ignore the Grouped Product configuration after a Cancel and Replace.
When the same service is related to different lines before and after a cancel and replace process, the service quantity rules ignore the grouped property and always treat the service as a non-grouped product.

This causes problems when delivering the service because both service lines remain related to all products.

Steps To Reproduce

Login in backend, go to the product window, find the Delivery Service record and change its quantity rule to As Per Product.

Login in WebPOS
Create a new ticket
Convert it into a Layaway (Menu > Layaway this Receipt)
Add a Sofa
Add a Bed
Click on the Related Services button of the Sofa line and add a Delivery Service.
Click on the Total Amount button and then click on Layaway to confirm the layaway.

Load the Layaway again
Go to the Menu > Cancel and Replace
Click on the Related Services button of the Bed line and add a Delivery Service.
=> Verify that a new Delivery Service line has been created, and that both services keep a relationship to both the Sofa and the Bed.

Proposed Solution

Attached a patch that ensures that the groupService property (the groupedProduct equivalent for services) is correctly loaded when a ticket is loaded in WebPOS.

Tags

No tags attached.

Attached Files

Issue41402.diff [^] (624 bytes) 2019-07-18 18:28 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/model/order.js b/web/org.openbravo.retail.posterminal/js/model/order.js
--- a/web/org.openbravo.retail.posterminal/js/model/order.js
+++ b/web/org.openbravo.retail.posterminal/js/model/order.js
@@ -9726,6 +9726,7 @@
                         warehousename: iter.warehousename
                       },
                       relatedLines: iter.relatedLines,
+                      groupService : prod.get('groupProduct'),
                       isEditable: true,
                       isDeletable: true,
                       attSetInstanceDesc: iter.attSetInstanceDesc

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0113792) hgbot (developer) 2019-08-02 20:02	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 112cf32274eba3b3f403f25663d6cd7c8405fe20 Author: Alejandro <alekosmp86 <at> gmail.com> Date: Thu Aug 01 15:28:55 2019 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/112cf32274eba3b3f403f25663d6cd7c8405fe20 [^] Fixed issue 41402: Services no longer ignore the Grouped Product configuration after a Cancel and Replace --- M web/org.openbravo.retail.posterminal/js/model/order.js ---

Issue History
Date Modified	Username	Field	Change
2019-07-18 18:23	aaroncalero	New Issue
2019-07-18 18:23	aaroncalero	Assigned To	=> Retail
2019-07-18 18:23	aaroncalero	Triggers an Emergency Pack	=> No
2019-07-18 18:23	aaroncalero	Resolution time	=> 1564610400
2019-07-18 18:28	aaroncalero	File Added: Issue41402.diff
2019-08-01 20:54	alekosmp86	Assigned To	Retail => alekosmp86
2019-08-02 20:02	hgbot	Checkin
2019-08-02 20:02	hgbot	Note Added: 0113792
2019-08-02 20:02	hgbot	Status	new => resolved
2019-08-02 20:02	hgbot	Resolution	open => fixed
2019-08-02 20:02	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/112cf32274eba3b3f403f25663d6cd7c8405fe20 [^]
2019-08-05 08:55	marvintm	Review Assigned To	=> marvintm
2019-08-05 08:55	marvintm	Status	resolved => closed
2019-08-05 08:55	marvintm	Fixed in Version	=> RR19Q4