Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0041340
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Return Receiptmajoralways2019-07-12 09:302019-08-01 08:15
ReporterasiermartirenaView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityurgentResolutionfixedFixed in VersionRR19Q4
StatusclosedFix in branchFixed in SCM revisiond390dd10f107
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041340: Multiple joins when loading a verified return

DescriptionThe query that is loading the lines to return is doing more joins than needed. This is the current code in PaidReceipts.java:

select
  ordLine.goodsShipmentLine.salesOrderLine.salesOrder.documentNo,
  ordLine.goodsShipmentLine.salesOrderLine.id
from OrderLine as ordLine
where ordLine.id = :lineId

The joins to the goodsShipmentLine and salesOrderLine is duplicated. The query should be the following one:

select
  retOrdLine.salesOrder.documentNo,
  retOrdLine.id
from OrderLine as ordLine
  join ordLine.goodsShipmentLine.salesOrderLine as retOrdLine
where ordLine.id = :lineId
Steps To ReproduceCheck the query in the PaidReceipts.java class.
TagsPerformance
Attached Filespatch file icon 41340.patch [^] (1,360 bytes) 2019-07-22 05:13 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0113710)
hgbot (developer)
2019-07-30 14:15

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d390dd10f10709bde591ce980878f2dbb5579df0
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jul 30 17:44:55 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d390dd10f10709bde591ce980878f2dbb5579df0 [^]

Fixed issue 41340 : Paid Receipt Return Order lines query updated by removing unnecessary joins

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---

- Issue History
Date Modified Username Field Change
2019-07-12 09:30 asiermartirena New Issue
2019-07-12 09:30 asiermartirena Assigned To => Retail
2019-07-12 09:30 asiermartirena Triggers an Emergency Pack => No
2019-07-12 09:31 asiermartirena Tag Attached: Performance
2019-07-15 07:10 guillermogil Resolution time => 1563573600
2019-07-18 04:53 rqueralta Assigned To Retail => rqueralta
2019-07-18 04:53 rqueralta Status new => scheduled
2019-07-22 05:13 rqueralta File Added: 41340.patch
2019-07-23 13:56 ranjith_qualiantech_com Assigned To rqueralta => ranjith_qualiantech_com
2019-07-30 14:15 hgbot Checkin
2019-07-30 14:15 hgbot Note Added: 0113710
2019-07-30 14:15 hgbot Status scheduled => resolved
2019-07-30 14:15 hgbot Resolution open => fixed
2019-07-30 14:15 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d390dd10f10709bde591ce980878f2dbb5579df0 [^]
2019-08-01 08:15 marvintm Review Assigned To => marvintm
2019-08-01 08:15 marvintm Status resolved => closed
2019-08-01 08:15 marvintm Fixed in Version => RR19Q4


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker