Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0041340 | Retail Modules | Return Receipt | public | 2019-07-12 09:30 | 2019-08-01 08:15 |
|
| Reporter | asiermartirena | |
| Assigned To | ranjith_qualiantech_com | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR19Q4 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | Gold |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0041340: Multiple joins when loading a verified return |
| Description | The query that is loading the lines to return is doing more joins than needed. This is the current code in PaidReceipts.java:
select
ordLine.goodsShipmentLine.salesOrderLine.salesOrder.documentNo,
ordLine.goodsShipmentLine.salesOrderLine.id
from OrderLine as ordLine
where ordLine.id = :lineId
The joins to the goodsShipmentLine and salesOrderLine is duplicated. The query should be the following one:
select
retOrdLine.salesOrder.documentNo,
retOrdLine.id
from OrderLine as ordLine
join ordLine.goodsShipmentLine.salesOrderLine as retOrdLine
where ordLine.id = :lineId |
| Steps To Reproduce | Check the query in the PaidReceipts.java class. |
| Proposed Solution | |
| Additional Information | |
| Tags | Performance |
| Relationships | |
| Attached Files |  41340.patch (1,360) 2019-07-22 05:13
https://issues.openbravo.com/file_download.php?file_id=13159&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2019-07-12 09:30 | asiermartirena | New Issue | |
| 2019-07-12 09:30 | asiermartirena | Assigned To | => Retail |
| 2019-07-12 09:30 | asiermartirena | OBNetwork customer | => Gold |
| 2019-07-12 09:30 | asiermartirena | Triggers an Emergency Pack | => No |
| 2019-07-12 09:31 | asiermartirena | Tag Attached: Performance | |
| 2019-07-15 07:10 | guillermogil | Resolution time | => 1563573600 |
| 2019-07-18 04:53 | rqueralta | Assigned To | Retail => rqueralta |
| 2019-07-18 04:53 | rqueralta | Status | new => scheduled |
| 2019-07-22 05:13 | rqueralta | File Added: 41340.patch | |
| 2019-07-23 13:56 | ranjith_qualiantech_com | Assigned To | rqueralta => ranjith_qualiantech_com |
| 2019-07-30 14:15 | hgbot | Checkin | |
| 2019-07-30 14:15 | hgbot | Note Added: 0113710 | |
| 2019-07-30 14:15 | hgbot | Status | scheduled => resolved |
| 2019-07-30 14:15 | hgbot | Resolution | open => fixed |
| 2019-07-30 14:15 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d390dd10f10709bde591ce980878f2dbb5579df0 [^] |
| 2019-08-01 08:15 | marvintm | Review Assigned To | => marvintm |
| 2019-08-01 08:15 | marvintm | Status | resolved => closed |
| 2019-08-01 08:15 | marvintm | Fixed in Version | => RR19Q4 |