Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041284
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Localization Pack: Spain] AEAT 390minorhave not tried2019-07-04 14:032019-09-05 09:01
ReportershuehnerView Statuspublic 
Assigned Tocollazoandy4 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision0d008bfbd2b2
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Regression introduced in release
Summary

0041284: AEAT390ReportDao and AEAT390CashVATReadyDao are not using bind-params

DescriptionThe 2 + 2 functions below are not using bind-params:

get390TaxesOrderByRate
getInvoiceTax


getCashVATPayments
getInvoiceTaxSR

When fixing please apply new HQL-style to every HQL in those 2 files.

Note: while fixing probably the utility function AEAT390Utility.createINClauseForOrgs should be removed as it invites writing unsafe code.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0041514 closedcollazoandy4 Localization Pack: Spain Apply HQL style guide to AEAT390ReportDao and AEAT390CashVATReadyDao 
blocks design defect 0038136 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 

-  Notes
(0113762)
collazoandy4 (reporter)
2019-08-01 16:24

 Test Plan
  Go to Organization window and select F&B España record
  In Actividades del IAE tab create a new record:
    Epígrafe IAE: 1 - 04 - AVICULTURA
    Default: true
    Clave: 3 - Epígrafe 862 correspondiente a: Alquiler de inmuebles rústicos
  Go to Tax Report Launcher window
    Organization: F&B España, S.A
    Report: Modelo 390 v2011 - Declaración Anual del IVA
    Accounting Schema: F&B España, S.A US/A/Euro
    Year: 2011
    Period: Anually
    Clic on Input Parameter button
    Clic on Generate Electronic File button and check the process ends without errors

Test Plan II
  Repeat the previous test plan for Modelo 390 v2017 - Declaración Anual del IVA Report
(0114399)
hgbot (developer)
2019-09-04 13:40

 Repository: erp/pmods/org.openbravo.module.aeat390.es
Changeset: 0d008bfbd2b2961efd50cc0b96bcedf6a98446c1
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Aug 01 10:22:06 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat390.es/rev/0d008bfbd2b2961efd50cc0b96bcedf6a98446c1 [^]

Fixes issue 41284:AEAT390ReportDao and AEAT390CashVATReadyDao are not using
bind-params

Added the missing bind parameters

---
M src/org/openbravo/module/aeat390/es/api/AEAT390ReportDao.java
M src/org/openbravo/module/aeat390/es/api/cashvat/AEAT390CashVATReadyDao.java
M src/org/openbravo/module/aeat390/es/utility/AEAT390Utility.java
---
(0114400)
hgbot (developer)
2019-09-04 13:40

 Repository: erp/pmods/org.openbravo.module.aeat390.es
Changeset: e7dd73ba3d7b9e4a502bf1e938f6c6ec0c664994
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Sep 04 13:40:24 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat390.es/rev/e7dd73ba3d7b9e4a502bf1e938f6c6ec0c664994 [^]

related to issue 41284 code review changes

* manage properly when parameter is null or empty

---
M src/org/openbravo/module/aeat390/es/api/AEAT390ReportDao.java
M src/org/openbravo/module/aeat390/es/api/cashvat/AEAT390CashVATReadyDao.java
---
(0114401)
Sandrahuguet (developer)
2019-09-04 13:43

 code review + testing ok
(0114407)
hgbot (developer)
2019-09-05 09:01

 Repository: erp/pmods/org.openbravo.module.aeat390.es
Changeset: 2766a92e6fa8e297079855018400b3a46b52d367
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Sep 05 09:00:50 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat390.es/rev/2766a92e6fa8e297079855018400b3a46b52d367 [^]

related to issue 41284 manage properly null or empty

---
M src/org/openbravo/module/aeat390/es/api/AEAT390ReportDao.java
M src/org/openbravo/module/aeat390/es/api/cashvat/AEAT390CashVATReadyDao.java
---

- Issue History
Date Modified Username Field Change
2019-07-04 14:03 shuehner New Issue
2019-07-04 14:03 shuehner Assigned To => Opentix-Test
2019-07-04 14:03 shuehner Relationship added blocks 0038136
2019-07-26 08:20 dmiguelez Assigned To Opentix-Test => collazoandy4
2019-07-30 18:27 collazoandy4 Status new => scheduled
2019-08-01 16:24 collazoandy4 Note Added: 0113762
2019-09-02 10:38 Sandrahuguet Relationship added related to 0041514
2019-09-04 13:40 hgbot Checkin
2019-09-04 13:40 hgbot Note Added: 0114399
2019-09-04 13:40 hgbot Status scheduled => resolved
2019-09-04 13:40 hgbot Resolution open => fixed
2019-09-04 13:40 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat390.es/rev/0d008bfbd2b2961efd50cc0b96bcedf6a98446c1 [^]
2019-09-04 13:40 hgbot Checkin
2019-09-04 13:40 hgbot Note Added: 0114400
2019-09-04 13:43 Sandrahuguet Review Assigned To => Sandrahuguet
2019-09-04 13:43 Sandrahuguet Note Added: 0114401
2019-09-04 13:43 Sandrahuguet Status resolved => closed
2019-09-04 18:20 Sandrahuguet Status closed => new
2019-09-04 18:20 Sandrahuguet Resolution fixed => open
2019-09-05 09:01 hgbot Checkin
2019-09-05 09:01 hgbot Note Added: 0114407
2019-09-05 09:01 Sandrahuguet Status new => scheduled
2019-09-05 09:01 Sandrahuguet Status scheduled => resolved
2019-09-05 09:01 Sandrahuguet Resolution open => fixed
2019-09-05 09:01 Sandrahuguet Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker