Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041284Localization Pack: SpainAEAT 390public2019-07-04 14:032019-09-05 09:01
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Support ticket
OBNetwork customer
Regression introduced in release
Summary0041284: AEAT390ReportDao and AEAT390CashVATReadyDao are not using bind-params
DescriptionThe 2 + 2 functions below are not using bind-params:

get390TaxesOrderByRate
getInvoiceTax


getCashVATPayments
getInvoiceTaxSR

When fixing please apply new HQL-style to every HQL in those 2 files.

Note: while fixing probably the utility function AEAT390Utility.createINClauseForOrgs should be removed as it invites writing unsafe code.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041514 closed collazoandy4 Localization Pack: Spain Apply HQL style guide to AEAT390ReportDao and AEAT390CashVATReadyDao 
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-04 14:03shuehnerNew Issue
2019-07-04 14:03shuehnerAssigned To => Opentix-Test
2019-07-04 14:03shuehnerRelationship addedblocks 0038136
2019-07-26 08:20dmiguelezAssigned ToOpentix-Test => collazoandy4
2019-07-30 18:27collazoandy4Statusnew => scheduled
2019-08-01 16:24collazoandy4Note Added: 0113762
2019-09-02 10:38SandrahuguetRelationship addedrelated to 0041514
2019-09-04 13:40hgbotCheckin
2019-09-04 13:40hgbotNote Added: 0114399
2019-09-04 13:40hgbotStatusscheduled => resolved
2019-09-04 13:40hgbotResolutionopen => fixed
2019-09-04 13:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat390.es/rev/0d008bfbd2b2961efd50cc0b96bcedf6a98446c1 [^]
2019-09-04 13:40hgbotCheckin
2019-09-04 13:40hgbotNote Added: 0114400
2019-09-04 13:43SandrahuguetReview Assigned To => Sandrahuguet
2019-09-04 13:43SandrahuguetNote Added: 0114401
2019-09-04 13:43SandrahuguetStatusresolved => closed
2019-09-04 18:20SandrahuguetStatusclosed => new
2019-09-04 18:20SandrahuguetResolutionfixed => open
2019-09-05 09:01hgbotCheckin
2019-09-05 09:01hgbotNote Added: 0114407
2019-09-05 09:01SandrahuguetStatusnew => scheduled
2019-09-05 09:01SandrahuguetStatusscheduled => resolved
2019-09-05 09:01SandrahuguetResolutionopen => fixed
2019-09-05 09:01SandrahuguetStatusresolved => closed

Notes
(0113762)
collazoandy4   
2019-08-01 16:24   
Test Plan
  Go to Organization window and select F&B España record
  In Actividades del IAE tab create a new record:
    Epígrafe IAE: 1 - 04 - AVICULTURA
    Default: true
    Clave: 3 - Epígrafe 862 correspondiente a: Alquiler de inmuebles rústicos
  Go to Tax Report Launcher window
    Organization: F&B España, S.A
    Report: Modelo 390 v2011 - Declaración Anual del IVA
    Accounting Schema: F&B España, S.A US/A/Euro
    Year: 2011
    Period: Anually
    Clic on Input Parameter button
    Clic on Generate Electronic File button and check the process ends without errors

Test Plan II
  Repeat the previous test plan for Modelo 390 v2017 - Declaración Anual del IVA Report
(0114399)
hgbot   
2019-09-04 13:40   
Repository: erp/pmods/org.openbravo.module.aeat390.es
Changeset: 0d008bfbd2b2961efd50cc0b96bcedf6a98446c1
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Aug 01 10:22:06 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat390.es/rev/0d008bfbd2b2961efd50cc0b96bcedf6a98446c1 [^]

Fixes issue 41284:AEAT390ReportDao and AEAT390CashVATReadyDao are not using
bind-params

Added the missing bind parameters

---
M src/org/openbravo/module/aeat390/es/api/AEAT390ReportDao.java
M src/org/openbravo/module/aeat390/es/api/cashvat/AEAT390CashVATReadyDao.java
M src/org/openbravo/module/aeat390/es/utility/AEAT390Utility.java
---
(0114400)
hgbot   
2019-09-04 13:40   
Repository: erp/pmods/org.openbravo.module.aeat390.es
Changeset: e7dd73ba3d7b9e4a502bf1e938f6c6ec0c664994
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Sep 04 13:40:24 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat390.es/rev/e7dd73ba3d7b9e4a502bf1e938f6c6ec0c664994 [^]

related to issue 41284 code review changes

* manage properly when parameter is null or empty

---
M src/org/openbravo/module/aeat390/es/api/AEAT390ReportDao.java
M src/org/openbravo/module/aeat390/es/api/cashvat/AEAT390CashVATReadyDao.java
---
(0114401)
Sandrahuguet   
2019-09-04 13:43   
code review + testing ok
(0114407)
hgbot   
2019-09-05 09:01   
Repository: erp/pmods/org.openbravo.module.aeat390.es
Changeset: 2766a92e6fa8e297079855018400b3a46b52d367
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Sep 05 09:00:50 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat390.es/rev/2766a92e6fa8e297079855018400b3a46b52d367 [^]

related to issue 41284 manage properly null or empty

---
M src/org/openbravo/module/aeat390/es/api/AEAT390ReportDao.java
M src/org/openbravo/module/aeat390/es/api/cashvat/AEAT390CashVATReadyDao.java
---