Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041280
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Localization Pack: Spain] AEAT 347minorhave not tried2019-07-04 12:572019-09-10 16:31
ReportershuehnerView Statuspublic 
Assigned Tocollazoandy4 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision73febed8b345
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Regression introduced in release
Summary

0041280: AEAT347ReportAPRDao is not using bind-params

DescriptionSeveral method in this class are not using bind-params.

One of those cashAmounts is public but unused apparently so maybe deletion candidate instead.

When fixing please apply new HQL-style to every HQL in this file.

When fixing also fix the deprecation warning related to 'getReadableClientsIncluse' as it is related to the bind-param topic

When fixing please also fix the java11 compile warnings still present in this file.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0041527 closedcollazoandy4 Localization Pack: Spain Apply HQL style guide to AEAT347ReportAPRDao 
blocks design defect 0038136 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 

-  Notes
(0113817)
collazoandy4 (reporter)
2019-08-05 15:43

 Test Plan
  Go to Tax Report Launcher and set:
    Organization: F&B España S.A
    Report: Modelo 347 2014 - Declaracion anual de operaciones con terceras personas
    Accounting Schema: F&B España, S.A US/A/Euro
    Calendar: Calendario España
    Year: 2017
    Period: Anually
    Clic on Input Parameter button
    Fill out the Persona and Teléfono fields
    Clic on Generate Electronic File button and check the process ends without errors

Test Plan
  Repeat the previous test plan for 'Modelo 347 2015 - Declaracion anual de operaciones con terceras personas' report
(0114371)
hgbot (developer)
2019-09-03 11:00

 Repository: erp/pmods/org.openbravo.module.aeat347apr.es
Changeset: be3a3881a6bf709a4ff772179e5335f4ac4e6d0c
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Fri Aug 02 15:50:00 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/be3a3881a6bf709a4ff772179e5335f4ac4e6d0c [^]

Fixes issue 41280: AEAT347ReportAPRDao and AEAT347ReportAPR2014Dao is not using
bind-params

Added missing bind-parameters

---
M src/org/openbravo/module/aeat347apr/es/AEAT347ReportAPRDao.java
M src/org/openbravo/module/aeat347apr/es/utility/Utility347.java
M src/org/openbravo/module/aeat347apr/es/v2014/AEAT347ReportAPR2014Dao.java
---
(0114372)
hgbot (developer)
2019-09-03 11:00

 Repository: erp/pmods/org.openbravo.module.aeat347apr.es
Changeset: d71c6b6e639ff71e2f23eeb8e92e66ec382a4e02
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Sep 03 10:59:55 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/d71c6b6e639ff71e2f23eeb8e92e66ec382a4e02 [^]

related to issue 41280 code review changes

* leave the currency constant
* fix taxRates2

---
M src/org/openbravo/module/aeat347apr/es/AEAT347ReportAPRDao.java
M src/org/openbravo/module/aeat347apr/es/v2014/AEAT347ReportAPR2014Dao.java
---
(0114373)
Sandrahuguet (developer)
2019-09-03 11:02

 code review + testing ok
(0114383)
Sandrahuguet (developer)
2019-09-03 16:42

 backout changesets:
https://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/3bea2095c6c9 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/98bc5ec921b0 [^]
(0114500)
hgbot (developer)
2019-09-10 16:30

 Repository: erp/pmods/org.openbravo.module.aeat347apr.es
Changeset: 73febed8b34596fd47f41a8199e79bb388577b4e
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Wed Sep 04 00:27:13 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/73febed8b34596fd47f41a8199e79bb388577b4e [^]

Fixes issue 41280: AEAT347ReportAPRDao and AEAT347ReportAPR2014Dao is not using
bind-params

Added missing bind-parameters

---
M src/org/openbravo/module/aeat347apr/es/AEAT347ReportAPRDao.java
M src/org/openbravo/module/aeat347apr/es/utility/Utility347.java
M src/org/openbravo/module/aeat347apr/es/v2014/AEAT347ReportAPR2014Dao.java
---
(0114501)
hgbot (developer)
2019-09-10 16:30

 Repository: erp/pmods/org.openbravo.module.aeat347apr.es
Changeset: 3aa9971599f8fbe745df0654de7cee0020d747b7
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Mon Sep 09 09:44:38 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/3aa9971599f8fbe745df0654de7cee0020d747b7 [^]

Related to issue 41280: Applied new Eclipse build-int format

---
M src/org/openbravo/module/aeat347apr/es/AEAT347ReportAPR.java
M src/org/openbravo/module/aeat347apr/es/v2014/AEAT347ReportAPR2014.java
---
(0114502)
hgbot (developer)
2019-09-10 16:30

 Repository: erp/pmods/org.openbravo.module.aeat347apr.es
Changeset: f7adb5f6f4f75d20f3f48d1de80393734482ed52
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Mon Sep 09 10:55:34 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/f7adb5f6f4f75d20f3f48d1de80393734482ed52 [^]

Related to issue 41280: Changed getTaxes and getDocTypes method to List of ids

The methods getTaxes and getDocTypes was changed from String with where-in format
to List of ids to properly set as parameters in the queries.

---
M src/org/openbravo/module/aeat347apr/es/AEAT347ReportAPR.java
M src/org/openbravo/module/aeat347apr/es/AEAT347ReportAPRDao.java
M src/org/openbravo/module/aeat347apr/es/v2014/AEAT347ReportAPR2014.java
M src/org/openbravo/module/aeat347apr/es/v2014/AEAT347ReportAPR2014Dao.java
---
(0114503)
hgbot (developer)
2019-09-10 16:30

 Repository: erp/pmods/org.openbravo.module.aeat347apr.es
Changeset: d1bb5c9df5f54d7e2b05a54f0878d123a9d6bd91
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Sep 10 16:12:48 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/d1bb5c9df5f54d7e2b05a54f0878d123a9d6bd91 [^]

related to issue 41280 code review changes

* manage properly taxrates

---
M src/org/openbravo/module/aeat347apr/es/AEAT347ReportAPRDao.java
M src/org/openbravo/module/aeat347apr/es/v2014/AEAT347ReportAPR2014Dao.java
---
(0114504)
Sandrahuguet (developer)
2019-09-10 16:31

 code review + testing ok

- Issue History
Date Modified Username Field Change
2019-07-04 12:57 shuehner New Issue
2019-07-04 12:57 shuehner Assigned To => Opentix-Test
2019-07-04 12:57 shuehner Relationship added blocks 0038136
2019-07-26 08:20 dmiguelez Assigned To Opentix-Test => collazoandy4
2019-08-01 15:36 collazoandy4 Status new => scheduled
2019-08-05 15:43 collazoandy4 Note Added: 0113817
2019-09-02 16:34 Sandrahuguet Relationship added related to 0041527
2019-09-03 11:00 hgbot Checkin
2019-09-03 11:00 hgbot Note Added: 0114371
2019-09-03 11:00 hgbot Status scheduled => resolved
2019-09-03 11:00 hgbot Resolution open => fixed
2019-09-03 11:00 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/be3a3881a6bf709a4ff772179e5335f4ac4e6d0c [^]
2019-09-03 11:00 hgbot Checkin
2019-09-03 11:00 hgbot Note Added: 0114372
2019-09-03 11:02 Sandrahuguet Review Assigned To => Sandrahuguet
2019-09-03 11:02 Sandrahuguet Note Added: 0114373
2019-09-03 11:02 Sandrahuguet Status resolved => closed
2019-09-03 15:51 Sandrahuguet Status closed => new
2019-09-03 15:51 Sandrahuguet Resolution fixed => open
2019-09-03 16:42 Sandrahuguet Note Added: 0114383
2019-09-09 16:42 collazoandy4 Status new => scheduled
2019-09-10 16:30 hgbot Checkin
2019-09-10 16:30 hgbot Note Added: 0114500
2019-09-10 16:30 hgbot Status scheduled => resolved
2019-09-10 16:30 hgbot Resolution open => fixed
2019-09-10 16:30 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/be3a3881a6bf709a4ff772179e5335f4ac4e6d0c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/73febed8b34596fd47f41a8199e79bb388577b4e [^]
2019-09-10 16:30 hgbot Checkin
2019-09-10 16:30 hgbot Note Added: 0114501
2019-09-10 16:30 hgbot Checkin
2019-09-10 16:30 hgbot Note Added: 0114502
2019-09-10 16:30 hgbot Checkin
2019-09-10 16:30 hgbot Note Added: 0114503
2019-09-10 16:31 Sandrahuguet Note Added: 0114504
2019-09-10 16:31 Sandrahuguet Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker