Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041280Localization Pack: SpainAEAT 347public2019-07-04 12:572019-09-10 16:31
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Support ticket
OBNetwork customer
Regression introduced in release
Summary0041280: AEAT347ReportAPRDao is not using bind-params
DescriptionSeveral method in this class are not using bind-params.

One of those cashAmounts is public but unused apparently so maybe deletion candidate instead.

When fixing please apply new HQL-style to every HQL in this file.

When fixing also fix the deprecation warning related to 'getReadableClientsIncluse' as it is related to the bind-param topic

When fixing please also fix the java11 compile warnings still present in this file.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041527 closed collazoandy4 Localization Pack: Spain Apply HQL style guide to AEAT347ReportAPRDao 
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-04 12:57shuehnerNew Issue
2019-07-04 12:57shuehnerAssigned To => Opentix-Test
2019-07-04 12:57shuehnerRelationship addedblocks 0038136
2019-07-26 08:20dmiguelezAssigned ToOpentix-Test => collazoandy4
2019-08-01 15:36collazoandy4Statusnew => scheduled
2019-08-05 15:43collazoandy4Note Added: 0113817
2019-09-02 16:34SandrahuguetRelationship addedrelated to 0041527
2019-09-03 11:00hgbotCheckin
2019-09-03 11:00hgbotNote Added: 0114371
2019-09-03 11:00hgbotStatusscheduled => resolved
2019-09-03 11:00hgbotResolutionopen => fixed
2019-09-03 11:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/be3a3881a6bf709a4ff772179e5335f4ac4e6d0c [^]
2019-09-03 11:00hgbotCheckin
2019-09-03 11:00hgbotNote Added: 0114372
2019-09-03 11:02SandrahuguetReview Assigned To => Sandrahuguet
2019-09-03 11:02SandrahuguetNote Added: 0114373
2019-09-03 11:02SandrahuguetStatusresolved => closed
2019-09-03 15:51SandrahuguetStatusclosed => new
2019-09-03 15:51SandrahuguetResolutionfixed => open
2019-09-03 16:42SandrahuguetNote Added: 0114383
2019-09-09 16:42collazoandy4Statusnew => scheduled
2019-09-10 16:30hgbotCheckin
2019-09-10 16:30hgbotNote Added: 0114500
2019-09-10 16:30hgbotStatusscheduled => resolved
2019-09-10 16:30hgbotResolutionopen => fixed
2019-09-10 16:30hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/be3a3881a6bf709a4ff772179e5335f4ac4e6d0c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/73febed8b34596fd47f41a8199e79bb388577b4e [^]
2019-09-10 16:30hgbotCheckin
2019-09-10 16:30hgbotNote Added: 0114501
2019-09-10 16:30hgbotCheckin
2019-09-10 16:30hgbotNote Added: 0114502
2019-09-10 16:30hgbotCheckin
2019-09-10 16:30hgbotNote Added: 0114503
2019-09-10 16:31SandrahuguetNote Added: 0114504
2019-09-10 16:31SandrahuguetStatusresolved => closed

Notes
(0113817)
collazoandy4   
2019-08-05 15:43   
Test Plan
  Go to Tax Report Launcher and set:
    Organization: F&B España S.A
    Report: Modelo 347 2014 - Declaracion anual de operaciones con terceras personas
    Accounting Schema: F&B España, S.A US/A/Euro
    Calendar: Calendario España
    Year: 2017
    Period: Anually
    Clic on Input Parameter button
    Fill out the Persona and Teléfono fields
    Clic on Generate Electronic File button and check the process ends without errors

Test Plan
  Repeat the previous test plan for 'Modelo 347 2015 - Declaracion anual de operaciones con terceras personas' report
(0114371)
hgbot   
2019-09-03 11:00   
Repository: erp/pmods/org.openbravo.module.aeat347apr.es
Changeset: be3a3881a6bf709a4ff772179e5335f4ac4e6d0c
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Fri Aug 02 15:50:00 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/be3a3881a6bf709a4ff772179e5335f4ac4e6d0c [^]

Fixes issue 41280: AEAT347ReportAPRDao and AEAT347ReportAPR2014Dao is not using
bind-params

Added missing bind-parameters

---
M src/org/openbravo/module/aeat347apr/es/AEAT347ReportAPRDao.java
M src/org/openbravo/module/aeat347apr/es/utility/Utility347.java
M src/org/openbravo/module/aeat347apr/es/v2014/AEAT347ReportAPR2014Dao.java
---
(0114372)
hgbot   
2019-09-03 11:00   
Repository: erp/pmods/org.openbravo.module.aeat347apr.es
Changeset: d71c6b6e639ff71e2f23eeb8e92e66ec382a4e02
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Sep 03 10:59:55 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/d71c6b6e639ff71e2f23eeb8e92e66ec382a4e02 [^]

related to issue 41280 code review changes

* leave the currency constant
* fix taxRates2

---
M src/org/openbravo/module/aeat347apr/es/AEAT347ReportAPRDao.java
M src/org/openbravo/module/aeat347apr/es/v2014/AEAT347ReportAPR2014Dao.java
---
(0114373)
Sandrahuguet   
2019-09-03 11:02   
code review + testing ok
(0114383)
Sandrahuguet   
2019-09-03 16:42   
backout changesets:
https://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/3bea2095c6c9 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/98bc5ec921b0 [^]
(0114500)
hgbot   
2019-09-10 16:30   
Repository: erp/pmods/org.openbravo.module.aeat347apr.es
Changeset: 73febed8b34596fd47f41a8199e79bb388577b4e
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Wed Sep 04 00:27:13 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/73febed8b34596fd47f41a8199e79bb388577b4e [^]

Fixes issue 41280: AEAT347ReportAPRDao and AEAT347ReportAPR2014Dao is not using
bind-params

Added missing bind-parameters

---
M src/org/openbravo/module/aeat347apr/es/AEAT347ReportAPRDao.java
M src/org/openbravo/module/aeat347apr/es/utility/Utility347.java
M src/org/openbravo/module/aeat347apr/es/v2014/AEAT347ReportAPR2014Dao.java
---
(0114501)
hgbot   
2019-09-10 16:30   
Repository: erp/pmods/org.openbravo.module.aeat347apr.es
Changeset: 3aa9971599f8fbe745df0654de7cee0020d747b7
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Mon Sep 09 09:44:38 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/3aa9971599f8fbe745df0654de7cee0020d747b7 [^]

Related to issue 41280: Applied new Eclipse build-int format

---
M src/org/openbravo/module/aeat347apr/es/AEAT347ReportAPR.java
M src/org/openbravo/module/aeat347apr/es/v2014/AEAT347ReportAPR2014.java
---
(0114502)
hgbot   
2019-09-10 16:30   
Repository: erp/pmods/org.openbravo.module.aeat347apr.es
Changeset: f7adb5f6f4f75d20f3f48d1de80393734482ed52
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Mon Sep 09 10:55:34 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/f7adb5f6f4f75d20f3f48d1de80393734482ed52 [^]

Related to issue 41280: Changed getTaxes and getDocTypes method to List of ids

The methods getTaxes and getDocTypes was changed from String with where-in format
to List of ids to properly set as parameters in the queries.

---
M src/org/openbravo/module/aeat347apr/es/AEAT347ReportAPR.java
M src/org/openbravo/module/aeat347apr/es/AEAT347ReportAPRDao.java
M src/org/openbravo/module/aeat347apr/es/v2014/AEAT347ReportAPR2014.java
M src/org/openbravo/module/aeat347apr/es/v2014/AEAT347ReportAPR2014Dao.java
---
(0114503)
hgbot   
2019-09-10 16:30   
Repository: erp/pmods/org.openbravo.module.aeat347apr.es
Changeset: d1bb5c9df5f54d7e2b05a54f0878d123a9d6bd91
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Sep 10 16:12:48 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat347apr.es/rev/d1bb5c9df5f54d7e2b05a54f0878d123a9d6bd91 [^]

related to issue 41280 code review changes

* manage properly taxrates

---
M src/org/openbravo/module/aeat347apr/es/AEAT347ReportAPRDao.java
M src/org/openbravo/module/aeat347apr/es/v2014/AEAT347ReportAPR2014Dao.java
---
(0114504)
Sandrahuguet   
2019-09-10 16:31   
code review + testing ok