Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041279
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] Web POSminorhave not tried2019-07-04 12:502019-07-26 08:21
ReportercaristuView Statuspublic 
Assigned Toalostale 
PriorityhighResolutionfixedFixed in VersionRR19Q4
StatusclosedFix in branchFixed in SCM revision0f1d4a743db9
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0041279: Remove dependency of ob-arithmetic with underscore

DescriptionCurrently the code of ob-arithmetic depends on the underscore library. It would be nice to remove this dependency just in case any application (like the new discounts engine) needs to use ob-arithmetic, would not require to have a dependency also with underscore.
Steps To ReproduceIn description
Proposed SolutionReplace the usage of underscore _isNumber[1] function in ob-arithmetic with an internal function with the same implementation.

[1] https://github.com/jashkenas/underscore/blob/master/underscore.js#L1326 [^]
TagsNo tags attached.
Attached Filesdiff file icon 41279.diff [^] (966 bytes) 2019-07-04 13:19 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0042408 closedcaristu Make ob-localStorage not depend on underscore 

-  Notes
(0113618)
hgbot (developer)
2019-07-24 13:41

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0f1d4a743db938c0f9493bd3b941cd5d989ad98a
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Jul 08 14:14:48 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0f1d4a743db938c0f9493bd3b941cd5d989ad98a [^]

fixed issue 41279: removed dependency of ob-arithmetic with underscore

---
M web/org.openbravo.mobile.core/source/utils/ob-arithmetic.js
---
(0113620)
hgbot (developer)
2019-07-24 15:32

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 61106031a1cb8e5b2c2b038b847d95c8f50839ca
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 24 15:32:32 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/61106031a1cb8e5b2c2b038b847d95c8f50839ca [^]

realted with issue 41279: removed missing occurrence

---
M web/org.openbravo.mobile.core/source/utils/ob-arithmetic.js
---
(0113655)
caristu (manager)
2019-07-26 08:21

 Reviewed + tested OK.

- Issue History
Date Modified Username Field Change
2019-07-04 12:50 caristu New Issue
2019-07-04 12:50 caristu Assigned To => Retail
2019-07-04 12:50 caristu Triggers an Emergency Pack => No
2019-07-04 12:50 caristu Proposed Solution updated
2019-07-04 13:19 caristu File Added: 41279.diff
2019-07-04 13:19 caristu Description Updated View Revisions
2019-07-24 13:41 hgbot Checkin
2019-07-24 13:41 hgbot Note Added: 0113618
2019-07-24 13:41 hgbot Status new => resolved
2019-07-24 13:41 hgbot Resolution open => fixed
2019-07-24 13:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0f1d4a743db938c0f9493bd3b941cd5d989ad98a [^]
2019-07-24 13:42 alostale Assigned To Retail => alostale
2019-07-24 13:42 alostale Review Assigned To => caristu
2019-07-24 15:32 hgbot Checkin
2019-07-24 15:32 hgbot Note Added: 0113620
2019-07-26 08:21 caristu Note Added: 0113655
2019-07-26 08:21 caristu Status resolved => closed
2019-07-26 08:21 caristu Fixed in Version => RR19Q4
2019-11-26 17:19 caristu Relationship added related to 0042408

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker