Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041279Retail ModulesWeb POSpublic2019-07-04 12:502019-07-26 08:21
Reportercaristu 
Assigned Toalostale 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q4 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041279: Remove dependency of ob-arithmetic with underscore
DescriptionCurrently the code of ob-arithmetic depends on the underscore library. It would be nice to remove this dependency just in case any application (like the new discounts engine) needs to use ob-arithmetic, would not require to have a dependency also with underscore.
Steps To ReproduceIn description
Proposed SolutionReplace the usage of underscore _isNumber[1] function in ob-arithmetic with an internal function with the same implementation.

[1] https://github.com/jashkenas/underscore/blob/master/underscore.js#L1326 [^]
Additional Information
TagsNo tags attached.
Relationships
related to defect 0042408 closed caristu Make ob-localStorage not depend on underscore 
Attached Filesdiff 41279.diff (966) 2019-07-04 13:19
https://issues.openbravo.com/file_download.php?file_id=13086&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-07-04 12:50caristuNew Issue
2019-07-04 12:50caristuAssigned To => Retail
2019-07-04 12:50caristuTriggers an Emergency Pack => No
2019-07-04 12:50caristuProposed Solution updated
2019-07-04 13:19caristuFile Added: 41279.diff
2019-07-04 13:19caristuDescription Updatedbug_revision_view_page.php?rev_id=19036#r19036
2019-07-24 13:41hgbotCheckin
2019-07-24 13:41hgbotNote Added: 0113618
2019-07-24 13:41hgbotStatusnew => resolved
2019-07-24 13:41hgbotResolutionopen => fixed
2019-07-24 13:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0f1d4a743db938c0f9493bd3b941cd5d989ad98a [^]
2019-07-24 13:42alostaleAssigned ToRetail => alostale
2019-07-24 13:42alostaleReview Assigned To => caristu
2019-07-24 15:32hgbotCheckin
2019-07-24 15:32hgbotNote Added: 0113620
2019-07-26 08:21caristuNote Added: 0113655
2019-07-26 08:21caristuStatusresolved => closed
2019-07-26 08:21caristuFixed in Version => RR19Q4
2019-11-26 17:19caristuRelationship addedrelated to 0042408

Notes
(0113618)
hgbot   
2019-07-24 13:41   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0f1d4a743db938c0f9493bd3b941cd5d989ad98a
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Jul 08 14:14:48 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0f1d4a743db938c0f9493bd3b941cd5d989ad98a [^]

fixed issue 41279: removed dependency of ob-arithmetic with underscore

---
M web/org.openbravo.mobile.core/source/utils/ob-arithmetic.js
---
(0113620)
hgbot   
2019-07-24 15:32   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 61106031a1cb8e5b2c2b038b847d95c8f50839ca
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 24 15:32:32 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/61106031a1cb8e5b2c2b038b847d95c8f50839ca [^]

realted with issue 41279: removed missing occurrence

---
M web/org.openbravo.mobile.core/source/utils/ob-arithmetic.js
---
(0113655)
caristu   
2019-07-26 08:21   
Reviewed + tested OK.