Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0041271 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2019-07-04 10:28 | 2019-07-11 18:56 | |||
| Reporter | asiermartirena | View Status | public | |||||
| Assigned To | asiermartirena | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | RR19Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | d4e6fefdfdc0 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | adrianromero | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0041271: Layaways can generate shipments when the synchronization process have some failure | |||||||
| Description | When a ticket is synchronized using the 'Done' button and the synchronization flow is stopped because the there's some problem in a hook or because the flow is stopped for any other reason, the property that tells that the ticket is being completed is not removed. In that case, if the user then decides to remove a payment and converts the ticket in a layaway and the layaway is synchronized, it is delivered (even if the ticket was a layaway). This also occurs in pay open tickets. | |||||||
| Steps To Reproduce | Add a break point in the OBPOS_PreOrderSave hook. Synchronize a ticket using the 'Done' button. In the break point, stop the flow adding an args.cancellation. Remove the payment and convert the ticket to a layaway. Synchronize using the 'Layaway' button. Don't stop the flow in this case. Open the created layaway --> Realize that is a receipt, and that it has been delivered. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0113212) hgbot (developer) 2019-07-08 13:49 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: d4e6fefdfdc09cd8c814f2b5c62823404ae33f52 Author: Asier Martirena <asier.martirena <at> openbravo.com> Date: Mon Jul 08 10:51:08 2019 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d4e6fefdfdc09cd8c814f2b5c62823404ae33f52 [^] Fixed issue 41271: Layaways can generate shipments when the synchronization process have some failure Now, the 'completeTicket' property is set once the drawer has been closed, to avoid the possibility to set, close the drawer and then modify the ticket before synchronizing. Now the property will be set when the ticket is going to be synchronized. In addition, if the flow is now stopped, the property is unset, and will be set again if the ticket is synchronized again in the correct conditions. --- M web/org.openbravo.retail.posterminal/js/data/dataordersave.js M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
(0113243) adrianromero (manager) 2019-07-09 14:07 |
Verified |
|
(0113301) guilleaer (manager) 2019-07-11 18:56 |
reclosed |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-07-04 10:28 | asiermartirena | New Issue | |
| 2019-07-04 10:28 | asiermartirena | Assigned To | => asiermartirena |
| 2019-07-04 10:28 | asiermartirena | Triggers an Emergency Pack | => No |
| 2019-07-08 13:49 | hgbot | Checkin | |
| 2019-07-08 13:49 | hgbot | Note Added: 0113212 | |
| 2019-07-08 13:49 | hgbot | Status | new => resolved |
| 2019-07-08 13:49 | hgbot | Resolution | open => fixed |
| 2019-07-08 13:49 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d4e6fefdfdc09cd8c814f2b5c62823404ae33f52 [^] |
| 2019-07-09 14:07 | adrianromero | Review Assigned To | => adrianromero |
| 2019-07-09 14:07 | adrianromero | Note Added: 0113243 | |
| 2019-07-09 14:07 | adrianromero | Status | resolved => closed |
| 2019-07-09 14:07 | adrianromero | Fixed in Version | => RR19Q4 |
| 2019-07-09 14:09 | adrianromero | Relationship added | related to 0041196 |
| 2019-07-11 15:32 | hgbot | Checkin | |
| 2019-07-11 15:32 | hgbot | Note Added: 0113286 | |
| 2019-07-11 15:32 | hgbot | Status | closed => resolved |
| 2019-07-11 15:32 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d4e6fefdfdc09cd8c814f2b5c62823404ae33f52 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-discounts/rev/d4e6fefdfdc09cd8c814f2b5c62823404ae33f52 [^] |
| 2019-07-11 18:56 | guilleaer | Note Deleted: 0113286 | |
| 2019-07-11 18:56 | guilleaer | Note Added: 0113301 | |
| 2019-07-11 18:56 | guilleaer | Status | resolved => closed |
| 2020-01-31 16:25 | guilleaer | Relationship added | has duplicate 0041368 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |