Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041271Retail ModulesWeb POSpublic2019-07-04 10:282019-07-11 18:56
Reporterasiermartirena 
Assigned Toasiermartirena 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q4 
Merge Request Status
Review Assigned Toadrianromero
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041271: Layaways can generate shipments when the synchronization process have some failure
DescriptionWhen a ticket is synchronized using the 'Done' button and the synchronization flow is stopped because the there's some problem in a hook or because the flow is stopped for any other reason, the property that tells that the ticket is being completed is not removed. In that case, if the user then decides to remove a payment and converts the ticket in a layaway and the layaway is synchronized, it is delivered (even if the ticket was a layaway).
This also occurs in pay open tickets.
Steps To ReproduceAdd a break point in the OBPOS_PreOrderSave hook.
Synchronize a ticket using the 'Done' button.
In the break point, stop the flow adding an args.cancellation.
Remove the payment and convert the ticket to a layaway.
Synchronize using the 'Layaway' button. Don't stop the flow in this case.
Open the created layaway --> Realize that is a receipt, and that it has been delivered.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0041368 closed ranjith_qualiantech_com [19Q3] Attempting to pay a Layaway results in the order being saved as a ticket 
related to defect 0041196 closed asiermartirena When the multi order process fails in the preOrderSave hook, it is not correctly managed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-04 10:28asiermartirenaNew Issue
2019-07-04 10:28asiermartirenaAssigned To => asiermartirena
2019-07-04 10:28asiermartirenaOBNetwork customer => No
2019-07-04 10:28asiermartirenaTriggers an Emergency Pack => No
2019-07-08 13:49hgbotCheckin
2019-07-08 13:49hgbotNote Added: 0113212
2019-07-08 13:49hgbotStatusnew => resolved
2019-07-08 13:49hgbotResolutionopen => fixed
2019-07-08 13:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d4e6fefdfdc09cd8c814f2b5c62823404ae33f52 [^]
2019-07-09 14:07adrianromeroReview Assigned To => adrianromero
2019-07-09 14:07adrianromeroNote Added: 0113243
2019-07-09 14:07adrianromeroStatusresolved => closed
2019-07-09 14:07adrianromeroFixed in Version => RR19Q4
2019-07-09 14:09adrianromeroRelationship addedrelated to 0041196
2019-07-11 15:32hgbotCheckin
2019-07-11 15:32hgbotNote Added: 0113286
2019-07-11 15:32hgbotStatusclosed => resolved
2019-07-11 15:32hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d4e6fefdfdc09cd8c814f2b5c62823404ae33f52 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal-discounts/rev/d4e6fefdfdc09cd8c814f2b5c62823404ae33f52 [^]
2019-07-11 18:56guilleaerNote Deleted: 0113286
2019-07-11 18:56guilleaerNote Added: 0113301
2019-07-11 18:56guilleaerStatusresolved => closed
2020-01-31 16:25guilleaerRelationship addedhas duplicate 0041368

Notes
(0113212)
hgbot   
2019-07-08 13:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d4e6fefdfdc09cd8c814f2b5c62823404ae33f52
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Mon Jul 08 10:51:08 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d4e6fefdfdc09cd8c814f2b5c62823404ae33f52 [^]

Fixed issue 41271: Layaways can generate shipments when the synchronization process have some failure

Now, the 'completeTicket' property is set once the drawer has been closed, to avoid the possibility to set, close the drawer and then modify the ticket before synchronizing. Now the property will be set when the ticket is going to be synchronized.
In addition, if the flow is now stopped, the property is unset, and will be set again if the ticket is synchronized again in the correct conditions.

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0113243)
adrianromero   
2019-07-09 14:07   
Verified
(0113301)
guilleaer   
2019-07-11 18:56   
reclosed