Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0041249 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] 00. Application dictionary | major | have not tried | 2019-07-02 16:01 | 2019-07-09 10:36 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 61fccdd57a53 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR19Q2.1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | jarmendariz | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0041249: ADTreeDatasourceService.{getNodeChildenQuery,nodeHasChildren, nodeConformsToWhereClause) are not using bind-params | |||||||
| Description | Those functions are not using bind-params. when fixing please apply new HQL-style to all 3 HQL's in the file | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0113230) hgbot (developer) 2019-07-09 09:11 |
Repository: erp/backports/3.0PR19Q2.1 Changeset: 697566caa6a00fd59cf9b7ab2e2235d9b60847d1 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Tue Jul 09 09:01:57 2019 +0200 URL: http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/697566caa6a00fd59cf9b7ab2e2235d9b60847d1 [^] related to issue 41249: HQL style in ADTreeDatasourceService Don't use StringBuilder for String concatenation Some other small changes --- M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ADTreeDatasourceService.java --- |
|
(0113231) hgbot (developer) 2019-07-09 09:11 |
Repository: erp/backports/3.0PR19Q2.1 Changeset: 61fccdd57a5369550a076e067ce0719444f5a4ab Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Tue Jul 09 09:10:53 2019 +0200 URL: http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/61fccdd57a5369550a076e067ce0719444f5a4ab [^] fixed bug 41249: use bind parameters in ADTreeDatasourceService * Use parameter in query in getNodeChildrenQuery method where possible * Do not use deprecated OBDal.getReadableOrganizationsInClause method * Properly escape paremeter values in clasues coming from AD --- M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ADTreeDatasourceService.java M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java --- |
|
(0113237) jarmendariz (developer) 2019-07-09 10:36 |
Reviewed |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-07-03 15:26 | alostale | Type | defect => backport |
| 2019-07-03 15:26 | alostale | Target Version | => 3.0PR19Q2.1 |
| 2019-07-09 09:11 | hgbot | Checkin | |
| 2019-07-09 09:11 | hgbot | Note Added: 0113230 | |
| 2019-07-09 09:11 | hgbot | Checkin | |
| 2019-07-09 09:11 | hgbot | Note Added: 0113231 | |
| 2019-07-09 09:11 | hgbot | Status | scheduled => resolved |
| 2019-07-09 09:11 | hgbot | Resolution | open => fixed |
| 2019-07-09 09:11 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/61fccdd57a5369550a076e067ce0719444f5a4ab [^] |
| 2019-07-09 09:11 | alostale | Assigned To | platform => alostale |
| 2019-07-09 09:29 | alostale | Review Assigned To | caristu => jarmendariz |
| 2019-07-09 10:36 | jarmendariz | Note Added: 0113237 | |
| 2019-07-09 10:36 | jarmendariz | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |