Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041249Openbravo ERP00. Application dictionarypublic2019-07-02 16:012019-07-09 10:36
Reportershuehner 
Assigned Toalostale 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q2.1Fixed in Version 
Merge Request Status
Review Assigned Tojarmendariz
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041249: ADTreeDatasourceService.{getNodeChildenQuery,nodeHasChildren, nodeConformsToWhereClause) are not using bind-params
DescriptionThose functions are not using bind-params.


when fixing please apply new HQL-style to all 3 HQL's in the file
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00412393.0PR19Q4 closed alostale ADTreeDatasourceService.{getNodeChildenQuery,nodeHasChildren, nodeConformsToWhereClause) are not using bind-params 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-03 15:26alostaleTypedefect => backport
2019-07-03 15:26alostaleTarget Version => 3.0PR19Q2.1
2019-07-09 09:11hgbotCheckin
2019-07-09 09:11hgbotNote Added: 0113230
2019-07-09 09:11hgbotCheckin
2019-07-09 09:11hgbotNote Added: 0113231
2019-07-09 09:11hgbotStatusscheduled => resolved
2019-07-09 09:11hgbotResolutionopen => fixed
2019-07-09 09:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/61fccdd57a5369550a076e067ce0719444f5a4ab [^]
2019-07-09 09:11alostaleAssigned Toplatform => alostale
2019-07-09 09:29alostaleReview Assigned Tocaristu => jarmendariz
2019-07-09 10:36jarmendarizNote Added: 0113237
2019-07-09 10:36jarmendarizStatusresolved => closed

Notes
(0113230)
hgbot   
2019-07-09 09:11   
Repository: erp/backports/3.0PR19Q2.1
Changeset: 697566caa6a00fd59cf9b7ab2e2235d9b60847d1
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jul 09 09:01:57 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/697566caa6a00fd59cf9b7ab2e2235d9b60847d1 [^]

related to issue 41249: HQL style in ADTreeDatasourceService

  Don't use StringBuilder for String concatenation
  Some other small changes

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ADTreeDatasourceService.java
---
(0113231)
hgbot   
2019-07-09 09:11   
Repository: erp/backports/3.0PR19Q2.1
Changeset: 61fccdd57a5369550a076e067ce0719444f5a4ab
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jul 09 09:10:53 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/61fccdd57a5369550a076e067ce0719444f5a4ab [^]

fixed bug 41249: use bind parameters in ADTreeDatasourceService

  * Use parameter in query in getNodeChildrenQuery method where possible
  * Do not use deprecated OBDal.getReadableOrganizationsInClause method
  * Properly escape paremeter values in clasues coming from AD

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ADTreeDatasourceService.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
---
(0113237)
jarmendariz   
2019-07-09 10:36   
Reviewed