Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0041200 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2019-06-28 09:39 | 2019-07-01 11:57 | |||
| Reporter | jarmendariz | View Status | public | |||||
| Assigned To | jarmendariz | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR19Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | d7e6c0efc35e | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | Pre packaging ( pi ) | |||||||
| Regression date | ||||||||
| Regression introduced in release | pi | |||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0041200: Javascript formatting Mercurial hook script does not support parameters | |||||||
| Description | In the older version of the hook, a parameter could be passed to fix formatting of javascript files instead of only performing a check. [hooks] pre-commit = ./modules/org.openbravo.client.kernel/jsbeautify/jscheck-btfy-hg replace | |||||||
| Steps To Reproduce | 1- Change formatting of some .js files 2- Add the -w flag to jsformatter pre-commit hook: [hooks] pre-commit = ./modules/org.openbravo.client.kernel/jsformatter/jsformatter-hg -w 3- Commit the changes 4- Commit will be rejected by the formatter and no fix were performed. | |||||||
| Proposed Solution | Support the -w flag in jsformatter-hg and jsformatter-hg-hook to preserve the behavior of the old script. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0113106) hgbot (developer) 2019-06-28 13:28 |
Repository: erp/devel/pi Changeset: d7e6c0efc35e67006250edd9b483efdf28ddc518 Author: Javier Armendáriz <javier.armendariz <at> openbravo.com> Date: Fri Jun 28 11:11:46 2019 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/d7e6c0efc35e67006250edd9b483efdf28ddc518 [^] Fixed issue 41200: JSFormatter hg hook does not support arguments Added support to a -w flag in JSFormatter script to support autofixing formatting issues when commiting a changeset. This is supported to both jsformatter-hg and jsformatter-hg-hook. --- M modules/org.openbravo.client.kernel/jsformatter/jsformatter-hg M modules/org.openbravo.client.kernel/jsformatter/jsformatter-hg-hook --- |
|
(0113107) hgbot (developer) 2019-06-28 13:45 |
Repository: erp/devel/pi Changeset: 0b2991dc0bce9546eafdc260db4a297594e44c32 Author: Javier Armendáriz <javier.armendariz <at> openbravo.com> Date: Fri Jun 28 13:45:21 2019 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/0b2991dc0bce9546eafdc260db4a297594e44c32 [^] Related to issue 41200: Adding quotes to optind operation --- M modules/org.openbravo.client.kernel/jsformatter/jsformatter M modules/org.openbravo.client.kernel/jsformatter/jsformatter-hg M modules/org.openbravo.client.kernel/jsformatter/jsformatter-hg-hook M modules/org.openbravo.client.kernel/jslint/jslint --- |
|
(0113108) caristu (developer) 2019-06-28 13:53 |
Reviewed + tested OK. |
|
(0113115) hudsonbot (developer) 2019-07-01 11:57 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/11de0dab22bf [^] Maturity status: Test |
|
(0113116) hudsonbot (developer) 2019-07-01 11:57 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/11de0dab22bf [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2019-06-28 09:39 | jarmendariz | New Issue | |
| 2019-06-28 09:39 | jarmendariz | Assigned To | => jarmendariz |
| 2019-06-28 09:39 | jarmendariz | Modules | => Core |
| 2019-06-28 09:39 | jarmendariz | Regression level | => Pre packaging ( pi ) |
| 2019-06-28 09:39 | jarmendariz | Regression introduced in release | => pi |
| 2019-06-28 09:39 | jarmendariz | Triggers an Emergency Pack | => No |
| 2019-06-28 09:39 | jarmendariz | Status | new => scheduled |
| 2019-06-28 09:39 | jarmendariz | Relationship added | caused by 0039983 |
| 2019-06-28 13:28 | hgbot | Checkin | |
| 2019-06-28 13:28 | hgbot | Note Added: 0113106 | |
| 2019-06-28 13:28 | hgbot | Status | scheduled => resolved |
| 2019-06-28 13:28 | hgbot | Resolution | open => fixed |
| 2019-06-28 13:28 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/d7e6c0efc35e67006250edd9b483efdf28ddc518 [^] |
| 2019-06-28 13:45 | hgbot | Checkin | |
| 2019-06-28 13:45 | hgbot | Note Added: 0113107 | |
| 2019-06-28 13:48 | caristu | Steps to Reproduce Updated | View Revisions |
| 2019-06-28 13:53 | caristu | Review Assigned To | => caristu |
| 2019-06-28 13:53 | caristu | Note Added: 0113108 | |
| 2019-06-28 13:53 | caristu | Status | resolved => closed |
| 2019-06-28 13:53 | caristu | Fixed in Version | => 3.0PR19Q3 |
| 2019-07-01 11:57 | hudsonbot | Checkin | |
| 2019-07-01 11:57 | hudsonbot | Note Added: 0113115 | |
| 2019-07-01 11:57 | hudsonbot | Checkin | |
| 2019-07-01 11:57 | hudsonbot | Note Added: 0113116 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |