Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041200Openbravo ERPA. Platformpublic2019-06-28 09:392019-07-01 11:57
Reporterjarmendariz 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date
Regression introduced in releasepi
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041200: Javascript formatting Mercurial hook script does not support parameters
DescriptionIn the older version of the hook, a parameter could be passed to fix formatting of javascript files instead of only performing a check.

[hooks]
pre-commit = ./modules/org.openbravo.client.kernel/jsbeautify/jscheck-btfy-hg replace
Steps To Reproduce1- Change formatting of some .js files
2- Add the -w flag to jsformatter pre-commit hook:

[hooks]
pre-commit = ./modules/org.openbravo.client.kernel/jsformatter/jsformatter-hg -w

3- Commit the changes
4- Commit will be rejected by the formatter and no fix were performed.
Proposed SolutionSupport the -w flag in jsformatter-hg and jsformatter-hg-hook to preserve the behavior of the old script.
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0039983 closed jarmendariz Upgrade javascript linter and formatter 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-06-28 09:39jarmendarizNew Issue
2019-06-28 09:39jarmendarizAssigned To => jarmendariz
2019-06-28 09:39jarmendarizModules => Core
2019-06-28 09:39jarmendarizRegression level => Pre packaging ( pi )
2019-06-28 09:39jarmendarizRegression introduced in release => pi
2019-06-28 09:39jarmendarizTriggers an Emergency Pack => No
2019-06-28 09:39jarmendarizStatusnew => scheduled
2019-06-28 09:39jarmendarizRelationship addedcaused by 0039983
2019-06-28 13:28hgbotCheckin
2019-06-28 13:28hgbotNote Added: 0113106
2019-06-28 13:28hgbotStatusscheduled => resolved
2019-06-28 13:28hgbotResolutionopen => fixed
2019-06-28 13:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d7e6c0efc35e67006250edd9b483efdf28ddc518 [^]
2019-06-28 13:45hgbotCheckin
2019-06-28 13:45hgbotNote Added: 0113107
2019-06-28 13:48caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19010#r19010
2019-06-28 13:53caristuReview Assigned To => caristu
2019-06-28 13:53caristuNote Added: 0113108
2019-06-28 13:53caristuStatusresolved => closed
2019-06-28 13:53caristuFixed in Version => 3.0PR19Q3
2019-07-01 11:57hudsonbotCheckin
2019-07-01 11:57hudsonbotNote Added: 0113115
2019-07-01 11:57hudsonbotCheckin
2019-07-01 11:57hudsonbotNote Added: 0113116

Notes
(0113106)
hgbot   
2019-06-28 13:28   
Repository: erp/devel/pi
Changeset: d7e6c0efc35e67006250edd9b483efdf28ddc518
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Jun 28 11:11:46 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d7e6c0efc35e67006250edd9b483efdf28ddc518 [^]

Fixed issue 41200: JSFormatter hg hook does not support arguments

Added support to a -w flag in JSFormatter script to support autofixing
formatting issues when commiting a changeset. This is supported to both
jsformatter-hg and jsformatter-hg-hook.

---
M modules/org.openbravo.client.kernel/jsformatter/jsformatter-hg
M modules/org.openbravo.client.kernel/jsformatter/jsformatter-hg-hook
---
(0113107)
hgbot   
2019-06-28 13:45   
Repository: erp/devel/pi
Changeset: 0b2991dc0bce9546eafdc260db4a297594e44c32
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Jun 28 13:45:21 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0b2991dc0bce9546eafdc260db4a297594e44c32 [^]

Related to issue 41200: Adding quotes to optind operation

---
M modules/org.openbravo.client.kernel/jsformatter/jsformatter
M modules/org.openbravo.client.kernel/jsformatter/jsformatter-hg
M modules/org.openbravo.client.kernel/jsformatter/jsformatter-hg-hook
M modules/org.openbravo.client.kernel/jslint/jslint
---
(0113108)
caristu   
2019-06-28 13:53   
Reviewed + tested OK.
(0113115)
hudsonbot   
2019-07-01 11:57   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/11de0dab22bf [^]
Maturity status: Test
(0113116)
hudsonbot   
2019-07-01 11:57   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/11de0dab22bf [^]
Maturity status: Test