Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0041193
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Localization Pack: Spain] Multi Dimensional Tax Reportminorhave not tried2019-06-27 13:142019-06-27 15:55
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiondc339de3ee7d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Regression introduced in release
Summary

0041193: Stop calling deprecated ReportingUtils.getTranslatedJasperReport method variant

DescriptionThis module still calls the deprecated method variant with following parameters:

ConnectionProvider conn, String reportName,
      String language, String baseDesignPath

which internally calls a simplified version anyway with those:

ConnectionProvider conn, String reportName,
      String language

the module should be fixed to call that 2nd variant directly.
Steps To Reproduce-
Proposed Solution-
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0041195 closedshuehner Stop calling deprecated ReportingUtils.getTranslatedJasperReport method variant 

-  Notes
(0113052)
hgbot (developer)
2019-06-27 13:16

Repository: erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30
Changeset: dc339de3ee7dc8b8a00a31f2e97f7567593211dc
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jun 27 13:16:01 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30/rev/dc339de3ee7dc8b8a00a31f2e97f7567593211dc [^]

Fixed 41193. Fix deprecation warning by calling new method.

getTranslatedJasperReport lost is baseDesignPath parameter and the old method
having it just calls the variant without.

Fix the module to call the new non-deprecated version directly.

---
M src/org/openbravo/module/invoiceTaxReportEnhanced30/ad_reports/OBMTR30_InvoiceTaxReportJR.java
---
(0113053)
shuehner (administrator)
2019-06-27 13:20

Note: That new method already existed in 18Q4 release. So module dependency (currently at 18Q4.1) is not required to be raised because of this change.
(0113059)
hgbot (developer)
2019-06-27 15:35

Repository: erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30
Changeset: 930db706467383f61939e26dada43de7e57efde0
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jun 27 15:34:58 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30/rev/930db706467383f61939e26dada43de7e57efde0 [^]

Related to issue 41193: Updated copyright year

---
M src/org/openbravo/module/invoiceTaxReportEnhanced30/ad_reports/OBMTR30_InvoiceTaxReportJR.java
---
(0113062)
hgbot (developer)
2019-06-27 15:49

Repository: erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30
Changeset: 4874a329b69358df9da93d2987181b9a81109327
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jun 27 15:49:50 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30/rev/4874a329b69358df9da93d2987181b9a81109327 [^]

Related to issue 41193: Updated module's update info

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0113064)
vmromanos (manager)
2019-06-27 15:55

Code review + testing OK

- Issue History
Date Modified Username Field Change
2019-06-27 13:14 shuehner New Issue
2019-06-27 13:14 shuehner Assigned To => shuehner
2019-06-27 13:16 hgbot Checkin
2019-06-27 13:16 hgbot Note Added: 0113052
2019-06-27 13:16 hgbot Status new => resolved
2019-06-27 13:16 hgbot Resolution open => fixed
2019-06-27 13:16 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30/rev/dc339de3ee7dc8b8a00a31f2e97f7567593211dc [^]
2019-06-27 13:20 shuehner Note Added: 0113053
2019-06-27 15:35 hgbot Checkin
2019-06-27 15:35 hgbot Note Added: 0113059
2019-06-27 15:49 hgbot Checkin
2019-06-27 15:49 hgbot Note Added: 0113062
2019-06-27 15:52 vmromanos Issue cloned 0041195
2019-06-27 15:52 vmromanos Relationship added related to 0041195
2019-06-27 15:55 vmromanos Review Assigned To => vmromanos
2019-06-27 15:55 vmromanos Note Added: 0113064
2019-06-27 15:55 vmromanos Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker