Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041193Localization Pack: SpainMulti Dimensional Tax Reportpublic2019-06-27 13:142019-06-27 15:55
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket
OBNetwork customer
Regression introduced in release
Summary0041193: Stop calling deprecated ReportingUtils.getTranslatedJasperReport method variant
DescriptionThis module still calls the deprecated method variant with following parameters:

ConnectionProvider conn, String reportName,
      String language, String baseDesignPath

which internally calls a simplified version anyway with those:

ConnectionProvider conn, String reportName,
      String language

the module should be fixed to call that 2nd variant directly.
Steps To Reproduce-
Proposed Solution-
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041195 closed shuehner Stop calling deprecated ReportingUtils.getTranslatedJasperReport method variant 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-06-27 13:14shuehnerNew Issue
2019-06-27 13:14shuehnerAssigned To => shuehner
2019-06-27 13:16hgbotCheckin
2019-06-27 13:16hgbotNote Added: 0113052
2019-06-27 13:16hgbotStatusnew => resolved
2019-06-27 13:16hgbotResolutionopen => fixed
2019-06-27 13:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30/rev/dc339de3ee7dc8b8a00a31f2e97f7567593211dc [^]
2019-06-27 13:20shuehnerNote Added: 0113053
2019-06-27 15:35hgbotCheckin
2019-06-27 15:35hgbotNote Added: 0113059
2019-06-27 15:49hgbotCheckin
2019-06-27 15:49hgbotNote Added: 0113062
2019-06-27 15:52vmromanosIssue cloned0041195
2019-06-27 15:52vmromanosRelationship addedrelated to 0041195
2019-06-27 15:55vmromanosReview Assigned To => vmromanos
2019-06-27 15:55vmromanosNote Added: 0113064
2019-06-27 15:55vmromanosStatusresolved => closed

Notes
(0113052)
hgbot   
2019-06-27 13:16   
Repository: erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30
Changeset: dc339de3ee7dc8b8a00a31f2e97f7567593211dc
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jun 27 13:16:01 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30/rev/dc339de3ee7dc8b8a00a31f2e97f7567593211dc [^]

Fixed 41193. Fix deprecation warning by calling new method.

getTranslatedJasperReport lost is baseDesignPath parameter and the old method
having it just calls the variant without.

Fix the module to call the new non-deprecated version directly.

---
M src/org/openbravo/module/invoiceTaxReportEnhanced30/ad_reports/OBMTR30_InvoiceTaxReportJR.java
---
(0113053)
shuehner   
2019-06-27 13:20   
Note: That new method already existed in 18Q4 release. So module dependency (currently at 18Q4.1) is not required to be raised because of this change.
(0113059)
hgbot   
2019-06-27 15:35   
Repository: erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30
Changeset: 930db706467383f61939e26dada43de7e57efde0
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jun 27 15:34:58 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30/rev/930db706467383f61939e26dada43de7e57efde0 [^]

Related to issue 41193: Updated copyright year

---
M src/org/openbravo/module/invoiceTaxReportEnhanced30/ad_reports/OBMTR30_InvoiceTaxReportJR.java
---
(0113062)
hgbot   
2019-06-27 15:49   
Repository: erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30
Changeset: 4874a329b69358df9da93d2987181b9a81109327
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jun 27 15:49:50 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30/rev/4874a329b69358df9da93d2987181b9a81109327 [^]

Related to issue 41193: Updated module's update info

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0113064)
vmromanos   
2019-06-27 15:55   
Code review + testing OK