Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0041015
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Resource and Reservation Managementminoralways2019-06-03 18:032019-06-06 08:47
ReportermigueldejuanaView Statuspublic 
Assigned Tovmromanos 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision3bb338d1e1a6
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionOracleAnt version
Product VersionSCM revision 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary

0041015: Filtering by 31-12-9999 in Oracle causes "Year out of range"

DescriptionIn org.openbravo.module.resource module, class ReservationEventObserver.java in checkOverlap function, we are setting endDate to 31-12-9999 in case it is null. This causes "Year out of range" in Oracle due to timezone converting the date in 01-01-10000.
Steps To Reproducen/a
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00279743.0PR14Q4 closedgorkaion Openbravo ERP Year Out of Range error in Oracle calculating costs 

-  Notes
(0112345)
hgbot (developer)
2019-06-03 18:32

 Repository: erp/pmods/org.openbravo.module.resources
Changeset: 52156e3950edf8b833656d84c9bedfedc3ffa60b
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Jun 03 18:27:25 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/52156e3950edf8b833656d84c9bedfedc3ffa60b [^]

Related to issue0041015: Filtering by 31-12-9999 in Oracle causes "Year out of range"

- Format RerservationEventObserver.java

---
M src/org/openbravo/module/resources/event/ReservationEventObserver.java
---
(0112346)
hgbot (developer)
2019-06-03 18:32

 Repository: erp/pmods/org.openbravo.module.resources
Changeset: 1c3b2964536c2040ec962cc2203518ac19816057
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Jun 03 18:32:08 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/1c3b2964536c2040ec962cc2203518ac19816057 [^]

Fixed issue 0041015: Filtering by 31-12-9999 in Oracle causes "Year out of range"

- If endDate is null do not add a restriction to startTime to avoid year out of range

---
M src/org/openbravo/module/resources/event/ReservationEventObserver.java
---
(0112377)
hgbot (developer)
2019-06-04 12:24

 Repository: erp/pmods/org.openbravo.module.resources
Changeset: a3156942ac899ce0d080ec9dcca53d175418f54d
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Jun 04 12:22:54 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/a3156942ac899ce0d080ec9dcca53d175418f54d [^]

Related to issue 0041015: Filtering by 31-12-9999 in Oracle causes "Year out of range"

Backed out changeset 1c3b2964536c

---
M src/org/openbravo/module/resources/event/ReservationEventObserver.java
---
(0112378)
hgbot (developer)
2019-06-04 12:24

 Repository: erp/pmods/org.openbravo.module.resources
Changeset: d0b2c49a8c87f279edd4ccf2a6bc94c983420075
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Jun 04 12:24:05 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/d0b2c49a8c87f279edd4ccf2a6bc94c983420075 [^]

Fixed issue 0041015: Filtering by 31-12-9999 in Oracle causes "Year out of range"

- Reduce one day the enDate to avoid timezone bug (reach year 10000)

---
M src/org/openbravo/module/resources/event/ReservationEventObserver.java
---
(0112380)
hgbot (developer)
2019-06-04 13:09

 Repository: erp/pmods/org.openbravo.module.resources
Changeset: 9e2fc9fa53a4479c7ca4d6c1f3d742cba7e3c9b4
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Jun 04 13:09:16 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/9e2fc9fa53a4479c7ca4d6c1f3d742cba7e3c9b4 [^]

Fixed issue 0041015: Filtering by 31-12-9999 in Oracle causes "Year out of range"

- Add a comment to clarify why the value is 30

---
M src/org/openbravo/module/resources/event/ReservationEventObserver.java
---
(0112442)
hgbot (developer)
2019-06-05 19:02

 Repository: erp/pmods/org.openbravo.module.resources
Changeset: 3bb338d1e1a6d570ab0e5167e008d3661e01bc61
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Jun 05 19:02:08 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/3bb338d1e1a6d570ab0e5167e008d3661e01bc61 [^]

Fixed issue 0041015: Filtering by 31-12-9999 in Oracle causes "Year out of range"

- Also change month to 11 because Calendar starts with 0=January

---
M src/org/openbravo/module/resources/event/ReservationEventObserver.java
---
(0112453)
vmromanos (viewer)
2019-06-06 08:47

 Code review OK

- Issue History
Date Modified Username Field Change
2019-06-03 18:03 migueldejuana New Issue
2019-06-03 18:03 migueldejuana Assigned To => vmromanos
2019-06-03 18:03 migueldejuana OBNetwork customer => No
2019-06-03 18:19 migueldejuana Relationship added related to 0027974
2019-06-03 18:32 hgbot Checkin
2019-06-03 18:32 hgbot Note Added: 0112345
2019-06-03 18:32 hgbot Checkin
2019-06-03 18:32 hgbot Note Added: 0112346
2019-06-03 18:32 hgbot Status new => resolved
2019-06-03 18:32 hgbot Resolution open => fixed
2019-06-03 18:32 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/1c3b2964536c2040ec962cc2203518ac19816057 [^]
2019-06-04 12:24 hgbot Checkin
2019-06-04 12:24 hgbot Note Added: 0112377
2019-06-04 12:24 hgbot Checkin
2019-06-04 12:24 hgbot Note Added: 0112378
2019-06-04 12:24 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/1c3b2964536c2040ec962cc2203518ac19816057 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/d0b2c49a8c87f279edd4ccf2a6bc94c983420075 [^]
2019-06-04 13:09 hgbot Checkin
2019-06-04 13:09 hgbot Note Added: 0112380
2019-06-04 13:09 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/d0b2c49a8c87f279edd4ccf2a6bc94c983420075 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/9e2fc9fa53a4479c7ca4d6c1f3d742cba7e3c9b4 [^]
2019-06-05 19:02 hgbot Checkin
2019-06-05 19:02 hgbot Note Added: 0112442
2019-06-05 19:02 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/9e2fc9fa53a4479c7ca4d6c1f3d742cba7e3c9b4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/3bb338d1e1a6d570ab0e5167e008d3661e01bc61 [^]
2019-06-06 08:47 vmromanos Review Assigned To => vmromanos
2019-06-06 08:47 vmromanos Note Added: 0112453
2019-06-06 08:47 vmromanos Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker