Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041015ModulesResource and Reservation Managementpublic2019-06-03 18:032019-06-06 08:47
Reportermigueldejuana 
Assigned Tovmromanos 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0041015: Filtering by 31-12-9999 in Oracle causes "Year out of range"
DescriptionIn org.openbravo.module.resource module, class ReservationEventObserver.java in checkOverlap function, we are setting endDate to 31-12-9999 in case it is null. This causes "Year out of range" in Oracle due to timezone converting the date in 01-01-10000.
Steps To Reproducen/a
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00279743.0PR14Q4 closed gorkaion Openbravo ERP Year Out of Range error in Oracle calculating costs 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-06-03 18:03migueldejuanaNew Issue
2019-06-03 18:03migueldejuanaAssigned To => vmromanos
2019-06-03 18:03migueldejuanaOBNetwork customer => No
2019-06-03 18:19migueldejuanaRelationship addedrelated to 0027974
2019-06-03 18:32hgbotCheckin
2019-06-03 18:32hgbotNote Added: 0112345
2019-06-03 18:32hgbotCheckin
2019-06-03 18:32hgbotNote Added: 0112346
2019-06-03 18:32hgbotStatusnew => resolved
2019-06-03 18:32hgbotResolutionopen => fixed
2019-06-03 18:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/1c3b2964536c2040ec962cc2203518ac19816057 [^]
2019-06-04 12:24hgbotCheckin
2019-06-04 12:24hgbotNote Added: 0112377
2019-06-04 12:24hgbotCheckin
2019-06-04 12:24hgbotNote Added: 0112378
2019-06-04 12:24hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/1c3b2964536c2040ec962cc2203518ac19816057 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/d0b2c49a8c87f279edd4ccf2a6bc94c983420075 [^]
2019-06-04 13:09hgbotCheckin
2019-06-04 13:09hgbotNote Added: 0112380
2019-06-04 13:09hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/d0b2c49a8c87f279edd4ccf2a6bc94c983420075 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/9e2fc9fa53a4479c7ca4d6c1f3d742cba7e3c9b4 [^]
2019-06-05 19:02hgbotCheckin
2019-06-05 19:02hgbotNote Added: 0112442
2019-06-05 19:02hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/9e2fc9fa53a4479c7ca4d6c1f3d742cba7e3c9b4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/3bb338d1e1a6d570ab0e5167e008d3661e01bc61 [^]
2019-06-06 08:47vmromanosReview Assigned To => vmromanos
2019-06-06 08:47vmromanosNote Added: 0112453
2019-06-06 08:47vmromanosStatusresolved => closed

Notes
(0112345)
hgbot   
2019-06-03 18:32   
Repository: erp/pmods/org.openbravo.module.resources
Changeset: 52156e3950edf8b833656d84c9bedfedc3ffa60b
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Jun 03 18:27:25 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/52156e3950edf8b833656d84c9bedfedc3ffa60b [^]

Related to issue0041015: Filtering by 31-12-9999 in Oracle causes "Year out of range"

- Format RerservationEventObserver.java

---
M src/org/openbravo/module/resources/event/ReservationEventObserver.java
---
(0112346)
hgbot   
2019-06-03 18:32   
Repository: erp/pmods/org.openbravo.module.resources
Changeset: 1c3b2964536c2040ec962cc2203518ac19816057
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Jun 03 18:32:08 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/1c3b2964536c2040ec962cc2203518ac19816057 [^]

Fixed issue 0041015: Filtering by 31-12-9999 in Oracle causes "Year out of range"

- If endDate is null do not add a restriction to startTime to avoid year out of range

---
M src/org/openbravo/module/resources/event/ReservationEventObserver.java
---
(0112377)
hgbot   
2019-06-04 12:24   
Repository: erp/pmods/org.openbravo.module.resources
Changeset: a3156942ac899ce0d080ec9dcca53d175418f54d
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Jun 04 12:22:54 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/a3156942ac899ce0d080ec9dcca53d175418f54d [^]

Related to issue 0041015: Filtering by 31-12-9999 in Oracle causes "Year out of range"

Backed out changeset 1c3b2964536c

---
M src/org/openbravo/module/resources/event/ReservationEventObserver.java
---
(0112378)
hgbot   
2019-06-04 12:24   
Repository: erp/pmods/org.openbravo.module.resources
Changeset: d0b2c49a8c87f279edd4ccf2a6bc94c983420075
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Jun 04 12:24:05 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/d0b2c49a8c87f279edd4ccf2a6bc94c983420075 [^]

Fixed issue 0041015: Filtering by 31-12-9999 in Oracle causes "Year out of range"

- Reduce one day the enDate to avoid timezone bug (reach year 10000)

---
M src/org/openbravo/module/resources/event/ReservationEventObserver.java
---
(0112380)
hgbot   
2019-06-04 13:09   
Repository: erp/pmods/org.openbravo.module.resources
Changeset: 9e2fc9fa53a4479c7ca4d6c1f3d742cba7e3c9b4
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Jun 04 13:09:16 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/9e2fc9fa53a4479c7ca4d6c1f3d742cba7e3c9b4 [^]

Fixed issue 0041015: Filtering by 31-12-9999 in Oracle causes "Year out of range"

- Add a comment to clarify why the value is 30

---
M src/org/openbravo/module/resources/event/ReservationEventObserver.java
---
(0112442)
hgbot   
2019-06-05 19:02   
Repository: erp/pmods/org.openbravo.module.resources
Changeset: 3bb338d1e1a6d570ab0e5167e008d3661e01bc61
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Jun 05 19:02:08 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.resources/rev/3bb338d1e1a6d570ab0e5167e008d3661e01bc61 [^]

Fixed issue 0041015: Filtering by 31-12-9999 in Oracle causes "Year out of range"

- Also change month to 11 because Calendar starts with 0=January

---
M src/org/openbravo/module/resources/event/ReservationEventObserver.java
---
(0112453)
vmromanos   
2019-06-06 08:47   
Code review OK