Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0040946 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | major | always | 2019-05-24 11:51 | 2019-08-03 21:47 | |||
Reporter | aaroncalero | View Status | public | |||||
Assigned To | ranjith_qualiantech_com | |||||||
Priority | high | Resolution | fixed | Fixed in Version | RR19Q3 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | marvintm | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0040946: [Loyalty] Several api functions should implement error callbacks | |||||||
Description | There are several api functions in the javascript code of the Loyalty Programs for Web POS module that should implement error callbacks. OBRLP.findActiveSubscriptions and OBRLP.computeLoyaltySummary both use internally OBRLP.findSubscriptions, which is a query to retrieve Loyalty Subscription information. Since this query can be done server side (when the Remote For Customers preference is enabled), the code should be able to manage the case in which the server doesn't respond correctly. | |||||||
Steps To Reproduce | Check the code for OBRLP.findSubscriptions here: https://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty.programs/file/tip/web/org.openbravo.retail.loyalty.programs/js/component/subscription-icon.js#l39 [^] | |||||||
Proposed Solution | Add an errroCallback parameter to OBRLP.findSubscriptions, and also to the functions invoking it. | |||||||
Tags | No tags attached. | |||||||
Attached Files | issue 40946 source loyaltyprograms.patch [^] (1,757 bytes) 2019-07-02 14:56 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0113166) hgbot (developer) 2019-07-04 08:21 |
Repository: erp/pmods/org.openbravo.retail.loyalty.programs Changeset: c249b151b21179ba5a766123118022ef2a2fbd8e Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Thu Jul 04 11:51:15 2019 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty.programs/rev/c249b151b21179ba5a766123118022ef2a2fbd8e [^] Related to issue 40946 : Added errroCallback for findSubscriptions function --- M web/org.openbravo.retail.loyalty.programs/js/component/subscription-buttons.js M web/org.openbravo.retail.loyalty.programs/js/component/subscription-icon.js --- |
(0113189) hgbot (developer) 2019-07-04 19:29 |
Repository: erp/pmods/org.openbravo.retail.loyalty.programs Changeset: fa8bff23e629410f54c3ff7e9a51ab1748096ad8 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Thu Jul 04 19:28:52 2019 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty.programs/rev/fa8bff23e629410f54c3ff7e9a51ab1748096ad8 [^] Related to issue 40946. Fixed typo. --- M web/org.openbravo.retail.loyalty.programs/js/component/subscription-icon.js --- |
(0113800) hgbot (developer) 2019-08-03 21:47 |
Repository: erp/pmods/org.openbravo.retail.loyalty.programs Changeset: 04269dcfb228aa598f6aedfec98831136107653a Author: Mark Molina <mark.molina <at> doceleguas.com> Date: Sun Jul 07 19:10:02 2019 -0300 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty.programs/rev/04269dcfb228aa598f6aedfec98831136107653a [^] [LPNR] Temporarily backout changes for issue 40946 --- M web/org.openbravo.retail.loyalty.programs/js/component/subscription-buttons.js M web/org.openbravo.retail.loyalty.programs/js/component/subscription-icon.js --- |
Issue History | |||
Date Modified | Username | Field | Change |
2019-05-24 11:51 | aaroncalero | New Issue | |
2019-05-24 11:51 | aaroncalero | Assigned To | => Retail |
2019-05-24 11:51 | aaroncalero | Resolution time | => 1559858400 |
2019-05-24 11:51 | aaroncalero | Triggers an Emergency Pack | => No |
2019-06-25 14:52 | aaroncalero | Resolution time | 1559858400 => 1563228000 |
2019-06-25 14:52 | aaroncalero | Type | design defect => defect |
2019-07-02 08:24 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
2019-07-02 08:24 | ranjith_qualiantech_com | Status | new => scheduled |
2019-07-02 14:56 | ranjith_qualiantech_com | File Added: issue 40946 source loyaltyprograms.patch | |
2019-07-04 08:21 | hgbot | Checkin | |
2019-07-04 08:21 | hgbot | Note Added: 0113166 | |
2019-07-04 17:44 | ranjith_qualiantech_com | Status | scheduled => resolved |
2019-07-04 17:44 | ranjith_qualiantech_com | Resolution | open => fixed |
2019-07-04 19:29 | hgbot | Checkin | |
2019-07-04 19:29 | hgbot | Note Added: 0113189 | |
2019-07-04 19:30 | marvintm | Review Assigned To | => marvintm |
2019-07-04 19:30 | marvintm | Status | resolved => closed |
2019-07-04 19:30 | marvintm | Fixed in Version | => RR19Q3 |
2019-08-03 21:47 | hgbot | Checkin | |
2019-08-03 21:47 | hgbot | Note Added: 0113800 |
Copyright © 2000 - 2009 MantisBT Group |