Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0040946 | Retail Modules | Web POS | public | 2019-05-24 11:51 | 2019-08-03 21:47 |
|
| Reporter | aaroncalero | |
| Assigned To | ranjith_qualiantech_com | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR19Q3 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0040946: [Loyalty] Several api functions should implement error callbacks |
| Description | There are several api functions in the javascript code of the Loyalty Programs for Web POS module that should implement error callbacks.
OBRLP.findActiveSubscriptions and OBRLP.computeLoyaltySummary both use internally OBRLP.findSubscriptions, which is a query to retrieve Loyalty Subscription information. Since this query can be done server side (when the Remote For Customers preference is enabled), the code should be able to manage the case in which the server doesn't respond correctly. |
| Steps To Reproduce | Check the code for OBRLP.findSubscriptions here:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty.programs/file/tip/web/org.openbravo.retail.loyalty.programs/js/component/subscription-icon.js#l39 [^] |
| Proposed Solution | Add an errroCallback parameter to OBRLP.findSubscriptions, and also to the functions invoking it. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  issue 40946 source loyaltyprograms.patch (1,757) 2019-07-02 14:56
https://issues.openbravo.com/file_download.php?file_id=13080&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2019-05-24 11:51 | aaroncalero | New Issue | |
| 2019-05-24 11:51 | aaroncalero | Assigned To | => Retail |
| 2019-05-24 11:51 | aaroncalero | Resolution time | => 1559858400 |
| 2019-05-24 11:51 | aaroncalero | Triggers an Emergency Pack | => No |
| 2019-06-25 14:52 | aaroncalero | Resolution time | 1559858400 => 1563228000 |
| 2019-06-25 14:52 | aaroncalero | Type | design defect => defect |
| 2019-07-02 08:24 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2019-07-02 08:24 | ranjith_qualiantech_com | Status | new => scheduled |
| 2019-07-02 14:56 | ranjith_qualiantech_com | File Added: issue 40946 source loyaltyprograms.patch | |
| 2019-07-04 08:21 | hgbot | Checkin | |
| 2019-07-04 08:21 | hgbot | Note Added: 0113166 | |
| 2019-07-04 17:44 | ranjith_qualiantech_com | Status | scheduled => resolved |
| 2019-07-04 17:44 | ranjith_qualiantech_com | Resolution | open => fixed |
| 2019-07-04 19:29 | hgbot | Checkin | |
| 2019-07-04 19:29 | hgbot | Note Added: 0113189 | |
| 2019-07-04 19:30 | marvintm | Review Assigned To | => marvintm |
| 2019-07-04 19:30 | marvintm | Status | resolved => closed |
| 2019-07-04 19:30 | marvintm | Fixed in Version | => RR19Q3 |
| 2019-08-03 21:47 | hgbot | Checkin | |
| 2019-08-03 21:47 | hgbot | Note Added: 0113800 | |