0040940: CheckApproval does not support cross domain calls in multi-server

Description

In multi-server when approving a ticket the checkapproval servlet does not allow cross domain calls so webpos will always call central (as the store server will deny access).

This means that checkapproval does not work offline.

Steps To Reproduce

Install multi-server
Enable price change approval
Create ticket and change price
when approving check the chrome network console and see cors denial from the store server

Proposed Solution

Enable cors for the check approval servlet. See attached diff

Tags

No tags attached.

Attached Files

check-approval.diff [^] (945 bytes) 2019-05-23 12:16 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/posterminal/utility/CheckApproval.java b/src/org/openbravo/retail/posterminal/utility/CheckApproval.java
--- a/src/org/openbravo/retail/posterminal/utility/CheckApproval.java
+++ b/src/org/openbravo/retail/posterminal/utility/CheckApproval.java
@@ -30,6 +30,7 @@
 import org.codehaus.jettison.json.JSONObject;
 import org.hibernate.criterion.Restrictions;
 import org.hibernate.query.Query;
+import org.openbravo.base.secureApp.AllowedCrossDomainsHandler;
 import org.openbravo.dal.core.OBContext;
 import org.openbravo.dal.service.OBCriteria;
 import org.openbravo.dal.service.OBDal;
@@ -58,6 +59,8 @@
   @Override
   public void doGet(HttpServletRequest request, HttpServletResponse response)
       throws IOException, ServletException {
+    // always set the cors headers
+    AllowedCrossDomainsHandler.getInstance().setCORSHeaders(request, response);
 
     OBContext.setAdminMode(false);
     try {

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

0039189

closed

Retail

API Change - CheckApproval extends from HttpServlet instead of JSONProcessSimple

Notes
(0112138) hgbot (developer) 2019-05-25 21:56	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: ac5dfd1c1553948e25b8c58ec8408134329878da Author: Martin Taal <martin.taal <at> openbravo.com> Date: Sat May 25 12:02:02 2019 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ac5dfd1c1553948e25b8c58ec8408134329878da [^] Fixes issue 40940: CheckApproval does not support cross domain calls in multi-server Set cors headers --- M src/org/openbravo/retail/posterminal/utility/CheckApproval.java ---

(0112139) mtaal (manager) 2019-05-25 22:05	reviewed by Antonio

Issue History
Date Modified	Username	Field	Change
2019-05-23 12:16	mtaal	New Issue
2019-05-23 12:16	mtaal	Assigned To	=> mtaal
2019-05-23 12:16	mtaal	File Added: check-approval.diff
2019-05-23 12:16	mtaal	Triggers an Emergency Pack	=> No
2019-05-23 12:16	mtaal	Relationship added	related to 0039189
2019-05-25 21:56	hgbot	Checkin
2019-05-25 21:56	hgbot	Note Added: 0112138
2019-05-25 21:56	hgbot	Status	new => resolved
2019-05-25 21:56	hgbot	Resolution	open => fixed
2019-05-25 21:56	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ac5dfd1c1553948e25b8c58ec8408134329878da [^]
2019-05-25 22:05	mtaal	Note Added: 0112139
2019-05-25 22:05	mtaal	Status	resolved => closed