Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040940Retail ModulesStoreServerpublic2019-05-23 12:162019-05-25 22:05
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040940: CheckApproval does not support cross domain calls in multi-server
DescriptionIn multi-server when approving a ticket the checkapproval servlet does not allow cross domain calls so webpos will always call central (as the store server will deny access).

This means that checkapproval does not work offline.
Steps To ReproduceInstall multi-server
Enable price change approval
Create ticket and change price
when approving check the chrome network console and see cors denial from the store server
Proposed SolutionEnable cors for the check approval servlet. See attached diff
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039189 closed Retail API Change - CheckApproval extends from HttpServlet instead of JSONProcessSimple 
Attached Filesdiff check-approval.diff (945) 2019-05-23 12:16
https://issues.openbravo.com/file_download.php?file_id=12979&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-05-23 12:16mtaalNew Issue
2019-05-23 12:16mtaalAssigned To => mtaal
2019-05-23 12:16mtaalFile Added: check-approval.diff
2019-05-23 12:16mtaalTriggers an Emergency Pack => No
2019-05-23 12:16mtaalRelationship addedrelated to 0039189
2019-05-25 21:56hgbotCheckin
2019-05-25 21:56hgbotNote Added: 0112138
2019-05-25 21:56hgbotStatusnew => resolved
2019-05-25 21:56hgbotResolutionopen => fixed
2019-05-25 21:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ac5dfd1c1553948e25b8c58ec8408134329878da [^]
2019-05-25 22:05mtaalNote Added: 0112139
2019-05-25 22:05mtaalStatusresolved => closed

Notes
(0112138)
hgbot   
2019-05-25 21:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ac5dfd1c1553948e25b8c58ec8408134329878da
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sat May 25 12:02:02 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ac5dfd1c1553948e25b8c58ec8408134329878da [^]

Fixes issue 40940: CheckApproval does not support cross domain calls in multi-server
Set cors headers

---
M src/org/openbravo/retail/posterminal/utility/CheckApproval.java
---
(0112139)
mtaal   
2019-05-25 22:05   
reviewed by Antonio